Re: RFR: JDK-8241602 jlink does not produce reproducible jimage files

2020-05-06 Thread Jim Laskey
Thank you. Notes below. updated webrev: http://cr.openjdk.java.net/~jlaskey/8241602/webrev-00 > On May 6, 2020, at 4:14 AM, Alan Bateman wrote: > > On 05/05/2020 20:56, Jim Laskey wrote: >> This fix addresses the inconsistent ordering

Re: RFR: JDK-8241602 jlink does not produce reproducible jimage files

2020-05-06 Thread Alan Bateman
On 05/05/2020 20:56, Jim Laskey wrote: This fix addresses the inconsistent ordering by jimage content by jlink from run to run. Bottom line, the implementer was using HashSet without defining hashcode/equals for the Set entry classes. webrev:

Re: RFR: JDK-8241602 jlink does not produce reproducible jimage files

2020-05-06 Thread Magnus Ihse Bursie
On 2020-05-05 21:56, Jim Laskey wrote: This fix addresses the inconsistent ordering by jimage content by jlink from run to run. Bottom line, the implementer was using HashSet without defining hashcode/equals for the Set entry classes. webrev:

RFR: JDK-8241602 jlink does not produce reproducible jimage files

2020-05-05 Thread Jim Laskey
This fix addresses the inconsistent ordering by jimage content by jlink from run to run. Bottom line, the implementer was using HashSet without defining hashcode/equals for the Set entry classes. webrev: http://cr.openjdk.java.net/~jlaskey/8241602/webrev-00