Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-23 Thread Alexey Semenyuk
Thank you for the review! Whitespace issues will be fixed in the final patch. - Alexey On 4/23/2020 2:51 PM, Erik Joelsson wrote: Thanks, that looks good! Only two minor whitespace nits. Line 32-33, 102-103: continuation indent 4 spaces Line 101: extra space No need for new webrev. /Erik

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-23 Thread Erik Joelsson
Thanks, that looks good! Only two minor whitespace nits. Line 32-33, 102-103: continuation indent 4 spaces Line 101: extra space No need for new webrev. /Erik On 2020-04-23 11:38, Alexey Semenyuk wrote: Erik, Please review updated patch with the suggested improvements at [1]. The webrev

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-23 Thread Alexey Semenyuk
Erik, Please review updated patch with the suggested improvements at [1]. The webrev includes only incremental changes to Lib-jdk.incubator.jpackage.gmk for clarity. [1] http://cr.openjdk.java.net/~asemenyuk/8242302/webrev.01/webrev.01/index.html - Alexey On 4/20/2020 1:17 PM, Erik

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-20 Thread Erik Joelsson
(adding build-dev) Hello Alexey, The SetupJdkExecutable and SetupJdkLibrary macros are designed to find the correct source dirs automatically as long as they follow the standard naming. In this case you are adding some extra with the "common" dir as well as reusing some src dirs between

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-17 Thread Alexander Matveev
Hi Alexey, Looks good. Thanks, Alexander On 4/16/20 10:37 AM, Andy Herrick wrote: OK - I approve. - I have tested on 2 platforms and it looks good. /Andy On 4/15/2020 4:13 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Refactor jpackage native code. - Improve code

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-16 Thread Andy Herrick
OK - I approve. - I have tested on 2 platforms and it looks good. /Andy On 4/15/2020 4:13 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Refactor jpackage native code. - Improve code reuse between different platforms. - Replace custom string classes with the standard

RFR: JDK-8242302 : Refactor jpackage native code

2020-04-15 Thread Alexey Semenyuk
Please review fix [2] for jpackage bug [1]. Refactor jpackage native code. - Improve code reuse between different platforms. - Replace custom string classes with the standard std::basic_string. - Merge functionality of libapplauncher.dll(.so) library with jpackageapplauncher(.exe) binary.