Re: RFR: jsr166 jdk10 integration wave 6

2017-11-29 Thread Doug Lea
On 11/29/2017 01:43 PM, Paul Sandoz wrote: > SubmissionPublisher > -- > > 1004 // Order-sensitive field declarations > > Is this still relevant Not really; layout is now discussed in class-level doc. Removed. Thanks. > > 81 * A single SubmissionPublisher may be shared among multiple >

Re: RFR: jsr166 jdk10 integration wave 6

2017-11-29 Thread Paul Sandoz
> On 27 Nov 2017, at 20:19, Martin Buchholz wrote: > > http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/overview.html > > > > Thanks to Dávid Karnok and Pavel Rappo for help with Su

Re: RFR: jsr166 jdk10 integration wave 6

2017-11-28 Thread Martin Buchholz
On Tue, Nov 28, 2017 at 9:50 AM, Paul Sandoz wrote: > > 1296 public void testCancelCancelRace() throws > InterruptedException { > > Suggest “DISABLED_” prefix rather than “? > done.

Re: RFR: jsr166 jdk10 integration wave 6

2017-11-28 Thread Doug Lea
On 11/28/2017 12:50 PM, Paul Sandoz wrote: > >> 8187947: A race condition in SubmissionPublisher > > Need some more time to look at this; it is pleasing to see use of > VH.getAndBitwiseOr :-) > > Yes; not only is it the technique that allows covering this borderline-misuse case without slowi

Re: RFR: jsr166 jdk10 integration wave 6

2017-11-28 Thread Paul Sandoz
> On 27 Nov 2017, at 20:19, Martin Buchholz wrote: > > http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/overview.html > > Thanks to Dávid Karnok and Pavel Rappo for help with SubmissionPublisher. > > 8191937: Lost interrupt in AbstractQueuedSynchronizer when tryAcquire

RFR: jsr166 jdk10 integration wave 6

2017-11-27 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/overview.html Thanks to Dávid Karnok and Pavel Rappo for help with SubmissionPublisher. 8191937: Lost interrupt in AbstractQueuedSynchronizer when tryAcquire methods throw 8187947: A race condition in SubmissionPublisher 8191

RFR: jsr166 jdk10 integration wave 6

2017-11-27 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/overview.html Thanks to Dávid Karnok and Pavel Rappo for help with SubmissionPublisher. 8191937: Lost interrupt in AbstractQueuedSynchronizer when tryAcquire methods throw 8187947: A race condition in SubmissionPublisher 8191