Re: RFR: jsr166 jdk9 integration wave 11

2016-09-22 Thread Martin Buchholz
On Thu, Sep 22, 2016 at 5:39 AM, Chris Hegarty wrote: > > Can you please check the indentation in testCopy_normalCompletion > and testCopy_exceptionalCompletion. > CompletableFutureTest.java has a unique experimental indentation style, that is not clearly worse than the alternatives.

Re: RFR: jsr166 jdk9 integration wave 11

2016-09-22 Thread Chris Hegarty
On 21 Sep 2016, at 20:33, Martin Buchholz wrote: > > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ > > Notable here is an attempt to make a minimal completion stage more acceptable > as a return value from APIs, by making > completableFuture.minimalCompletionStag

Re: RFR: jsr166 jdk9 integration wave 11

2016-09-21 Thread Aleksey Shipilev
On 09/21/2016 09:33 PM, Martin Buchholz wrote: > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ Looks fine. Multi-story predicates sure look better now... -Aleksey

RFR: jsr166 jdk9 integration wave 11

2016-09-21 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ Notable here is an attempt to make a minimal completion stage more acceptable as a return value from APIs, by making completableFuture.minimalCompletionStage().toCompletableFuture() useful. Lots of boring changes to appe