Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

2015-09-25 Thread huizhe wang
Thanks Mandy and Lance for the review! Changes pushed. -Joe On 9/25/2015 3:40 PM, Mandy Chung wrote: On 09/25/2015 02:38 PM, huizhe wang wrote: With this application/libraries used to put xml-apis-2.11.0.jar on the endorsed/ext directory or classpath no longer needs to do that because o

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

2015-09-25 Thread Mandy Chung
On 09/25/2015 02:38 PM, huizhe wang wrote: With this application/libraries used to put xml-apis-2.11.0.jar on the endorsed/ext directory or classpath no longer needs to do that because org.w3c.dom.ElementTraversal was not part of the DOM API endorsed by JAXP in JDK 8. I skimmed through t

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

2015-09-25 Thread huizhe wang
On 9/25/2015 2:18 PM, Mandy Chung wrote: On 09/25/2015 12:41 PM, huizhe wang wrote: Hi, Please review the DOM update to include the Element Traversal Specification. ElementTraversal is an interface which allows the author to restrict navigation to Element nodes. The implementation is the

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

2015-09-25 Thread Mandy Chung
On 09/25/2015 12:41 PM, huizhe wang wrote: Hi, Please review the DOM update to include the Element Traversal Specification. ElementTraversal is an interface which allows the author to restrict navigation to Element nodes. The implementation is the result of a merge with the upper Xerces so

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

2015-09-25 Thread huizhe wang
On 9/25/2015 1:15 PM, Lance Andersen wrote: Hi Joe, The change and the test looks overall. Thanks Lance! One minor suggestion on the javadocs, I might change to @{code} on line 177 Sure, changed. Makes me feel like we could use a @emphasize @em tag :-) Best, Joe Best Lance On Sep

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

2015-09-25 Thread Lance Andersen
Hi Joe, The change and the test looks overall. One minor suggestion on the javadocs, I might change to @{code} on line 177 Best Lance On Sep 25, 2015, at 3:41 PM, huizhe wang wrote: > Hi, > > Please review the DOM update to include the Element Traversal Specification. > ElementTraversal

RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

2015-09-25 Thread huizhe wang
Hi, Please review the DOM update to include the Element Traversal Specification. ElementTraversal is an interface which allows the author to restrict navigation to Element nodes. The implementation is the result of a merge with the upper Xerces source. The new methods implementation starts a