Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

2017-12-21 Thread Joe Wang
Thanks Lance! On 12/21/17, 4:12 PM, Lance @ Oracle wrote: Hi joe Looks fine Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington,

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

2017-12-21 Thread Lance @ Oracle
Hi joe Looks fine Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 21, 2017, at 6:48 PM, Joe Wang wrote: > > Hi Lance, >

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

2017-12-21 Thread Joe Wang
Hi Lance, Thanks for the review! As you suggested, the names in comments, and "Sun Microsystems" in a few cases in the following classes are removed. Updated webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html Happy Holidays! Best, Joe +++

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

2017-12-21 Thread Lance Andersen
Hi Joe, Overall, this is fine, a few things to consider if you want to address Happy Holidays Best Lance Do we really need to keep the name in comments such as these: final class TestSeq { --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java

RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

2017-12-21 Thread Joe Wang
Hi, This change uses a process to strip off the @sun.com email addresses and links, and keep just the name of the authors. Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8184431 webrev: http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html Thanks, Joe