Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-05 Thread Mikael Vidstedt
> On Jun 5, 2019, at 2:57 AM, Alan Bateman wrote: > > > > On 05/06/2019 03:29, Mikael Vidstedt wrote: >> I, too, agree. :) >> >> New webrev which adds a new ProblemList-aot.txt to be used when running >> tests with AOT. >> >> Webrev: >> http://cr.openjdk.java.net/~mikael/webrevs/8225305/

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-05 Thread Alan Bateman
On 05/06/2019 03:29, Mikael Vidstedt wrote: I, too, agree. :) New webrev which adds a new ProblemList-aot.txt to be used when running tests with AOT. Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8225305/webrev.01/open/webrev/

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-04 Thread Mandy Chung
Looks okay. Just to mention the alternativ: we could add "@requires !vm.aot.enabled" in those tests if only a few. Mandy On 6/4/19 7:29 PM, Mikael Vidstedt wrote: I, too, agree. :) New webrev which adds a new ProblemList-aot.txt to be used when running tests with AOT. Webrev: http://cr

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-04 Thread Igor Ignatev
LGTM! — Igor > On Jun 4, 2019, at 7:29 PM, Mikael Vidstedt > wrote: > > > I, too, agree. :) > > New webrev which adds a new ProblemList-aot.txt to be used when running tests > with AOT. > > Webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8225305/webrev.01/open/webrev/ > > Cheers, >

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-04 Thread Mikael Vidstedt
I, too, agree. :) New webrev which adds a new ProblemList-aot.txt to be used when running tests with AOT. Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8225305/webrev.01/open/webrev/ Cheers, Mikael > On Jun 4,

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-04 Thread Mandy Chung
I agree with Igor.  The best is to keep running these tests except the AOT, perhaps + fastdebug, run only. Mandy On 6/4/19 2:06 PM, Igor Ignatyev wrote: Hi Mikael, as it looks like 8222445 isn't going to be fixed for a long time (as it's "targeted" to tbd), and the defect seems to affect only

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-04 Thread Igor Ignatyev
Hi Mikael, as it looks like 8222445 isn't going to be fixed for a long time (as it's "targeted" to tbd), and the defect seems to affect only AOT run, I don't think it's a good idea to put these tests into a general problem list. I'd suggest to either create aot-specific problem list or put them

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-04 Thread Vladimir Kozlov
Looks good. Thanks Vladimir > On Jun 4, 2019, at 1:38 PM, Mikael Vidstedt > wrote: > > > The following java/lang/invoke/VarHandles tests frequently fail when run with > AOT. Until https://bugs.openjdk.java.net/browse/JDK-8222445 has been fixed > they should be problem listed. > > java/lan

RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

2019-06-04 Thread Mikael Vidstedt
The following java/lang/invoke/VarHandles tests frequently fail when run with AOT. Until https://bugs.openjdk.java.net/browse/JDK-8222445 has been fixed they should be problem listed. java/lang/invoke/VarHandles/VarHandleTestByteArrayAsShort