Re: RFR [9] 8081517: minor cleanup for docs

Thanks! On 05.06.2015 21:32, Roger Riggs wrote: Hi Alexander, Looks good, thanks for the updates. Roger On 6/5/2015 1:33 PM, alexander stepanov wrote: Hello Lance, Roger, Thank you for the notes, please see the updated webrev:

RFR [9] 8081517: minor cleanup for docs

Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8081517 Just some cleanup for docs. Thanks, Alexander

Re: RFR [9] 8081517: minor cleanup for docs

Hi Alxander Overall. looks OK. A couple of things I thought could be changed; In FTPURLConnection, I probably would surround the code in an {@code} tag In VmIdentifier, I do not see think we still need p in the LI tags Best Lance On Jun 5, 2015, at 8:51 AM, alexander stepanov

Re: RFR [9] 8081517: minor cleanup for docs

Hi Alexander, On code examples, please use the template: pre{@code }/pre (not just pre... /pre) See TraceClassVisitor.java: 92+ andFtpURLConnection.java:68 I would use @code instead of @literal in HttpAuthenticator.java:59; it will make the protocol stand out. Also in

Re: RFR [9] 8081517: minor cleanup for docs

Hi Roger On Jun 5, 2015, at 10:08 AM, Roger Riggs roger.ri...@oracle.com wrote: 2) If indentation is in the scope of your cleanup… Agree with you and I did not comment on this as I felt it this should be done separately as there is a fair amount that can be done in these classes for clean

Re: RFR [9] 8081517: minor cleanup for docs

Hi Alexander On Jun 5, 2015, at 1:33 PM, alexander stepanov alexander.v.stepa...@oracle.com wrote: Hello Lance, Roger, Thank you for the notes, please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8081517/webrev.01/index.html (files changed: FtpURLConnection.java,

Re: RFR [9] 8081517: minor cleanup for docs

Hi Alexander, Looks good, thanks for the updates. Roger On 6/5/2015 1:33 PM, alexander stepanov wrote: Hello Lance, Roger, Thank you for the notes, please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8081517/webrev.01/index.html (files changed: FtpURLConnection.java,

Re: RFR [9] 8081517: minor cleanup for docs

Hello Lance, Roger, Thank you for the notes, please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8081517/webrev.01/index.html (files changed: FtpURLConnection.java, VmIdentifier.java, TraceClassVisitor.java, HttpAuthenticator.java, PlatformLogger.java and JdbcRowSetImpl.java -

Re: RFR [9] 8081517: minor cleanup for docs

ok, as Lance mentioned, that can be deferred. Roger On 6/5/2015 10:59 AM, alexander stepanov wrote: indentation is in the scope of your cleanup No, I didn't check the indents, lengths of lines etc. (sorry). The intention was just to fix some tidy warnings (like empty p tags) and javadoc

Re: RFR [9] 8081517: minor cleanup for docs

indentation is in the scope of your cleanup No, I didn't check the indents, lengths of lines etc. (sorry). The intention was just to fix some tidy warnings (like empty p tags) and javadoc errors like invalid parameter names, invalid tags etc. Tags code/code were replaced with {@code} in