RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-26 Thread Vladimir Shcherbakov
Shcherbakov <vlas...@microsoft.com> Cc: Naoto Sato <naoto.s...@oracle.com>; Kumar Srinivasan <kumar.x.sriniva...@oracle.com>; Martin Sawicki <marc...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR 8124977 cmdline encoding c

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-26 Thread Vladimir Shcherbakov
G <xueming.s...@oracle.com> Cc: Martin Sawicki <marc...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hello, Sorry if this has already been discussed, but this is my first time looking a

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Xueming Shen
Tuesday, February 23, 2016 10:47 AM To: Kumar Srinivasan <kumar.x.sriniva...@oracle.com>; Vladimir Shcherbakov <vlas...@microsoft.com>; SHEN,XUEMING <xueming.s...@oracle.com> Cc: Martin Sawicki <marc...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: R

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Xueming Shen
to:naoto.s...@oracle.com] Sent: Tuesday, February 23, 2016 10:47 AM To: Kumar Srinivasan <kumar.x.sriniva...@oracle.com>; Vladimir Shcherbakov <vlas...@microsoft.com>; SHEN,XUEMING <xueming.s...@oracle.com> Cc: Martin Sawicki <marc...@microsoft.com>; core-libs-dev

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Naoto Sato
To: Kumar Srinivasan <kumar.x.sriniva...@oracle.com>; Vladimir Shcherbakov <vlas...@microsoft.com>; SHEN,XUEMING <xueming.s...@oracle.com> Cc: Martin Sawicki <marc...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR 8124977 cmd

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Vladimir Shcherbakov
Shcherbakov <vlas...@microsoft.com> Cc: Naoto Sato <naoto.s...@oracle.com>; SHEN,XUEMING <xueming.s...@oracle.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Few more comments on the tests: UnicodeCmdTestRu

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Naoto Sato
6 11:34 AM To: Kumar Srinivasan <kumar.x.sriniva...@oracle.com>; Vladimir Shcherbakov <vlas...@microsoft.com> Cc: core-libs-dev Libs <core-libs-dev@openjdk.java.net>; Naoto Sato <naoto.s...@oracle.com> Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Thanks fo

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-22 Thread Vladimir Shcherbakov
[mailto:kumar.x.sriniva...@oracle.com] Sent: Tuesday, January 12, 2016 2:35 PM To: Martin Sawicki <marc...@microsoft.com>; Vladimir Shcherbakov <vlas...@microsoft.com> Cc: core-libs-dev Libs <core-libs-dev@openjdk.java.net>; Naoto Sato <naoto.s...@oracle.com> Subject: Re: RFR 81

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-22 Thread Kumar Srinivasan
o.s...@oracle.com> Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Thanks for the feedback. Investigating the regression failure. We'll get back as soon as we figure this out. (and yes, we'll run this through some localized Windows VMs) Cheers -Original M

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-22 Thread Kumar Srinivasan
iva...@oracle.com>; Vladimir Shcherbakov <vlas...@microsoft.com> Cc: core-libs-dev Libs <core-libs-dev@openjdk.java.net>; Naoto Sato <naoto.s...@oracle.com> Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Thanks for the feedback. Investigating the regression failure

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-01-14 Thread Martin Sawicki
12, 2016 2:35 PM To: Martin Sawicki <marc...@microsoft.com>; Vladimir Shcherbakov <vlas...@microsoft.com> Cc: core-libs-dev Libs <core-libs-dev@openjdk.java.net>; Naoto Sato <naoto.s...@oracle.com> Subject: Re: RFR 8124977 cmdline encoding challenges on Wind

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-01-12 Thread Kumar Srinivasan
com>; Martin Sawicki <marc...@microsoft.com> Cc: Kirk Shoop <kirk.sh...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Hi Kumar, Please find updated webreview here: http://cr.openjdk.java.net/~

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-01-11 Thread Kumar Srinivasan
Srinivasan <kumar.x.sriniva...@oracle.com>; Martin Sawicki <marc...@microsoft.com> Cc: Kirk Shoop <kirk.sh...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Hi Kumar, Please find upda

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-01-07 Thread Martin Sawicki
: Kirk Shoop <kirk.sh...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Hi Kumar, Please find updated webreview here: http://cr.openjdk.java.net/~kshoop/8124977/webrev.04/ Thanks, Vladimir. -Or

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-11-30 Thread Vladimir Shcherbakov
gt; Cc: Kirk Shoop <kirk.sh...@microsoft.com>; Vladimir Shcherbakov <vlas...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Martin, et. al., Sorry for not getting back earlier, I am very busy

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-11-22 Thread Kumar Srinivasan
15 6:26 AM To: Kirk Shoop (MS OPEN TECH) <kirk.sh...@microsoft.com> Cc: Valery Kopylov (Akvelon) <v-val...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Kirk, Thanks for proposing this change.

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-09-28 Thread Martin Sawicki
on) <v-val...@microsoft.com>; core-libs-dev Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Kirk, Thanks for proposing this change. If you notice all the posix calls are wrapped in JLI_* this gives us the ability to use

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-08-07 Thread Martin Buchholz
(only half paying attention) On Wed, Aug 5, 2015 at 7:45 PM, Kirk Shoop kirk.sh...@microsoft.com wrote: This webrev uses GetCommandLineW That sounds right - this should be the source of truth in win32land. on windows to retrieve the UCS16 UCS16 confuses me. Do you mean UTF-16 or UCS-2?

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-08-07 Thread Kumar Srinivasan
Hi Kirk, We don't allow any shell tests. There are existing shell based tests, I have not had a chance to port all of them. Your test must be rewritten to use the TestHelper framework, please see the other tests in jdk/test/tools/launcher for patterns. Kumar -Original Message- From:

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-08-05 Thread Kirk Shoop
-Original Message- From: Xueming Shen [mailto:xueming.s...@oracle.com] Sent: Monday, July 20, 2015 11:50 AM On 07/20/2015 10:22 AM, Kirk Shoop wrote: So when default system locale differs from the active one, we have different behavior on Linux and Windows. The new options allow a

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-07-20 Thread Kirk Shoop
-libs-dev Libs; Valery Kopylov (Akvelon); Martin Sawicki; SHEN,XUEMING; Henry Jen Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Kirk, I took another pass over the changes. IMHO, we need to make it easier for people to use this feature, and eliminate these two, atleast

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-07-11 Thread Xueming Shen
Hi Kirk, Two questions (1) Why do you need to change the encoding used by the java.io.Console class. My understanding is that the console encoding is specifically used to talk to the underlying terminal, it should just be the one used by the underlying terminal/console. I don't

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-07-10 Thread Ulf Zibis
Am 08.07.2015 um 18:50 schrieb Kirk Shoop: Valery prepared a new webrev which I placed here: http://cr.openjdk.java.net/~kshoop/8124977/webrev.01 May be better to avoid potetially superfluous lookup of UTF-8: public static Charset defaultUnicodeCharset() { if (defaultUnicodeCharset

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-07-08 Thread Kirk Shoop
-Original Message- From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com] Hi Kirk, Thanks for proposing this change. If you notice all the posix calls are wrapped in JLI_* this gives us the ability to use W functions. I almost got it done, several years ago, but we

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-06-23 Thread Anthony Vanelverdinghe
Hi Thanks for taking on these challenges. I would like to be able to associate file types with a Java program [1]. Currently, the Java program doesn't receive the argument (i.e. the path to the file that was double-clicked) correctly if it contains Unicode characters. I assume this would be

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-06-23 Thread Kirk Shoop (MS OPEN TECH)
From: Martin Buchholz [mailto:marti...@google.com] default unicode charset is a bizarre concept to me.  Do windows users really have a regular charset and a unicode charset?  If they do, we probably want to keep that concept out of the public non-Windows API somehow.  Also, the W API is

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-06-23 Thread Kirk Shoop (MS OPEN TECH)
-Original Message- From: Anthony Vanelverdinghe [mailto:anthony.vanelverdin...@gmail.com] Sent: Tuesday, June 23, 2015 12:12 PM I would like to be able to associate file types with a Java program [1]. Currently, the Java program doesn't receive the argument (i.e. the path to the

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-06-22 Thread Martin Buchholz
This was on my TODO list back in 2005 or so. I never got around to it, in part because of my personal and Sun's corporate Unix focus, and because waiting for Win98 to be de-supported was a great way to procrastinate. It's good for Microsoft employees (actual Windows users) to work on this - you

RFR 8124977 cmdline encoding challenges on Windows

2015-06-22 Thread Kirk Shoop (MS OPEN TECH)
Hi, Issue: https://bugs.openjdk.java.net/browse/JDK-8124977 Webrev: http://cr.openjdk.java.net/~kshoop/8124977/ This webrev intends to address interaction between Windows console and java apps. Two switches were added that change the behavior of the launcher. The defaults do not change