Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread Stuart Marks
On 10/17/16 5:16 PM, Paul Sandoz wrote: On 17 Oct 2016, at 16:36, John Rose wrote: On Oct 17, 2016, at 3:38 PM, Paul Sandoz wrote: On 17 Oct 2016, at 15:01, Stuart Marks wrote: Usually I wrinkle my nose at a throw that's caught by a catch clause later on, but in this case it's not obvious

Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread David Holmes
On 18/10/2016 10:09 AM, Paul Sandoz wrote: On 17 Oct 2016, at 15:33, David Holmes mailto:david.hol...@oracle.com>> wrote: Hi Paul, Looking at hotspot changes only ... On 15/10/2016 8:08 AM, Paul Sandoz wrote: Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8166974-indy-e

Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread Paul Sandoz
> On 17 Oct 2016, at 16:36, John Rose wrote: > > On Oct 17, 2016, at 3:38 PM, Paul Sandoz wrote: >> >> >>> On 17 Oct 2016, at 15:01, Stuart Marks wrote: >>> >>> Hi Paul, >>> >>> I took a look at the jdk changes. They look good to me. >>> >>> One section of code gave me pause, which is the

Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread Paul Sandoz
> On 17 Oct 2016, at 15:33, David Holmes wrote: > > Hi Paul, > > Looking at hotspot changes only ... > > On 15/10/2016 8:08 AM, Paul Sandoz wrote: >> Hi, >> >> Please review: >> >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8166974-indy-errors-not-wrapped-jdk/webrev/ >> >> http://cr

Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread John Rose
On Oct 17, 2016, at 3:38 PM, Paul Sandoz wrote: > > >> On 17 Oct 2016, at 15:01, Stuart Marks wrote: >> >> Hi Paul, >> >> I took a look at the jdk changes. They look good to me. >> >> One section of code gave me pause, which is the throw of ClassCastException >> at 339 of CallSite.java, and

Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread Paul Sandoz
> On 17 Oct 2016, at 15:01, Stuart Marks wrote: > > Hi Paul, > > I took a look at the jdk changes. They look good to me. > > One section of code gave me pause, which is the throw of ClassCastException > at 339 of CallSite.java, and the throw of the exception returned from > wrongTargetType()

Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread David Holmes
Hi Paul, Looking at hotspot changes only ... On 15/10/2016 8:08 AM, Paul Sandoz wrote: Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8166974-indy-errors-not-wrapped-jdk/webrev/ http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8166974-indy-errors-not-wrapped-hotspot/webrev/

Re: RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-17 Thread Stuart Marks
Hi Paul, I took a look at the jdk changes. They look good to me. One section of code gave me pause, which is the throw of ClassCastException at 339 of CallSite.java, and the throw of the exception returned from wrongTargetType() at 344 of CallSite.java. This appears odd given the "rethrow any

RFR 8166974: invokedynamic implementation should not wrap Errors

2016-10-14 Thread Paul Sandoz
Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8166974-indy-errors-not-wrapped-jdk/webrev/ http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8166974-indy-errors-not-wrapped-hotspot/webrev/ The JMV spec was recently updated to state the following in the Linkage Exceptions secti