+1
Naoto
On 1/22/19 3:25 PM, Mandy Chung wrote:
On 1/22/19 2:25 PM, Roger Riggs wrote:
Hi Mandy,
Updated webrev:
http://cr.openjdk.java.net/~rriggs/webrev-circ-error-8217339-2/
Looks good.
Other changes look good.
BTW,
> I have not found a reproducer for jdk 12, it only occurs on
On 1/22/19 2:25 PM, Roger Riggs wrote:
Hi Mandy,
Updated webrev:
http://cr.openjdk.java.net/~rriggs/webrev-circ-error-8217339-2/
Looks good.
Other changes look good.
BTW,
> I have not found a reproducer for jdk 12, it only occurs on new
work for
> jdk 13.
Is this new code in
Hi Mandy,
Updated webrev:
http://cr.openjdk.java.net/~rriggs/webrev-circ-error-8217339-2/
On 1/22/19 3:47 PM, Mandy Chung wrote:
On 1/22/19 12:29 PM, Naoto Sato wrote:
Hi Roger,
I'd use Locale.ROOT instead of Locale.ENGLISH in String.format(),
which is the language invariant locale.
On 1/22/19 12:29 PM, Naoto Sato wrote:
Hi Roger,
I'd use Locale.ROOT instead of Locale.ENGLISH in String.format(),
which is the language invariant locale.
Alternatively, convert those String.format to string concatenation and they
are pretty simple format only one argument.
Other
Hi Roger,
I'd use Locale.ROOT instead of Locale.ENGLISH in String.format(), which
is the language invariant locale.
Other changes look good.
BTW,
> I have not found a reproducer for jdk 12, it only occurs on new work for
> jdk 13.
Is this new code in 13? l10n causes this type of
A ClassCircularityError can occur via the ClassDescriptor code that uses
String.format to
concatenate strings.
Please review a change to use string concatenation or a known locale
instead
of the default locale in calls to String.format.
The java.lang.constant APIs can be used early in the
