Hi Daniel,
> On Aug 26, 2020, at 10:25 PM, Daniel Fuchs wrote:
>
> Hi Vipin,
>
> This looks good to me.
> Make sure to generate the API docs locally and eyeball them to
> double check that nothing is amiss.
Checked API docs, it doesn’t have any change.
Regards,
Vipin
Hi Vipin,
I'm happy to sponsor this and any related changes.
Let me know if you need help with anything.
Best,
Julia
On 26/08/2020 17:55, Daniel Fuchs wrote:
Hi Vipin,
This looks good to me.
Make sure to generate the API docs locally and eyeball them to
double check that nothing is amiss.
Hi Lance,
On 26/08/2020 17:55, Lance Andersen wrote:
I did find it strange that FileHandler had a few methods which listed
IllegalArgumentException multiple times (vs. including the possible scenarios
for the exception as part of 1 @throws) as I have not noticed that elsewhere in
the JDK but
Hi Vipin,
This looks good to me.
Make sure to generate the API docs locally and eyeball them to
double check that nothing is amiss.
best regards,
-- daniel
On 26/08/2020 17:38, Vipin Sharma wrote:
Hi,
Please review and sponsor the fix for replacing @exception with @throws in
java.util.loggin
This looks ok overall.
Not specific to your change but …
I did find it strange that FileHandler had a few methods which listed
IllegalArgumentException multiple times (vs. including the possible scenarios
for the exception as part of 1 @throws) as I have not noticed that elsewhere in
the JDK b
Hi,
Please review and sponsor the fix for replacing @exception with @throws in
java.util.logging package.
Issue: https://bugs.openjdk.java.net/browse/JDK-8252265
Webrev: https://cr.openjdk.java.net/~vsharma/8252265/
It came up in the below discussion, starting this cleanup with
java.util.logging
