Re: RFR JDK-8048175: Remove redundant use of reflection on core classes from JNDI

2014-07-15 Thread Mark Sheppard
Hi Pavel, the changes look ok I've run some relevant jck tests (naming management rmi) and the CORBA regression suite for the changeset, with no perceptible issues regards Mark On 14/07/2014 12:43, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8048175?

Re: RFR JDK-8048175: Remove redundant use of reflection on core classes from JNDI

2014-07-15 Thread Vincent Ryan
The LDAP changes look fine to me. Thanks. On 15 Jul 2014, at 15:07, Mark Sheppard mark.shepp...@oracle.com wrote: Hi Pavel, the changes look ok I've run some relevant jck tests (naming management rmi) and the CORBA regression suite for the changeset, with no perceptible issues

Re: RFR JDK-8048175: Remove redundant use of reflection on core classes from JNDI

2014-07-15 Thread Pavel Rappo
Thanks! -Pavel On 15 Jul 2014, at 15:41, Vincent Ryan vincent.x.r...@oracle.com wrote: The LDAP changes look fine to me. Thanks. On 15 Jul 2014, at 15:07, Mark Sheppard mark.shepp...@oracle.com wrote: Hi Pavel, the changes look ok I've run some relevant jck tests (naming

RFR JDK-8048175: Remove redundant use of reflection on core classes from JNDI

2014-07-14 Thread Pavel Rappo
Hi everyone, Could you please review my change for JDK-8048175? http://cr.openjdk.java.net/~prappo/8048175/webrev.00/ Summary 1. com.sun.jndi.ldap.Connection imports both java.net.InetSocketAddress and javax.net.SocketFactory which are available since 1.4 2.