Looks good.
Thanks, Roger
On 1/22/19 3:31 PM, Naoto Sato wrote:
Hi Roger,
Thanks. Modified as suggested:
http://cr.openjdk.java.net/~naoto/8216969/webrev.02/
Naoto
On 1/19/19 10:03 AM, Roger Riggs wrote:
Hi Naoto,
SimpleDateFormat: 2454, perhaps add javadoc about what it is doing
and
Hi Roger,
Thanks. Modified as suggested:
http://cr.openjdk.java.net/~naoto/8216969/webrev.02/
Naoto
On 1/19/19 10:03 AM, Roger Riggs wrote:
Hi Naoto,
SimpleDateFormat: 2454, perhaps add javadoc about what it is doing and why.
Use only the official style fields and avoid using the 0x8000
Hi Naoto,
SimpleDateFormat: 2454, perhaps add javadoc about what it is doing and why.
Use only the official style fields and avoid using the 0x8000 that is
supposed to be internal to Calendar.
2457: (forceStandaloneForm ? Calendar.SHORT_STANDALONE ? SHORT_FORMAT)
2460: (forceStandaloneForm
Gentle reminder. Still waiting for reviews from OpenJDK Reviewers.
Naoto
On 1/18/19 1:57 AM, Nishit Jain wrote:
Looks Good.
Regards,
Nishit Jain
On 17-01-2019 22:07, Naoto Sato wrote:
Hi Nishit,
Thanks. Updated:
http://cr.openjdk.java.net/~naoto/8216969/webrev.01/
Naoto
On 1/17/19 2:57
Looks Good.
Regards,
Nishit Jain
On 17-01-2019 22:07, Naoto Sato wrote:
Hi Nishit,
Thanks. Updated:
http://cr.openjdk.java.net/~naoto/8216969/webrev.01/
Naoto
On 1/17/19 2:57 AM, Nishit Jain wrote:
Hi Naoto,
Looks good to me. Just a small suggestion.
- To improve readability, can we
Hi Nishit,
Thanks. Updated:
http://cr.openjdk.java.net/~naoto/8216969/webrev.01/
Naoto
On 1/17/19 2:57 AM, Nishit Jain wrote:
Hi Naoto,
Looks good to me. Just a small suggestion.
- To improve readability, can we declare "standalone mask" (0x8000) as a
static field and use that at all the
Hi Naoto,
Looks good to me. Just a small suggestion.
- To improve readability, can we declare "standalone mask" (0x8000) as a
static field and use that at all the places?
Regards,
Nishit Jain
On 17-01-2019 05:50, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the following
