Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Roger, Lance, Daniel, Thanks for your reviews. With Best Regards, Aleksei On 26/08/2020 16:59, Lance Andersen wrote: +1 On Aug 26, 2020, at 7:46 AM, Aleks Efimov > wrote: Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New webrev with sugges

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

+1 > On Aug 26, 2020, at 7:46 AM, Aleks Efimov wrote: > > Hi Roger, Lance, Daniel, > > Thanks for your reviews and comments! > New webrev with suggested modifications can be viewed at this location: > http://cr.openjdk.java.net/~aefimov/8251182/01 > > The list of modifications: > - Added @java

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Looks good,  Thanks for the updates. Roger On 8/26/20 8:17 AM, Daniel Fuchs wrote: Hi Aleksei, Thanks for taking this on. The new version looks good to me. best regards, -- daniel On 26/08/2020 12:46, Aleks Efimov wrote: Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New w

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Aleksei, Thanks for taking this on. The new version looks good to me. best regards, -- daniel On 26/08/2020 12:46, Aleks Efimov wrote: Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New webrev with suggested modifications can be viewed at this location: http://cr.openjdk.j

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New webrev with suggested modifications can be viewed at this location: http://cr.openjdk.java.net/~aefimov/8251182/01 The list of modifications: - Added @java.io.Serial annotation to 'serialVersionUID' declarations - Removed trailin

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Aleksei, LGTM. You could also add the @Seial annotation to serialVersionUID declarations. best regards, -- daniel On 25/08/2020 16:03, Aleks Efimov wrote: Hi, The documentation of classes from "java.naming" module needs to be improved to resolve javadoc -Xdoclint "no comment" warnings.

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Aleksei, CompositeName.java readObject and writeObject methods should have a generic first line comment. CompositeName.java BasicAttribute.java BasicAttributes.java For example, * The WriteObject method is called to save the state of the FilePermission to a stream. * The readObject me

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Aleksei The changes look good > On Aug 25, 2020, at 11:03 AM, Aleks Efimov wrote: > > Hi, > > The documentation of classes from "java.naming" module needs to be improved > to resolve javadoc -Xdoclint "no comment" warnings. > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8251182