Hi Mandy,
Seems okay.
I presume when you say the anchor is unsigned, you mean it represents an
external unsigned value? So -1 is the only sentinel value being used?
Thanks,
David
On 25/11/2015 8:37 AM, Mandy Chung wrote:
On Nov 24, 2015, at 2:20 PM, Daniel D. Daugherty
wrote:
You use b
> On Nov 24, 2015, at 6:28 PM, David Holmes wrote:
>
> Hi Mandy,
>
> Seems okay.
>
> I presume when you say the anchor is unsigned, you mean it represents an
> external unsigned value? So -1 is the only sentinel value being used?
Anchor is an internal unsigned value. It’s a native address (
Looks good.
Thanks,
Serguei
On 11/24/15 14:37, Mandy Chung wrote:
On Nov 24, 2015, at 2:20 PM, Daniel D. Daugherty
wrote:
You use both 'this.anchor' and 'anchor'. Seems inconsistent.
Oh yeah. I took out “this.” from it.
diff --git a/src/java.base/share/classes/java/lang/StackStreamFacto
FWIW. The entire webrev with this patch:
http://cr.openjdk.java.net/~mchung/jdk9/jep259/webrev.05/
Mandy
> On Nov 24, 2015, at 12:54 PM, Mandy Chung wrote:
>
> The failed tests now passed with fast debug and product build (manually
> verified on solaris x64 and sparcv9 machines). JPRT job
The failed tests now passed with fast debug and product build (manually
verified on solaris x64 and sparcv9 machines). JPRT job to run all core tests
with fast debug and product build is in progress.
Mandy
> On Nov 24, 2015, at 12:52 PM, Mandy Chung wrote:
>
> The value of anchor is an addre
> On Nov 24, 2015, at 2:20 PM, Daniel D. Daugherty
> wrote:
>
> You use both 'this.anchor' and 'anchor'. Seems inconsistent.
Oh yeah. I took out “this.” from it.
diff --git a/src/java.base/share/classes/java/lang/StackStreamFactory.java
b/src/java.base/share/classes/java/lang/StackStreamFa
On 11/24/15 1:52 PM, Mandy Chung wrote:
The value of anchor is an address and it’s an unsigned value. The check should
be fixed to handle unsigned value.
diff --git a/src/java.base/share/classes/java/lang/StackStreamFactory.java
b/src/java.base/share/classes/java/lang/StackStreamFactory.java
