Re: Creating a charset provider module for IBM charsets

2018-06-22 Thread Alan Bateman
On 21/06/2018 11:41, Dave Hobbs wrote: Yes, the proposal is to create a new module outside the JDK. : A service provider module appears to be the recommended approach according the Java api documentation. However writing charset classes is made a lot more difficult by not having the sun.nio.cs

Re: Creating a charset provider module for IBM charsets

2018-06-21 Thread Dave Hobbs
Dave Hobbs , core-libs-dev@openjdk.java.net Date: 20/06/2018 18:27 Subject: Re: Creating a charset provider module for IBM charsets On 20/06/2018 15:52, Dave Hobbs wrote: > Hi Alan, > > My understanding is that java.base only exports sun.nio.cs to jdk.charsets > i.e jav

Re: Creating a charset provider module for IBM charsets

2018-06-20 Thread Alan Bateman
On 20/06/2018 15:52, Dave Hobbs wrote: Hi Alan, My understanding is that java.base only exports sun.nio.cs to jdk.charsets i.e java.base module-info.java has: ... exports sun.nio.cs to java.desktop, jdk.charsets; ... and jdk.charsets has: module jdk.charsets { provides

Re: Creating a charset provider module for IBM charsets

2018-06-20 Thread Dave Hobbs
sun.nio.cs.ext.ExtendedCharsets; } So jdk.charsets can use sun.nio.cs, whereas my module can not. Am I missing something? Dave From: Alan Bateman To: Dave Hobbs , core-libs-dev@openjdk.java.net Date: 20/06/2018 14:26 Subject:Re: Creating a charset provider module for

Re: Creating a charset provider module for IBM charsets

2018-06-20 Thread Alan Bateman
On 20/06/2018 14:22, Dave Hobbs wrote: Hi We would like to migrate a number of the IBM charsets (which don't need to be in java.base) to a modular charset provider. However, as written today our charset classes rely on sun.nio.cs classes and definitions, which are no longer visible. For example