Re: Garbage Free Check

2021-04-14 Thread Dalibor Topic
Hi Ralph, I've added an apache-log4j-interest label to the issue. cheers, dalibor topic On 14.04.2021 19:00, Ralph Goers wrote: I don’t have an account in the bug tracking system. Could someone possibly update the issue noted below to indicate that Apache Log4j 2 would also like that enhance

Re: Garbage Free Check

2021-04-14 Thread Ralph Goers
I don’t have an account in the bug tracking system. Could someone possibly update the issue noted below to indicate that Apache Log4j 2 would also like that enhancement? Thanks, Ralph > On Apr 5, 2021, at 1:26 PM, Roger Riggs wrote: > > Hi, > > Java does not have a data type with enough res

Re: Garbage Free Check

2021-04-08 Thread Ralph Goers
Well, after digging deeper it seems it didn’t really pass on Java 16. The allocation instrumenter was unable to instrument anything so it didn’t generate the errors the test looks for. I tried with Java 12-14 and those all failed. In Java 15 the JVM crashed. Ralph > On Apr 7, 2021, at 11:33 PM

Re: Garbage Free Check

2021-04-07 Thread Ralph Goers
Interesting. I ran the test with openjdk version "16" 2021-03-16 OpenJDK Runtime Environment (build 16+36-2231) OpenJDK 64-Bit Server VM (build 16+36-2231, mixed mode, sharing) and it passed. I then ran it with openjdk version "11.0.2" 2019-01-15 OpenJDK Runtime Environment 18.9 (build 11.0.2+9

Re: Garbage Free Check

2021-04-06 Thread Ralph Goers
I am using openjdk version "11.0.10" 2021-01-19 LTS OpenJDK Runtime Environment Corretto-11.0.10.9.1 (build 11.0.10+9-LTS) OpenJDK 64-Bit Server VM Corretto-11.0.10.9.1 (build 11.0.10+9-LTS, mixed mode) Our test uses com.google.code.java-allocation-instrumenter java-allocation-instrumenter

Re: Garbage Free Check

2021-04-06 Thread Peter Levart
Hi Ralph, Which version of JDK did you try running the code. I tried the following benchmark: @BenchmarkMode(Mode.AverageTime) @Fork(value = 1) @Warmup(iterations = 5, time = 1) @Measurement(iterations = 10, time = 1) @OutputTimeUnit(TimeUnit.NANOSECONDS) @State(Scope.Benchmark) public class

Re: Garbage Free Check

2021-04-05 Thread Ralph Goers
Yes, I am aware that the Instant is constructed from the two values. That is exactly why I was hoping I could pass in an object where the values of those two fields could be injected. This would still allow Instant to be immutable but allow Log4j to update one of the pre-existing Clock instances

Re: Garbage Free Check

2021-04-05 Thread Roger Riggs
Hi, Java does not have a data type with enough resolution to hold a full nanosecond value. Hence the implementation of Instant holding seconds and nanos. There is an long dormant enhancement request to return micro-seconds as a long. 8196003

Re: Garbage Free Check

2021-04-05 Thread Brian Goetz
Project Valhalla will allow Instant to be migrated to a primitive class, which would address your problem. On 4/2/2021 7:47 PM, Ralph Goers wrote: Log4j 2 supports the notion of a PreciseClock - one that can be initialized to something more precise than a millisecond. At the same time it also