Re: JDK 9 RFR of 8148023: File.createTempFile is not adhering to the contract regarding file name lengths

Hi Roger, I updated the .01 version of the webrev in place. I’ll go ahead and push that. Thanks, Brian On Dec 19, 2016, at 1:24 PM, Roger Riggs wrote: > Looks good > > Except for a typo in WinNTFileSystem_md.c:24 "compnent"

Re: JDK 9 RFR of 8148023: File.createTempFile is not adhering to the contract regarding file name lengths

Hi Brian, Looks good Except for a typo in WinNTFileSystem_md.c:24 "compnent" Regards, Roger On 12/19/2016 3:54 PM, Brian Burkhalter wrote: Hi Roger, Thanks for your suggestions. An updated version of the patch is here: http://cr.openjdk.java.net/~bpb/8148023/webrev.01/

Re: JDK 9 RFR of 8148023: File.createTempFile is not adhering to the contract regarding file name lengths

Hi Roger, Thanks for your suggestions. An updated version of the patch is here: http://cr.openjdk.java.net/~bpb/8148023/webrev.01/ On Dec 19, 2016, at 11:04 AM, Roger Riggs wrote: > File.java: > > - 1906: shortenSubName might reasonably return the new length without >

Re: JDK 9 RFR of 8148023: File.createTempFile is not adhering to the contract regarding file name lengths

Hi Brian, File.java: - 1906: shortenSubName might reasonably return the new length without creating the intermediate string and save on the allocation. - generateFile() line 1922 + -- I assume this slow path is infrequently used. Otherwise, the computations involving excess could be