Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-10 Thread Alan Bateman
On 09/11/2011 12:41, Lance Andersen - Oracle wrote: I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Thanks Lance. I quickly scanned the changes in the Core and SQL webrevs and they looks fine to me. Joe might want to look at the

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-10 Thread Joe Darcy
Hello, On 11/10/2011 1:29 AM, Alan Bateman wrote: On 09/11/2011 12:41, Lance Andersen - Oracle wrote: I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Thanks Lance. I quickly scanned the changes in the Core and SQL webrevs and

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-10 Thread Martin Desruisseaux
Le 10/11/11 16:24, Joe Darcy a écrit : The Float and Double changes look fine. I don't know why the constructors were coded up that way; Maybe because the Float(String) / Double(String) constructors were coded in Java 1.0, while the parseFloat(String) / parseDouble(String) methods were added

Fwd: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Alan Bateman
: javadoc typos, javac warnings, etc. Date: Wed, 09 Nov 2011 11:46:48 +0100 From: Martin Desruisseaux martin.desruisse...@geomatys.fr Organization: Geomatys CC: jdk8-...@openjdk.java.net Hello all It took me a while, but I finally posted the patches that I submitted last month as webrev

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Lance Andersen - Oracle
as one change-set, leaving the client area changes for review on the 2d or other list. -Alan. Original Message Subject: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc. Date: Wed, 09 Nov 2011 11:46:48 +0100 From: Martin

Re: Fwd: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Phil Race
be trivial to review and push as one change-set, leaving the client area changes for review on the 2d or other list. -Alan. Original Message Subject: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc. Date: Wed, 09 Nov 2011 11:46:48 +0100 From: Martin

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Martin Desruisseaux
Hello Phil Le 09/11/11 18:37, Phil Race a écrit : Please do register on 2d-dev and propose the 2D changes there. Registration done, I will post in a few minutes. The hashcode change definitely needs discussion, I think there may be views on the NaN comparison as my understanding is that