Re: Patch to improve primitives Array.sort()

2015-06-05 Thread Paul Sandoz
On May 26, 2015, at 11:54 AM, Paul Sandoz wrote: > Here is an updated webrev: > > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8080945-nearly-sorted-primitives/webrev/ > Updated with some contributed JMH benchmarks located in the test area. To be moved when there is a better location (i

RE: Patch to improve primitives Array.sort()

2015-05-26 Thread O'Leary, Kristen
From: Paul Sandoz [mailto:paul.san...@oracle.com] Sent: Friday, May 22, 2015 4:02 AM To: Rezaei, Mohammad A. [Tech] Cc: 'core-libs-dev@openjdk.java.net Libs'; Chan, Sunny [Tech]; O'Leary, Kristen [Tech] Subject: Re: Patch to improve primitives Array.sort() On May 22, 2015, at 1:52 AM,

Re: Patch to improve primitives Array.sort()

2015-05-26 Thread Paul Sandoz
Here is an updated webrev: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8080945-nearly-sorted-primitives/webrev/ I took the liberty of: - in DualPivotQuicksort sprinkling some more comments; and - moving and renaming the test. Code was also reformatted to better fit the JDK style. I reduce

Re: Patch to improve primitives Array.sort()

2015-05-26 Thread Paul Sandoz
On May 22, 2015, at 9:56 PM, "O'Leary, Kristen" wrote: > Hi Paul, > > We've created an additional test based on your suggestion: an array of size > 10,000,000, 32 pair flips, a run of zeroes in the middle, and 32 pair flips > at the end. Here are the results for int: > Benchmark

Re: Patch to improve primitives Array.sort()

2015-05-26 Thread Paul Sandoz
On May 26, 2015, at 4:19 AM, "Chan, Sunny" wrote: > I have looked at the mailing list archive and so far I haven’t identify any > progress on the “space for benchmark” – so we could include the performance > test as a part of the patch but it will required JMH access somehow. I think that's

RE: Patch to improve primitives Array.sort()

2015-05-25 Thread Chan, Sunny
May 2015 22:24 To: Rezaei, Mohammad A. [Tech] Cc: 'core-libs-dev@openjdk.java.net Libs'; Chan, Sunny [Tech]; O'Leary, Kristen [Tech] Subject: Re: Patch to improve primitives Array.sort() On May 22, 2015, at 3:55 PM, "Rezaei, Mohammad A." mailto:mohammad.rez...@gs.com>

Re: Patch to improve primitives Array.sort()

2015-05-22 Thread Paul Sandoz
On May 22, 2015, at 3:55 PM, "Rezaei, Mohammad A." wrote: > We have a set of JMH tests. Great. I created a bug for this issue: https://bugs.openjdk.java.net/browse/JDK-8080945 > We'll work with Sunny to make those part of the webrev (where do they go?) > and the specific test you suggeste

RE: Patch to improve primitives Array.sort()

2015-05-22 Thread Rezaei, Mohammad A.
ezaei, Mohammad A. [Tech] >Cc: 'core-libs-dev@openjdk.java.net Libs'; Chan, Sunny [Tech]; O'Leary, >Kristen [Tech] >Subject: Re: Patch to improve primitives Array.sort() > >On May 22, 2015, at 1:52 AM, "Rezaei, Mohammad A." >wrote: >> Thanks Paul. Yo

Re: Patch to improve primitives Array.sort()

2015-05-22 Thread Paul Sandoz
On May 22, 2015, at 1:52 AM, "Rezaei, Mohammad A." wrote: > Thanks Paul. Your proposed changes make sense to us and they have no > discernable impact on the performance. > Great, thanks. I am happy to update the current webrev (and also create an associated issue). Sorry to drag this out a

RE: Patch to improve primitives Array.sort()

2015-05-21 Thread Rezaei, Mohammad A.
Cc: Chan, Sunny [Tech]; O'Leary, Kristen [Tech]; Rezaei, Mohammad A. [Tech] >Subject: Re: Patch to improve primitives Array.sort() > >Hi, > >I finally got some time to better understand the patch and more generally this >area of code. > >I applied the patch and ran the

Re: Patch to improve primitives Array.sort()

2015-05-21 Thread Paul Sandoz
mailto:paul.san...@oracle.com] > Sent: 16 May 2015 00:13 > To: Chan, Sunny [Tech] > Cc: O'Leary, Kristen [Tech]; 'Alan Bateman'; > 'core-libs-dev@openjdk.java.net'; Rezaei, Mohammad A. [Tech] > Subject: Re: Patch to improve primitives Array.s

RE: Patch to improve primitives Array.sort()

2015-05-19 Thread Chan, Sunny
2015 00:13 To: Chan, Sunny [Tech] Cc: O'Leary, Kristen [Tech]; 'Alan Bateman'; 'core-libs-dev@openjdk.java.net'; Rezaei, Mohammad A. [Tech] Subject: Re: Patch to improve primitives Array.sort() On May 15, 2015, at 11:48 AM, "Chan, Sunny" mailto:sunny.c...@gs.

Re: Patch to improve primitives Array.sort()

2015-05-15 Thread Paul Sandoz
On May 15, 2015, at 11:48 AM, "Chan, Sunny" wrote: > I have provided Paul with an updated patch: > Here it is: http://cr.openjdk.java.net/~psandoz/tmp/gs/sort/webrev.1/ In DualPivotQuicksort 63 /** 64 * The maximum length of run in merge sort. 65 */ 66 private stat

RE: Patch to improve primitives Array.sort()

2015-05-15 Thread Chan, Sunny
en [Tech] Sent: 11 May 2015 23:33 To: 'Alan Bateman'; Paul Sandoz; Chan, Sunny [Tech] Cc: 'core-libs-dev@openjdk.java.net'; Rezaei, Mohammad A. [Tech] Subject: RE: Patch to improve primitives Array.sort() Hi Alan, For MAX_RUN_LENGTH, the constant was used to limit the size of

RE: Patch to improve primitives Array.sort()

2015-05-11 Thread O'Leary, Kristen
revision sent out. Thanks! Kristen -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Friday, April 24, 2015 5:09 AM To: Paul Sandoz; Chan, Sunny [Tech] Cc: 'core-libs-dev@openjdk.java.net'; O'Leary, Kristen [Tech] Subject: Re: Patch to improve primit

RE: Patch to improve primitives Array.sort()

2015-05-04 Thread Chan, Sunny
http://permalink.gmane.org/gmane.comp.java.openjdk.core-libs.devel/2628) Sunny -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: 24 April 2015 17:09 To: Paul Sandoz; Chan, Sunny [Tech] Cc: 'core-libs-dev@openjdk.java.net'; O'Leary, Kristen [Tech] S

Re: Patch to improve primitives Array.sort()

2015-04-24 Thread Alan Bateman
On 24/04/2015 09:57, Paul Sandoz wrote: See here: http://cr.openjdk.java.net/~psandoz/tmp/gs/sort/webrev/ Some very quick comments as i have not yet had time to review more closely: - IANAL so i dunno about the GS copyright in the files. - The constant MAX_RUN_LENGTH is no longer used so c

Re: Patch to improve primitives Array.sort()

2015-04-24 Thread Paul Sandoz
See here: http://cr.openjdk.java.net/~psandoz/tmp/gs/sort/webrev/ Some very quick comments as i have not yet had time to review more closely: - IANAL so i dunno about the GS copyright in the files. - The constant MAX_RUN_LENGTH is no longer used so could be removed. But i would like to under

RE: Patch to improve primitives Array.sort()

2015-04-24 Thread Chan, Sunny
a.net'; O'Leary, Kristen [Tech] Subject: Re: Patch to improve primitives Array.sort() HI Chan, Attachments might be getting removed by the OpenJDK email server. If you send me the webrev privately i can upload to cr. If so could you do that please send the JMH tests as i think peopl

Re: Patch to improve primitives Array.sort()

2015-04-24 Thread Paul Sandoz
HI Chan, Attachments might be getting removed by the OpenJDK email server. If you send me the webrev privately i can upload to cr. If so could you do that please send the JMH tests as i think people might also be interested in those. Paul. On Apr 24, 2015, at 9:17 AM, "Chan, Sunny" wrote: >

RE: Patch to improve primitives Array.sort()

2015-04-24 Thread Chan, Sunny
Sorry the spam filter we use didn't like the webrev.zip so I have attached the text patch file instead. From: Chan, Sunny [Tech] Sent: 24 April 2015 15:17 To: 'core-libs-dev@openjdk.java.net' Cc: O'Leary, Kristen [Tech] Subject: Patch to improve primitives Array.sort() We are proposing a patch