Re: RFR: 8170832: Add a new launcher environment variable JAVA_OPTIONS

2017-01-25 Thread Henry Jen
> On Jan 25, 2017, at 11:32 AM, Kumar Srinivasan > wrote: > > > Hi Henry, > > I was somewhat surprised to see changes to launcher_LANG.properties, I usually > make the change in the english/default locale and allow the L1ON team to make > the > locale specific changes, but if you are confide

Re: RFR: 8170832: Add a new launcher environment variable JAVA_OPTIONS

2017-01-25 Thread Kumar Srinivasan
Hi Henry, I was somewhat surprised to see changes to launcher_LANG.properties, I usually make the change in the english/default locale and allow the L1ON team to make the locale specific changes, but if you are confident of the changes, that is fine. src/java.base/share/native/libjli/args.c

Re: RFR: 8170832: Add a new launcher environment variable JAVA_OPTIONS

2017-01-25 Thread Henry Jen
> On Jan 24, 2017, at 12:41 PM, Mandy Chung wrote: > > >> On Jan 24, 2017, at 10:20 AM, Henry Jen wrote: >> >> Hi, >> >> Please review the webrev[1] that add support for JAVA_OPTIONS environment >> variable. The bug[2] describes how JAVA_OPTIONS works. >> >> [1] http://cr.openjdk.java.net/

Re: RFR: 8170832: Add a new launcher environment variable JAVA_OPTIONS

2017-01-24 Thread Mandy Chung
> On Jan 24, 2017, at 10:20 AM, Henry Jen wrote: > > Hi, > > Please review the webrev[1] that add support for JAVA_OPTIONS environment > variable. The bug[2] describes how JAVA_OPTIONS works. > > [1] http://cr.openjdk.java.net/~henryjen/jdk9/8170832/4/webrev/ This looks quite good. A couple