Re: RFR: 8199453: Enable link-time generation of constructor forms

2018-03-12 Thread Claes Redestad
Paul, Mandy, thanks for reviewing! Pushed. /Claes On 2018-03-12 18:03, mandy chung wrote: On 3/12/18 5:37 AM, Claes Redestad wrote: Hi, I found what appears to be a simple omission from my earlier work to pre-generate LambdaForms at jlink time, in that the DIRECT_NEW_INVOKE_SPECIAL kind

Re: RFR: 8199453: Enable link-time generation of constructor forms

2018-03-12 Thread mandy chung
On 3/12/18 5:37 AM, Claes Redestad wrote: Hi, I found what appears to be a simple omission from my earlier work to pre-generate LambdaForms at jlink time, in that the DIRECT_NEW_INVOKE_SPECIAL kind is never looked up nor pregenerated. Fixing that means we're covering a few more kinds of LF

Re: RFR: 8199453: Enable link-time generation of constructor forms

2018-03-12 Thread Paul Sandoz
+1 Paul. > On Mar 12, 2018, at 5:37 AM, Claes Redestad wrote: > > Hi, > > I found what appears to be a simple omission from my earlier work to > pre-generate > LambdaForms at jlink time, in that the DIRECT_NEW_INVOKE_SPECIAL kind is > never looked > up nor pregenerated. > > Fixing that mean

Re: RFR: 8199453: Enable link-time generation of constructor forms

2018-03-12 Thread Claes Redestad
On 2018-03-12 16:03, Alan Bateman wrote: Webrev: http://cr.openjdk.java.net/~redestad/8199453/jdk.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8199453 This looks okay to me. Thanks, Alan! In case anyone wonders, this is one of several jlink plugins that are tightly coupled to java.

Re: RFR: 8199453: Enable link-time generation of constructor forms

2018-03-12 Thread Alan Bateman
On 12/03/2018 12:37, Claes Redestad wrote: Hi, I found what appears to be a simple omission from my earlier work to pre-generate LambdaForms at jlink time, in that the DIRECT_NEW_INVOKE_SPECIAL kind is never looked up nor pregenerated. Fixing that means we're covering a few more kinds of L