Re: RFR: 8286669: Replace MethodHandle specialization with ASM in mainline [v2]

2022-05-18 Thread Jorn Vernee
On Tue, 17 May 2022 10:19:04 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequence.java >> line 109: >> >>> 107: * @return the caller method type. >>> 108: */ >>> 109: public MethodType callerMethodType() { >> >> Would it make sense to ei

Re: RFR: 8286669: Replace MethodHandle specialization with ASM in mainline [v2]

2022-05-17 Thread Jorn Vernee
On Mon, 16 May 2022 12:58:51 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use unaligned layout constants when filling in reconstituted structs (was >> accidentally dropped change) > > s

Re: RFR: 8286669: Replace MethodHandle specialization with ASM in mainline [v2]

2022-05-17 Thread Maurizio Cimadamore
On Fri, 13 May 2022 13:23:41 GMT, Jorn Vernee wrote: >> Hi, >> >> This PR brings over commits from the panama-foreign repo. These commits >> mostly pertain to the switch to ASM and away from MethodHandle combinators >> for the binding recipe specialization. But, there is one more commit which

Re: RFR: 8286669: Replace MethodHandle specialization with ASM in mainline [v2]

2022-05-13 Thread Jorn Vernee
On Fri, 13 May 2022 13:23:41 GMT, Jorn Vernee wrote: >> Hi, >> >> This PR brings over commits from the panama-foreign repo. These commits >> mostly pertain to the switch to ASM and away from MethodHandle combinators >> for the binding recipe specialization. But, there is one more commit which

Re: RFR: 8286669: Replace MethodHandle specialization with ASM in mainline [v2]

2022-05-13 Thread Jorn Vernee
> Hi, > > This PR brings over commits from the panama-foreign repo. These commits > mostly pertain to the switch to ASM and away from MethodHandle combinators > for the binding recipe specialization. But, there is one more commit which > adds freeing of downcall stubs, since those changes were