Re: RFR: Some patches for sherman

On 04/02/18 20:01, Martin Buchholz wrote: On Fri, Mar 30, 2018 at 6:31 PM, Martin Buchholz > wrote: Thanks, John. I need to adjust my expectations. The word "constant" means something different to hotspot engineers. I'm still hoping to someday si

Re: RFR: Some patches for sherman

On Fri, Mar 30, 2018 at 6:31 PM, Martin Buchholz wrote: > Thanks, John. > I need to adjust my expectations. The word "constant" means something > different to hotspot engineers. > > I'm still hoping to someday simply say, > "here's a final field - just go ahead and trust that it's truly final" >

Re: RFR: Some patches for sherman

Thanks, John. I need to adjust my expectations. The word "constant" means something different to hotspot engineers. I'm still hoping to someday simply say, "here's a final field - just go ahead and trust that it's truly final" On Fri, Mar 30, 2018 at 4:38 PM, John Rose wrote: > > The docs for

Re: RFR: Some patches for sherman

On Fri, Mar 30, 2018 at 5:01 PM, Paul Sandoz wrote: > If the res field is non-volatile then is C2 already capable of hoisting > the field access out of the loop as if the result was assigned to a local > variable? > > final ZipFile z = … > final z_res = z.res; > while (...) { > use(z_res); > }

Re: RFR: Some patches for sherman

(...) { >> use(z.res); >> } >> >> >> annotating instance field ZipFile.res as @Stable will enable the >> optimization of reading the res field only once. >> >> >> On Fri, Mar 30, 2018 at 1:16 AM, Peter Levart > <mailto:peter.le

Re: RFR: Some patches for sherman

ail.com>> wrote: > I'm forwarding this private message to core-libs-dev so a qualified person > may read it... > > Regards, Peter > > > Forwarded Message > Subject:Re: RFR: Some patches for sherman > Date: Fri, 30 Mar 2018 06:18:26 + &

Re: Re: RFR: Some patches for sherman

. On Fri, Mar 30, 2018 at 1:16 AM, Peter Levart wrote: > I'm forwarding this private message to core-libs-dev so a qualified person > may read it... > > Regards, Peter > > > Forwarded Message -------- > Subject: Re: RFR: Some patches for sherman > D

Fwd: Re: RFR: Some patches for sherman

I'm forwarding this private message to core-libs-dev so a qualified person may read it... Regards, Peter Forwarded Message Subject: Re: RFR: Some patches for sherman Date: Fri, 30 Mar 2018 06:18:26 + From: Peter Levart To: Martin Buchholz Hi M

Re: RFR: Some patches for sherman

On Tue, Mar 27, 2018 at 6:48 AM, Ulf Zibis wrote: > Fine enhancement > Thanks. > See also: > JDK-6862158 : Make > sun.nio.cs.* charset objects light-weight > JDK-6796087 : > Speed-up s

Re: RFR: Some patches for sherman

On Tue, Mar 27, 2018 at 9:24 AM, Xueming Shen wrote: > >> 8200124: Various cleanups in jar/zip >> http://cr.openjdk.java.net/~martin/webrevs/jdk/zip-cleanup/ < >> http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/zip-cleanup/> >> https://bugs.openjdk.java.net/browse/JDK-8200124 >> > > don't see an

Re: RFR: Some patches for sherman

looks good for me. On 3/26/18, 5:21 PM, Martin Buchholz wrote: 8200116: ConstructInflaterOutput, ConstructDeflaterInput still spamming test logs http://cr.openjdk.java.net/~martin/webrevs/jdk/ConstructInflaterOutput/

Re: RFR: Some patches for sherman

Fine enhancement! See also: JDK-6862158 : Make sun.nio.cs.* charset objects light-weight JDK-6796087 : Speed-up sun.nio.cs.StandardCharsets JDK-6790402