Re: RFR: jsr166 jdk10 integration wave 5

> On 8 Nov 2017, at 14:20, Martin Buchholz wrote: > > > > On Wed, Nov 8, 2017 at 2:09 PM, Paul Sandoz wrote: > > > 685 final Node succ(Node p) { > 686 // TODO: should we skip deleted nodes here? > > Is the comment still relevant? > > It's still an open question, like what's

Re: RFR: jsr166 jdk10 integration wave 5

On Wed, Nov 8, 2017 at 2:09 PM, Paul Sandoz wrote: > > > 685 final Node succ(Node p) { > 686 // TODO: should we skip deleted nodes here? > > Is the comment still relevant? > It's still an open question, like what's the best GC strategy, or should ArrayList automatically shrink (as

Re: RFR: jsr166 jdk10 integration wave 5

> On 6 Nov 2017, at 12:00, Martin Buchholz wrote: > > The notable thing this time around is the embarrassing number of rare races > being fixed, all of which are second tries. This time for sure! > > There's a large number of boring changes to appease errorprone, notably > http://errorprone.i

Re: RFR: jsr166 jdk10 integration wave 5

On Mon, Nov 6, 2017 at 5:33 PM, David Holmes wrote: > On 7/11/2017 8:17 AM, Martin Buchholz wrote: > >> Thanks for the review! >> >> On Mon, Nov 6, 2017 at 1:36 PM, David Holmes > > wrote: >> >> >> 8189764: Miscellaneous changes imported from jsr166 CVS 201

Re: RFR: jsr166 jdk10 integration wave 5

On 7/11/2017 8:17 AM, Martin Buchholz wrote: Thanks for the review! On Mon, Nov 6, 2017 at 1:36 PM, David Holmes > wrote: 8189764: Miscellaneous changes imported from jsr166 CVS 2017-11 All seem okay. Though I'm curious about the changes from

Re: RFR: jsr166 jdk10 integration wave 5

Thanks for the review! On Mon, Nov 6, 2017 at 1:36 PM, David Holmes wrote: > > 8189764: Miscellaneous changes imported from jsr166 CVS 2017-11 >> > > All seem okay. Though I'm curious about the changes from "catch(Throwable" > to "catch(Exception" ? > There's a half-hearted attempt to appease h

Re: RFR: jsr166 jdk10 integration wave 5

On Mon, Nov 6, 2017 at 1:36 PM, David Holmes wrote: > > src/java.base/share/classes/java/util/concurrent/ConcurrentL > inkedDeque.java > > final Node pred(Node p) { > ! Node q = p.prev; > ! return (p == q) ? last() : q; > } > > /** >* Returns the first no

Re: RFR: jsr166 jdk10 integration wave 5

Hi Martin, On 7/11/2017 6:00 AM, Martin Buchholz wrote: The notable thing this time around is the embarrassing number of rare races being fixed, all of which are second tries.  This time for sure! There's a large number of boring changes to appease errorprone, notably http://errorprone.info/bu