Finally some follow up on this!
On Feb 13 2013, at 23:43 , Martin Buchholz wrote:
I like the optimizations in this change, especially the avoidance of copies.
Was there some good reason the jdk never before used JavaLangAccess to avoid
String creation copies?
Not that I am aware of. I did
On Feb 13, 2013, at 2:45 PM, Mike Duigou mike.dui...@oracle.com wrote:
I have updated the patch with some of Ulf's feedback and corrected one
cut-and-paste error that I made.
The updated webrev is at:
http://cr.openjdk.java.net/~mduigou/JDK-8006627/2/webrev/
One last ping to make
Hi Steven;
I haven't forgotten and it's still in my queue for Java 8. I haven't had time
to respond to Martin Buchholz's feedback.
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014528.html
I suspect he is right about computing digits vs the table being a better choice
but
I have updated the patch with some of Ulf's feedback and corrected one
cut-and-paste error that I made.
The updated webrev is at:
http://cr.openjdk.java.net/~mduigou/JDK-8006627/2/webrev/
Mike
On Feb 12 2013, at 18:25 , Ulf Zibis wrote:
Am 13.02.2013 02:34, schrieb Mike Duigou:
Thank you
Am 13.02.2013 23:45, schrieb Mike Duigou:
I have updated the patch with some of Ulf's feedback and corrected one
cut-and-paste error that I made.
The updated webrev is at:
http://cr.openjdk.java.net/~mduigou/JDK-8006627/2/webrev/
Fine, but I still see the typo in j.l.System.
-Ulf
I like the optimizations in this change, especially the avoidance of
copies. Was there some good reason the jdk never before used JavaLangAccess
to avoid String creation copies?
I am tempted to micro-optimize this some more, e.g. specialize the hex
printing code. I might get rid of the digits
Hi Steven;
I have updated the patch for Java 8. There's somewhat less code sharing and a
bit of refactoring than your last version but the performance should be about
the same or a little better.
http://cr.openjdk.java.net/~mduigou/JDK-8007398/0/webrev/
I am currently running the jtreg
Thank you for the comments Ulf.
On Feb 12 2013, at 17:24 , Ulf Zibis wrote:
Am 13.02.2013 00:30, schrieb Mike Duigou:
Hi Steven;
I have updated the patch for Java 8. There's somewhat less code sharing and
a bit of refactoring than your last version but the performance should be
about
Am 13.02.2013 00:30, schrieb Mike Duigou:
Hi Steven;
I have updated the patch for Java 8. There's somewhat less code sharing and a
bit of refactoring than your last version but the performance should be about
the same or a little better.
Am 13.02.2013 02:34, schrieb Mike Duigou:
Thank you for the comments Ulf.
On Feb 12 2013, at 17:24 , Ulf Zibis wrote:
Am 13.02.2013 00:30, schrieb Mike Duigou:
Hi Steven;
I have updated the patch for Java 8. There's somewhat less code sharing and a
bit of refactoring than your last version
10 matches
Mail list logo