Re: RFR JDK-8197533 move javax.transaction.xa into its own module

On 28/02/2018 19:54, Lance Andersen wrote: : Is there any XA text from the original JTA spec that should be added to the module description as part of this? Another way to ask this is whether the JTA 1.3 drops any text dealing with the XA part. Still waiting to see what changes are made to

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

> On Mar 1, 2018, at 4:41 PM, Lance Andersen wrote: > > While running the JDK regression tests, I found a test that needed to be > updated, test/langtools/tools/jdeps/modules/DotFileTest.java, due to the > update to the java.sql module > > The updated webrev is at

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

While running the JDK regression tests, I found a test that needed to be updated, test/langtools/tools/jdeps/modules/DotFileTest.java, due to the update to the java.sql module The updated webrev is at http://cr.openjdk.java.net/~lancea/8197533/webrev.03/

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

+1 > On Mar 1, 2018, at 8:59 AM, Lance Andersen wrote: >> >> +1, i second Joe’s request to update package-info.java while we are >> opportunistically cleaning this area up. > > Per your and Joe’s request, please see > cr.openjdk.java.net/~lancea/8197533/webrev.02

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

> On Feb 28, 2018, at 8:29 PM, Paul Sandoz wrote: > > > >> On Feb 28, 2018, at 1:22 PM, Lance Andersen > > wrote: >> >>> >>> On Feb 28, 2018, at 2:20 PM, Lance Andersen >>

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

> On Feb 28, 2018, at 1:22 PM, Lance Andersen wrote: > >> >> On Feb 28, 2018, at 2:20 PM, Lance Andersen > > wrote: >> >> Hi Paul, >> >> Thank you for the review. >>> On Feb 28, 2018, at 1:40 PM, Paul

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

Hi Lance, I'd prefer if src/java.sql/share/classes/javax/transaction/xa/package.html was replaced by a package-info.java files as opposed to another package.html file in the new module. Thanks, -Joe On 2/28/2018 1:22 PM, Lance Andersen wrote: On Feb 28, 2018, at 2:20 PM, Lance Andersen

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

On 2018-02-28 19:25, Lance Andersen wrote: Hi all, This RFR request moves the javax.transaction.xa package out of the java.sql module and into its own module java.transaction.xa. One of the motivators for this change is due to the fact JSR 907 1.3 MR indicated that the javax.transaction.xa

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

> On Feb 28, 2018, at 2:20 PM, Lance Andersen wrote: > > Hi Paul, > > Thank you for the review. >> On Feb 28, 2018, at 1:40 PM, Paul Sandoz > > wrote: >> >> Compatible module refactoring in action! >> >>

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

> On Feb 28, 2018, at 2:43 PM, Alan Bateman wrote: > > On 28/02/2018 18:25, Lance Andersen wrote: >> Hi all, >> >> This RFR request moves the javax.transaction.xa package out of the java.sql >> module and into its own module java.transaction.xa. One of the motivators

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

On 28/02/2018 18:25, Lance Andersen wrote: Hi all, This RFR request moves the javax.transaction.xa package out of the java.sql module and into its own module java.transaction.xa. One of the motivators for this change is due to the fact JSR 907 1.3 MR indicated that the javax.transaction.xa

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

Hi Paul, Thank you for the review. > On Feb 28, 2018, at 1:40 PM, Paul Sandoz wrote: > > Compatible module refactoring in action! > > Looks good, one comment: > > test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java > > This is not a valid Java source file

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

Compatible module refactoring in action! Looks good, one comment: test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java This is not a valid Java source file can you merge the jtreg meta data into XAExceptionTests instead? Paul. > On Feb 28, 2018, at 10:25 AM, Lance Andersen