inspector/Utils.java Sun Apr
27
14:33:45 2014 -0300
@@ -378,7 +378,7 @@
if (userInput instanceof XObject) {
result[i] = ((XObject) userInput).getObject();
} else {
-result[i] = createObjectFromString(params[i].toString(),
+
On 2014-04-30 13:08, Remi Forax wrote:
On 04/29/2014 11:20 AM, Claes Redestad wrote:
On 2014-04-29 09:31, Remi Forax wrote:
On 04/28/2014 05:43 PM, Claes Redestad wrote:
On 04/28/2014 08:57 AM, David Holmes wrote:
On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
In my opinion not,
On 04/29/2014 11:20 AM, Claes Redestad wrote:
On 2014-04-29 09:31, Remi Forax wrote:
On 04/28/2014 05:43 PM, Claes Redestad wrote:
On 04/28/2014 08:57 AM, David Holmes wrote:
On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
In my opinion not, because Objects.requireNonNull is more re
On 04/29/2014 10:58 AM, David Holmes wrote:
> On 29/04/2014 7:40 PM, Andrew Haley wrote:
>> On 04/28/2014 07:57 AM, David Holmes wrote:
>>> On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
In my opinion not, because Objects.requireNonNull is more readable than
just string.toStrin
On 29/04/2014 7:40 PM, Andrew Haley wrote:
On 04/28/2014 07:57 AM, David Holmes wrote:
On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
In my opinion not, because Objects.requireNonNull is more readable than
just string.toString. This way is more understandable which field is
required
On 04/28/2014 07:57 AM, David Holmes wrote:
> On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
>> In my opinion not, because Objects.requireNonNull is more readable than
>> just string.toString. This way is more understandable which field is
>> required and doesn't impact on performance.
>
On 2014-04-29 09:31, Remi Forax wrote:
On 04/28/2014 05:43 PM, Claes Redestad wrote:
On 04/28/2014 08:57 AM, David Holmes wrote:
On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
In my opinion not, because Objects.requireNonNull is more readable
than
just string.toString. This way is
hat there aren't any issues arising from
changing this?
n 4/27/2014 6:15 AM, Otávio Gonçalves de Santana wrote:
There is an issue that was opened to remove redundant calls of
toString()
on String objects. [1]
I went deep on all JVM sources and I found all, 32 changes.
[1]https://bu
On 04/28/2014 05:43 PM, Claes Redestad wrote:
On 04/28/2014 08:57 AM, David Holmes wrote:
On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
In my opinion not, because Objects.requireNonNull is more readable than
just string.toString. This way is more understandable which field is
requir
to avoid
having the
string be a compile-time constant that can be inlined into other files.
Has anyone checked that there aren't any issues arising from
changing this?
n 4/27/2014 6:15 AM, Otávio Gonçalves de Santana wrote:
There is an issue that was opened to remove redundant calls of
constant that can be inlined into other files.
Has anyone checked that there aren't any issues arising from changing this?
n 4/27/2014 6:15 AM, Otávio Gonçalves de Santana wrote:
There is an issue that was opened to remove redundant calls of toString()
on String objects. [1]
I went deep
On 04/28/2014 08:57 AM, David Holmes wrote:
On 28/04/2014 1:05 PM, Otávio Gonçalves de Santana wrote:
In my opinion not, because Objects.requireNonNull is more readable than
just string.toString. This way is more understandable which field is
required and doesn't impact on performance.
An invo
On Apr 27, 2014, at 3:15 PM, Otávio Gonçalves de Santana <
> > otaviopolianasant...@gmail.com> wrote:
> >
> > > There is an issue that was opened to remove redundant calls of
> toString()
> > > on String objects. [1]
> > > I went deep on all JVM source
ed services is
> fairly easy to use, and therefore will make it easier to accept such
> patches.
>
> Paul.
>
> On Apr 27, 2014, at 3:15 PM, Otávio Gonçalves de Santana <
> otaviopolianasant...@gmail.com> wrote:
>
> > There is an issue that was opened to remove red
/__java2d/loops/TransformBlit.__java
>> Wed Apr 23
>> 11:35:40 2014 -0700
>> +++ b/src/share/classes/sun/__java2d/loops/TransformBlit.__java
>> Sun Apr 27
>> 14:33:45 2014 -0300
>> @@ -47,7
+++
b/src/share/classes/sun/tools/__jconsole/inspector/Utils.java
Sun Apr 27
14:33:45 2014 -0300
@@ -378,7 +378,7 @@
if (userInput instanceof XObject) {
result[i] = ((XObject) userInput).getObject();
was opened to remove redundant calls of toString()
> on String objects. [1]
> I went deep on all JVM sources and I found all, 32 changes.
;ScaledBlit(...)".toString();
>> +public static final String methodSignature = "ScaledBlit(...)";
>>
>> public static final int primTypeID = makePrimTypeID();
>>
>> diff -r e323c74edabd src/share/classes/sun/java2d/
>> loops/TransformBl
share/classes/sun/tools/jconsole/inspector/Utils.java
--- a/src/share/classes/sun/tools/jconsole/inspector/Utils.java Wed Apr 23
11:35:40 2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/inspector/Utils.java Sun Apr 27
14:33:45 2014 -0300
@@ -378,7 +378,7 @@
if (userInput instanceof XObject) {
rc/share/classes/sun/tools/jconsole/inspector/Utils.java
--- a/src/share/classes/sun/tools/jconsole/inspector/Utils.java Wed Apr 23
11:35:40 2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/inspector/Utils.java Sun Apr 27
14:33:45 2014 -0300
@@ -378,7 +378,7 @@
if (userInput ins
There is an issue that was opened to remove redundant calls of toString()
on String objects. [1]
I went deep on all JVM sources and I found all, 32 changes.
[1]https://bugs.openjdk.java.net/browse/JDK-8015470
diff -r e323c74edabd
src/share/classes/com/sun/tools/example/debug/tty/Commands.java
On 04/27/2014 03:15 PM, Otávio Gonçalves de Santana wrote:
There is an issue that was opened to remove redundant calls of toString()
on String objects. [1]
I went deep on all JVM sources and I found all, 32 changes.
[1]https://bugs.openjdk.java.net/browse/JDK-8015470
Otavio,
calling toString
There is an issue that was opened to remove redundant calls of toString()
on String objects. [1]
I went deep on all JVM sources and I found all, 32 changes.
[1]https://bugs.openjdk.java.net/browse/JDK-8015470
diff -r e323c74edabd
src/share/classes/com/sun/tools/example/debug/tty/Commands.java
Changeset: 571e5f452640
Author:dholmes
Date: 2013-06-06 05:32 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/571e5f452640
8015470: Remove redundant calls of toString() on String objects
Reviewed-by: dholmes, alanb
Contributed-by: Otavio Goncalves
! src/share/classes/com
24 matches
Mail list logo
