Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-16 Thread Martin Buchholz
On Fri, Oct 16, 2009 at 04:21, Michael McMahon wrote: > Damjan Jovanovic wrote: > "environment variables which are not modified by Java code will have >  an unmodified native representation in the subprocess." The intent of that statement is to promise not to mangle environment variables that ca

Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-16 Thread Michael McMahon
Damjan Jovanovic wrote: The environment variable: * Must not be inherited by child processes * Ideally, should not be seen by Java apps AFAIK Java has no API to unset environment variables. It is possible to manipulate the environment passed to sub-processes though. However, the spec is cle

Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-16 Thread Martin Buchholz
(I'm the original author of ProcessEnvironment) I agree with other nay-sayers that we really don't want to have special treatment of magic environment variables. It's no surprise that the launcher and process maintainers resist the addition of AWT-specific code into their area. Immutability of t

Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-15 Thread Damjan Jovanovic
The environment variable: * Must not be inherited by child processes * Ideally, should not be seen by Java apps AFAIK Java has no API to unset environment variables. Even if it did, it would be too late for an AWT window to unset it, because child processes can be launched sooner and would still

Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-15 Thread Andrew John Hughes
2009/10/15 Michael McMahon : > It doesn't seem right to filter out arbitrary environment variables > like that (inside ProcessEnvironment). Sorry, I haven't been following this > issue closely, > but is it not possible to unset this variable somewhere else? > I concur. That's a nasty hack that's

Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-15 Thread Michael McMahon
It doesn't seem right to filter out arbitrary environment variables like that (inside ProcessEnvironment). Sorry, I haven't been following this issue closely, but is it not possible to unset this variable somewhere else? - Michael. Alan Bateman wrote: Martin, Michael - have either of you loo

Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-15 Thread Alan Bateman
Martin, Michael - have either of you looked at the filtering that they are proposing to add to ProcessEnvironment? Anthony Petrov wrote: Hello, Please review the next version of the fix contributed by Damjan Jovanovic: RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094 There you c

Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-10-14 Thread Anthony Petrov
Hello, Please review the next version of the fix contributed by Damjan Jovanovic: RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094 There you can also find some latest comments regarding the fix. webrev: http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.1/ Since the patch