Re: Review request for JDK-8014834 : shell tests don't begin with #!/bin/sh

On 01/06/2013 13:32, Eric McCorkle wrote: Thanks, Kumar. Do I have a second? For the jdk repository then only one reviewer is required although in specialized or complicated areas then having a reviewer that knows the area well is important. In this case I think you are good to go. Just on

Re: Review request for JDK-8014834 : shell tests don't begin with #!/bin/sh

Thanks all, putting the changes in. On 06/03/13 06:07, Alan Bateman wrote: On 01/06/2013 13:32, Eric McCorkle wrote: Thanks, Kumar. Do I have a second? For the jdk repository then only one reviewer is required although in specialized or complicated areas then having a reviewer that knows

Re: Review request for JDK-8014834 : shell tests don't begin with #!/bin/sh

Thanks, Kumar. Do I have a second? Note: JPRT has been unreliable lately, so it may be a while before I can put this in. On 05/30/13 17:45, Kumar Srinivasan wrote: Hi Erik, This looks good, historically the #!shell was inserted after the CopyRight, because it was thought that the

Review request for JDK-8014834 : shell tests don't begin with #!/bin/sh

Hello, Please review this simple patch which fixes an issue with several of the shell script tests, namely that they do not start with #!/bin/sh The webrev is here: http://cr.openjdk.java.net/~emc/8014834/ The bug is here: http://bugs.sun.com/view_bug.do?bug_id=8014834 Thanks, Eric

Re: Review request for JDK-8014834 : shell tests don't begin with #!/bin/sh

Hi Erik, This looks good, historically the #!shell was inserted after the CopyRight, because it was thought that the automated CR updaters might get confused. I am cc'ing Dave K, just so that he is aware of this. Thanks Kumar Hello, Please review this simple patch which fixes an issue