On Oct 1, 2013, at 9:12 AM, Eric McCorkle eric.mccor...@oracle.com wrote:
Hello, please review this simple patch which fixes a problem in the type
annotations handling API. This manifests as a problem with both
j.l.r.Parameter.getAnnotatedType().getType() as well as
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06, Joel Borggren-Franck wrote:
Hi Eric,
Thanks for fixing this.
On 2013-10-01, Eric McCorkle wrote:
Hello, please review this simple patch which fixes a
Looks fine; cheers,
-Joe
On 10/1/2013 11:18 AM, Eric McCorkle wrote:
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06, Joel Borggren-Franck wrote:
Hi Eric,
Thanks for fixing this.
On 2013-10-01, Eric
Looks good.
cheers
/Joel
On Oct 1, 2013, at 8:18 PM, Eric McCorkle eric.mccor...@oracle.com wrote:
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06, Joel Borggren-Franck wrote:
Hi Eric,
Thanks for fixing
Thanks all, committing after successful tests.
On 10/01/13 14:33, Joe Darcy wrote:
Looks fine; cheers,
-Joe
On 10/1/2013 11:18 AM, Eric McCorkle wrote:
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06,
Hi Eric,
If it is not too late you could also change other references to new
TypeAnnotation[0] in the same source file.
78 TypeAnnotation[] typeAnnotations = l.toArray(new
TypeAnnotation[0]);
79 return AnnotatedTypeFactory.buildAnnotatedType(type,
80
I am already running pre-commit tests, but I have another upcoming
reflection API patch, and I could do this as part of that one.
On 10/01/13 15:36, Paul Sandoz wrote:
Hi Eric,
If it is not too late you could also change other references to new
TypeAnnotation[0] in the same source file.
