Re: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-05 Thread huizhe wang
August 05, 2015 2:26 AM *To:* Frank Yuan *Cc:* 'core-libs-dev' ; 'Alan Bateman' ; 'Jan Lahoda' *Subject:* Re: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api Hi Frank, That looks fine. However, instead of append

RE: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-05 Thread Frank Yuan
equest for JDK-8132660: Change jaxp unit test package name to be different with jaxp api Hi Frank, That looks fine. However, instead of appending an additional directory "utests", you could make the paths shorter by removing "javax/xml" and "org/w3c" or "org

Re: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-04 Thread huizhe wang
Hi Frank, That looks fine. However, instead of appending an additional directory "utests", you could make the paths shorter by removing "javax/xml" and "org/w3c" or "org/xml". The short names are good enough to represent the API names, test/javax/xml/jaxp/unittest/parsers for example, is easil

Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-03 Thread Frank Yuan
Hi, Joe and all Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8132660? This is already on our plan for a while, but I have to finish it now because these unit tests failed with latest Jigsaw build. However I made the changes based on 9-dev repo, I tested t