RE: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-05 Thread Frank Yuan
Hi Joe Thank you very much! Really good advice! I have adjusted as it, please re-check at: http://cr.openjdk.java.net/~fyuan/8132660/webrev.01/ Btw, I only applied this practice on unit test, not for functional test because Tristan still has a functional suite pending, I would unify the

Re: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-05 Thread huizhe wang
Hi Frank, This looks good to me. Best, Joe On 8/5/2015 3:04 AM, Frank Yuan wrote: Hi Joe Thank you very much! Really good advice! I have adjusted as it, please re-check at: http://cr.openjdk.java.net/~fyuan/8132660/webrev.01/ http://cr.openjdk.java.net/%7Efyuan/8132660/webrev.01/ Btw,

Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-04 Thread Frank Yuan
Hi, Joe and all Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8132660? This is already on our plan for a while, but I have to finish it now because these unit tests failed with latest Jigsaw build. However I made the changes based on 9-dev repo, I tested

Re: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

2015-08-04 Thread huizhe wang
Hi Frank, That looks fine. However, instead of appending an additional directory utests, you could make the paths shorter by removing javax/xml and org/w3c or org/xml. The short names are good enough to represent the API names, test/javax/xml/jaxp/unittest/parsers for example, is easily