Lance - this looks good to me.
In FilteredRowSetImpl.java -
-bool = p.evaluate(new Float(x) , columnIndex);
+bool = p.evaluate(Float.valueOf(x) , columnIndex);
I was tempted to suggest removing the space before ','. But I
found that the coding convention is kinda inconsi
Thank you Mandy and Remi.
Mandy, I addressed the nit below before the push
Best
Lance
On Oct 11, 2012, at 6:38 PM, Mandy Chung wrote:
> Lance - this looks good to me.
>
> In FilteredRowSetImpl.java -
> -bool = p.evaluate(new Float(x) , columnIndex);
> +bool = p.evaluate(
On 10/11/2012 07:34 PM, Lance Andersen - Oracle wrote:
Hi Remi,
Thank you for the suggestion, I had forgotten about parseDouble. I
made your suggested change below.
Best
Lance
thumb up.
regards,
Rémi
new-host-2:rowset lanceandersen$ hg diff
diff -r c2be39b27e1c
src/share/classes/com/
Hi Remi,
Thank you for the suggestion, I had forgotten about parseDouble. I made your
suggested change below.
Best
Lance
new-host-2:rowset lanceandersen$ hg diff
diff -r c2be39b27e1c src/share/classes/com/sun/rowset/CachedRowSetImpl.java
--- a/src/share/classes/com/sun/rowset/CachedRowSetImpl
Hi,
Revised CachedRowSetImpl as I noticed Findbugs missed a scenario where you
should use the XXX.valueOf methods from constructors.
Thank you
Best
Lance
new-host-2:rowset lanceandersen$ hg status -m
M src/share/classes/com/sun/rowset/CachedRowSetImpl.java
M src/share/classes/com/sun/rowse
On 10/11/2012 06:45 PM, Lance Andersen - Oracle wrote:
Hi,
Need a review for changing to use the XXX.valueOf methods from constructors.
Thank you
Best
Lance
Hi Lance,
in CachedRowSetImpl, the code is equivalent to
return Double.compare(Double.parseDouble(value.toString()), 0) != 0;
which a
Hi,
Need a review for changing to use the XXX.valueOf methods from constructors.
Thank you
Best
Lance
new-host-2:rowset lanceandersen$ hg status -m
M src/share/classes/com/sun/rowset/CachedRowSetImpl.java
M src/share/classes/com/sun/rowset/FilteredRowSetImpl.java
M src/share/classes/javax/sql
