Re: RFR JDK-8042888: Remove extcheck tool

2014-10-15 Thread Chris Hegarty
On 15 Oct 2014, at 16:52, Alan Bateman wrote: > On 15/10/2014 16:09, Pavel Rappo wrote: >> Hi everyone, >> >> Could you please review my change for JDK-8042888? >> >> http://cr.openjdk.java.net/~prappo/8042888/webrev.00/ >> >> > This looks good, you seem to have caught everything. +1. -Chr

Re: RFR JDK-8042888: Remove extcheck tool

2014-10-15 Thread Alan Bateman
On 15/10/2014 16:09, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8042888? http://cr.openjdk.java.net/~prappo/8042888/webrev.00/ This looks good, you seem to have caught everything. -Alan.

RFR JDK-8042888: Remove extcheck tool

2014-10-15 Thread Pavel Rappo
Hi everyone, Could you please review my change for JDK-8042888? http://cr.openjdk.java.net/~prappo/8042888/webrev.00/ Previously I sent an email to see if anyone uses this tool or has any thoughts on its future [1]. --

Re: extcheck

2014-09-22 Thread Alan Bateman
On 11/09/2014 17:23, Pavel Rappo wrote: : We don't think it is widely used. And will become even less useful with upcoming modularization. Are there any good reasons to keep this thing in the JDK? Searching for usages on stackoverflow and other sites doesn't come up with much, it would be su

extcheck

2014-09-11 Thread Pavel Rappo
Hi everyone, We are thinking of removing the extcheck tool. For those who doesn't remember what it is, here is an extract from its man page: extcheck(1) NAME extcheck - jar conflict detection utility SYNOPSIS extcheck [ -verbose ] [ -Joption ] targetfile.jar DESCRIPTION

Re: Code review request: 6907367 extcheck should skip non-jar files

2011-12-05 Thread Alan Bateman
/extcheck/TestExtcheckArgs.java.sdiff.html The test case will failed if run against the current jdk8 build image because all those jar files still have their "specification-version" listed as "1.7", as --- Manifest-Version: 1.0 Implement

Code review request: 6907367 extcheck should skip non-jar files

2011-12-01 Thread Xueming Shen
Please help review the change at http://cr.openjdk.java.net/~sherman/6907367/webrev The proposed change does not include the test case I was originally planed as showed at http://cr.openjdk.java.net/~sherman/6907367/webrev.00/test/com/sun/tools/extcheck/TestExtcheckArgs.java.sdiff.html The