Re: i18n dev RFR: 8025051: Update resource files for TimeZone display names

2013-12-24 Thread Aleksej Efimov
Masayoshi, Michael, Many thanks for reviewing this fix and for all your comments. Can I ask someone for a JDK8 commit sponsorship? The hg export is located here: http://cr.openjdk.java.net/~aefimov/8025051/8/8025051_jdk8.patch Also, I want to take this opportunity and wish a Merry Christmas

Re: i18n dev RFR: 8025051: Update resource files for TimeZone display names

2013-12-23 Thread Michael Fang
Thanks Aleksej for addressing the ACT issue. The l10n files look fine to me. I agree that we should work on translation consistency issues separately the next time we have a translation cycle. thanks, -michael On 13?12?22? 10:14 ??, Aleksej Efimov wrote: Hi, The new version of patch for

Re: i18n dev RFR: 8025051: Update resource files for TimeZone display names

2013-12-23 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 12/23/2013 3:14 AM, Aleksej Efimov wrote: Hi, The new version of patch for TimeZone display names update is available. Previous webrev contains incorrect naming for Acre timezone generic name (ACT[] array) across all non-root locales. The name was corrected

Re: i18n dev RFR: 8025051: Update resource files for TimeZone display names

2013-12-22 Thread Aleksej Efimov
Hi, The new version of patch for TimeZone display names update is available. Previous webrev contains incorrect naming for Acre timezone generic name (ACT[] array) across all non-root locales. The name was corrected and test TimeZoneNames_*.properties files were modified accordingly. The new

Re: i18n dev RFR: 8025051: Update resource files for TimeZone display names

2013-12-20 Thread Aleksej Efimov
Masayoshi, Thank you for the detailed review and your comments. I tried to address all of them. The responses are below. The new webrev can be found here: http://cr.openjdk.java.net/~aefimov/8025051/8/webrev.01/ http://cr.openjdk.java.net/%7Eaefimov/8025051/8/webrev.01/ Michael, As Masayoshi

Re: i18n dev RFR: 8025051: Update resource files for TimeZone display names

2013-12-19 Thread Masayoshi Okutsu
On 12/18/2013 6:43 PM, Aleksej Efimov wrote: Hi, Please help to review a fix [1] for 8025051 bug [2]. The following fix includes: Common to all modified files: - All year ranges in the copyright header should be modified accordingly. - The translation of time zone generic names were added