On 12/08/2011 01:25 PM, Stuart Marks wrote:
On 12/8/11 8:25 AM, Omair Majid wrote:
On 12/7/11 3:13 PM, Omair Majid wrote:
You have commit rights, don't you? I'd say it's OK to proceed with the
push. Or, if you prefer, Alan should be online in just a couple hours,
and I'm sure he can give the fin
On 12/8/11 8:25 AM, Omair Majid wrote:
On 12/7/11 3:13 PM, Omair Majid wrote:
You have commit rights, don't you? I'd say it's OK to proceed with the
push. Or, if you prefer, Alan should be online in just a couple hours,
and I'm sure he can give the final go-ahead.
Yes, I do have commit rights a
On 12/08/2011 01:22 AM, Stuart Marks wrote:
On 12/7/11 3:13 PM, Omair Majid wrote:
On 12/07/2011 05:43 AM, Alan Bateman wrote:
I looked through the latest webrev. In
EnumConstantNotPresentException.java then the
@SuppressWarnings("rawtypes") should probably have a comment to explain
why it is n
On 08/12/2011 06:22, Stuart Marks wrote:
Hi Omair,
Everything looks good to me. I think Alan was lamenting that adding
the local variable for the sole purpose of adding the
@SuppressWarnings annotation makes the method appear longer and more
complex. The alternative is to put @SuppressWarnin
On 12/7/11 3:13 PM, Omair Majid wrote:
On 12/07/2011 05:43 AM, Alan Bateman wrote:
I looked through the latest webrev. In
EnumConstantNotPresentException.java then the
@SuppressWarnings("rawtypes") should probably have a comment to explain
why it is needed. In ThreadLocal.get then it's a pity th
On 12/07/2011 05:43 AM, Alan Bateman wrote:
On 05/12/2011 22:09, Omair Majid wrote:
I have posted a new webrev:
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/03/
This includes all the changes from the feedback so far, as well as
changes to ThreadLocal.
I will not be posting a p
On 05/12/2011 22:09, Omair Majid wrote:
I have posted a new webrev:
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/03/
This includes all the changes from the feedback so far, as well as
changes to ThreadLocal.
I will not be posting a patch for ClassValue since (as you kindly
p
Hi,
On 12/04/2011 08:02 PM, Stuart Marks wrote:
Please review the following webrev submitted by Omair Majid, consisting
of warnings fixes for a variety of files in java.lang.
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/01/
It looks pretty clean, but it would be good to get ano
On 12/4/2011 5:02 PM, Stuart Marks wrote:
Please review the following webrev submitted by Omair Majid,
consisting of warnings fixes for a variety of files in java.lang.
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/01/
It looks pretty clean, but it would be good to get another p
On 12/05/2011 11:28 AM, Alan Bateman wrote:
On 05/12/2011 16:14, Omair Majid wrote:
src/windows/classes/java/lang/ProcessEnvironment.java:
- Added a serialVersionUID. Unfortunately, I don't have a windows box
so I cant identify the previous serialVersionUID value for this class.
Can someone wi
On 12/05/2011 01:35 AM, Stuart Marks wrote:
Whoops, good catch. Those changes are indeed not permitted. We'll have
to use @SuppressWarnings("rawtypes") or some such instead.
Thanks for the comments. I have an updated webrev available at:
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day
On 05/12/2011 01:02, Stuart Marks wrote:
Please review the following webrev submitted by Omair Majid,
consisting of warnings fixes for a variety of files in java.lang.
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/01/
It looks pretty clean, but it would be good to get another pa
Whoops, good catch. Those changes are indeed not permitted. We'll have to use
@SuppressWarnings("rawtypes") or some such instead.
s'marks
On 12/4/11 6:04 PM, David Holmes wrote:
Are the signature changes in
src/share/classes/java/lang/EnumConstantNotPresentException.java
permitted?
Otherwis
Are the signature changes in
src/share/classes/java/lang/EnumConstantNotPresentException.java
permitted?
Otherwise looks okay to me.
David
On 5/12/2011 11:02 AM, Stuart Marks wrote:
Please review the following webrev submitted by Omair Majid, consisting
of warnings fixes for a variety of fil
Please review the following webrev submitted by Omair Majid, consisting of
warnings fixes for a variety of files in java.lang.
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/01/
It looks pretty clean, but it would be good to get another pair of eyes on this
since there is sometim
15 matches
Mail list logo
