Re: webrevs.2 for macosx changes to jdk7u-osx

On 02/12/2011 02:03, David Holmes wrote: : My concern is that there are a number of platform specific changes being made to java.* and javax.* classes (there are changes to sun.* as well but that is less of a concern). http://cr.openjdk.java.net/~michaelm/7113349/4/jdk7u-osx/modified/ I woul

Re: Code Review Request for Bug #4802647

On 01/12/2011 22:42, Brandon Passanisi wrote: Hi Jason. Thanks for your response. I was thinking about how I can improve the test using your suggestion. I could possibly do the following: 1. Find all of the subclasses of AbstractCollection which override removeAll(Collection) and which

Re: 7116954: Misc warnings in java.beans/java.beans.context

On 02/12/11 10:31, Sergey Malenkov wrote: I approve changes with a small update. java/beans/VetoableChangeSupport.java: -Hashtable children = (Hashtable) fields.get("children", null); +@SuppressWarnings("unchecked") +Hashtable children = (Hashtable)fields.get("childre

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

On Thu, Dec 1, 2011 at 10:08 PM, Lance Andersen - Oracle wrote:> Sadly,  once i start digging, i found more changes :-(>> Here are the latest revisions with the additions/changes since the last review, http://cr.openjdk.java.net/~lancea/7116445/webrev.03: Lance, I'd suggest also including the att

Re: 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers

Alan, Would you mind taking a quick look at the updated webrev? Trivially, I fixed a few style issues in HttpServerProvider (a nit of mine) and updated the commented code in FtpClientProvider (in case it ever gets enabled ). Let's remove any possibility of sun.misc.Service every reappearing ;

Re: Request for Review: Warnings cleanup in java.lang.*, java.util.**

cc'ing core-libs-dev as that is the place to discuss these changes. I see on the sign-up sheet [1] that omajid has signed up for java.lang, maybe you are working together? I'll leave it to Stuart to say whether he wants to refactor/other changes separated from the warnings changes. One thing

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

Hi Dave, thanks for the feedback. Adding @Deprecated changes the signatures so I need to coordinate any changes as it will result in TCK signature failures. This is something I will most likely do as part of the JDBC 4.2 work after giving the JDBC EG a chance for input. There are several pla

hg: jdk8/tl/jdk: 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers

Changeset: f615db07991e Author:chegar Date: 2011-12-02 11:39 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f615db07991e 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: prr ! src/share/classes/com/sun/media/sound/JSSecu

7117357: Warnings in sun.instrument, tools and other sun.* classes

I'm down on the sign-up sheet for warnings in a couple of arcane areas. The following webrev fixes the warnings in sun.instrument.*, several serviceability tools, serialver, and some residual warnings left in sun.net.**. I've run all the tests for all these areas with the changes. http://cr.

Re: 7117357: Warnings in sun.instrument, tools and other sun.* classes

Looks good to me Best Lance On Dec 2, 2011, at 8:42 AM, Alan Bateman wrote: > > I'm down on the sign-up sheet for warnings in a couple of arcane areas. The > following webrev fixes the warnings in sun.instrument.*, several > serviceability tools, serialver, and some residual warnings left in

Re: 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers

On 02/12/2011 11:30, Chris Hegarty wrote: Alan, Would you mind taking a quick look at the updated webrev? Trivially, I fixed a few style issues in HttpServerProvider (a nit of mine) and updated the commented code in FtpClientProvider (in case it ever gets enabled ). Let's remove any possibili

Re: 7117357: Warnings in sun.instrument, tools and other sun.* classes

On 02/12/2011 13:49, Lance Andersen - Oracle wrote: Looks good to me Thumbs up from me too. -Chris. Best Lance On Dec 2, 2011, at 8:42 AM, Alan Bateman wrote: I'm down on the sign-up sheet for warnings in a couple of arcane areas. The following webrev fixes the warnings in sun.instrumen

Request for Review (XXL): 7104647: Adding a diagnostic command framework

Hi All, [Posting to serviceability-dev, runtime-dev and core-libs-dev because changes are pretty big and touch all these areas] Here's a framework for issuing diagnostics commands to the JVM. Diagnostic commands are actions executed inside the JVM mainly for monitoring or management purpose. Thi

Cleanup fallthrough in FilePermission and PropertyPermission was: Request for Review of 7116890 (Warning Cleanup java.io)

Hi Brandon, i will try to work out a fix for both and cc the review request to you. -- Sebastian Am 01.12.2011 23:54, schrieb Brandon Passanisi: Hi Sebastian. I was speaking with Stuart Marks earlier today and he mentioned that the "fallthrough" code in FilePermission.java also exists in jav

Re: Request for Review of 7116890 (Warning Cleanup java.io)

Am 02.12.2011 01:22, schrieb Stuart Marks: On 12/1/11 2:13 PM, Stuart Marks wrote: On 12/1/11 12:38 PM, Alan Bateman wrote: On 01/12/2011 18:35, Sebastian Sickelmann wrote: : Thanks Alan, L67-68 was a backporting (from a more complex solution to a small warning cleanup) issue. I missed the t

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

Here is the diff for DriverManager, I won't be pushing another webrev unless the word is to go ahead and add @Deprecated to the com/* classes of the RowSet RI or there is another change requested that is more detailed: dhcp-adc-twvpn-2-vpnpool-10-154-44-9:sql lanceandersen$ hg diff DriverManage

RFR 7117360: Warnings in java.util.concurrent.atomic package

Cleanup compiler warnings in the java.util.concurrent.atomic package. This is a sync up with the raw type warning fixes in Doug's CVS, along with some minor style cleanup. With this change there are still 2 outstanding unchecked casts in AtomicReferenceArray and AtomicReferenceFieldUpdater. W

Re: RFR 7117360: Warnings in java.util.concurrent.atomic package

Oh, AtomicBoolean.java and AtomicReference.java show no differences in the webrev, but there is a correction to the indentation in the static initializer. And just to point out, along with raw type warning fixes there is a removal of a redundant cast ;-) -Chris. On 02/12/2011 14:25, Chris

Re: Cleanup fallthrough in FilePermission and PropertyPermission was: Request for Review of 7116890 (Warning Cleanup java.io)

Hi Sebastian. I'm not sure if you had seen the e-mail from Stuart Marks regarding this, but Stuart was able to find more instances of the similar block of "fallthrough" code. I can volunteer to apply your upcoming change to FilePermission to the other files if you wish. Or, you can try apply

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

On Fri, Dec 2, 2011 at 8:19 AM, Lance Andersen - Oracle < lance.ander...@oracle.com> wrote: > Adding @Deprecated changes the signatures so I need to coordinate any > changes as it will result in TCK signature failures. This is something I > will most likely do as part of the JDBC 4.2 work after

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 12/2/11 12:54 AM, Sebastian Sickelmann wrote: > The 3 solutions I mentioned are solutions that can be commonly discussed > for a solution choosing for all Exceptions in OpenJDK. > > Webrev[0] shows solution 1 for jx/x/s-Exceptions. From the users > perspective (outside view) solution 1 and 3

hg: jdk8/tl/jdk: 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers

Changeset: 37f6e294759f Author:chegar Date: 2011-12-02 14:17 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37f6e294759f 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: alanb, lancea ! src/share/classes/c

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

On Dec 2, 2011, at 10:54 AM, David Schlosnagle wrote: > On Fri, Dec 2, 2011 at 8:19 AM, Lance Andersen - Oracle > wrote: > Adding @Deprecated changes the signatures so I need to coordinate any changes > as it will result in TCK signature failures. This is something I will most > likely do a

Re: RFR 7117360: Warnings in java.util.concurrent.atomic package

On 12/02/11 09:25, Chris Hegarty wrote: Cleanup compiler warnings in the java.util.concurrent.atomic package. This is a sync up with the raw type warning fixes in Doug's CVS, along with some minor style cleanup. With this change there are still 2 outstanding unchecked casts in AtomicReferenceAr

Re: Cleanup fallthrough in FilePermission and PropertyPermission was: Request for Review of 7116890 (Warning Cleanup java.io)

Am 02.12.2011 16:27, schrieb Brandon Passanisi: Hi Sebastian. I'm not sure if you had seen the e-mail from Stuart Marks regarding this, but Stuart was able to find more instances of the similar block of "fallthrough" code. I can volunteer to apply your upcoming change to FilePermission to the

Re: Request for Review: Warnings cleanup in java.lang.*, java.util.**

Hi, On 12/02/2011 07:18 AM, Alan Bateman wrote: cc'ing core-libs-dev as that is the place to discuss these changes. I see on the sign-up sheet [1] that omajid has signed up for java.lang, maybe you are working together? Unfortunately, David and I were not working together :( Anyway, here is

Re: RFR 7117360: Warnings in java.util.concurrent.atomic package

On 12/ 2/11 04:22 PM, Doug Lea wrote: We just went through these and others, and believe that everything is now warning free. Thanks Doug, Wow you guys are quick! I pulled in these specific changes (atomic) and updated the webrev: http://cr.openjdk.java.net/~chegar/7117360/webrev.01/web

hg: jdk8/tl/jdk: 7117357: Warnings in sun.instrument, tools and other sun.* classes

Changeset: 9950e2c9f3b5 Author:alanb Date: 2011-12-02 17:37 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9950e2c9f3b5 7117357: Warnings in sun.instrument, tools and other sun.* classes Reviewed-by: lancea, chegar ! src/share/classes/sun/instrument/InstrumentationImpl.java

Re: Request for Review: 7116914 (Miscellaneous warnings (sun.text))

Looks good. In NormalizerImpl.java: - The parens are probably not needed around 'length=(srcIndex-prevSrc);' UnicodeSet.java: - I confirmed, just to be sure, that the added 'break;' statements have no effect. On Dec 1 2011, at 23:51 , Yuka Kamiya wrote: > Hello, > > Could someone please revi

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

Hi Lance, I'm OK with postponing the @Deprecated work, and doing a separate pass for @Deprecated, including the com.sun.* stuff at that time. There's enough stuff in this changeset already. I think we're better off getting it in now than putting more stuff in and getting it reviewed again. I

Re: Request for Review: 7116914 (Miscellaneous warnings (sun.text))

On 12/1/11 11:51 PM, Yuka Kamiya wrote: > Hello, > > Could someone please review this fix? > > http://cr.openjdk.java.net/~peytoia/7116914/webrev.00/ > > Some warnings are still issued even after this fix, and that's intentional. > I'd like to solve them in another way rather than using > @Supp

Re: Cleanup fallthrough in FilePermission and PropertyPermission was: Request for Review of 7116890 (Warning Cleanup java.io)

I'm adding Weijun (Max) Wang to this thread. The same "ackbarfaccept" code had come up a third time when I was reviewing some of Max's changes. The code in question all has to do with permissions, and Max is in the security group, so he might have a better insight whether doing a refactoring i

Re: Request for Review: 7116914 (Miscellaneous warnings (sun.text))

On 12/2/11 12:25 PM, Mike Duigou wrote: UnicodeSet.java: - I confirmed, just to be sure, that the added 'break;' statements have no effect. A stylistic comment, not directly relevant to warnings fixes. The compiler warns about possible fall-through to the next case, but the locations where "

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

Hi Stuart, On Dec 2, 2011, at 3:45 PM, Stuart Marks wrote: > Hi Lance, > > I'm OK with postponing the @Deprecated work, and doing a separate pass for > @Deprecated, including the com.sun.* stuff at that time. OK, will do that separately > > There's enough stuff in this changeset already. I th

Review request for bug #5063455

Hello core-libs-dev. I was wondering if somebody could review the following proposed fix and test case for bug #5063455. Here's the info: Bug URL: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5063455 Webrev: http://cr.openjdk.java.net/~sherman/5063455/webrev/ Thanks. -- Oracle

Re: Review Request for 7116997 (warning cleanup java.util.PropertyPermission)

Thanks for the review Stuart. Here is a another webrev for review containing your suggested change: http://cr.openjdk.java.net/~dmocek/bpassanisi/7116997/webrev.01/ On 12/1/2011 4:06 PM, Stuart Marks wrote: On 12/1/1

hg: jdk8/tl/jdk: 7117465: Warning cleanup for IMF classes

Changeset: 42532a097816 Author:naoto Date: 2011-12-02 16:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42532a097816 7117465: Warning cleanup for IMF classes Reviewed-by: okutsu ! src/share/classes/java/awt/im/InputMethodHighlight.java ! src/share/classes/sun/awt/im/Compo

hg: jdk8/tl/jdk: 5035850: (str) String.CASE_INSENSITIVE_ORDER should override readResolve()

Changeset: 1d7037df65ed Author:sherman Date: 2011-12-02 16:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d7037df65ed 5035850: (str) String.CASE_INSENSITIVE_ORDER should override readResolve() Summary: Fix to ensure singleton property of String.CaseInsensitiveComparator

hg: jdk8/tl/jdk: 7117585: Eliminate java.lang.instrument, java.lang.management warnings

Changeset: 98502d7a3f98 Author:mchung Date: 2011-12-02 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98502d7a3f98 7117585: Eliminate java.lang.instrument, java.lang.management warnings Reviewed-by: mchung Contributed-by: Jon VanAlten ! src/share/classes/java/lang/ins

hg: jdk8/tl/jdk: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

Changeset: 3c524deb8431 Author:lancea Date: 2011-12-02 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431 7116445: Miscellaneous warnings in the JDBC/RowSet classes Reviewed-by: smarks, chegar ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/shar

hg: jdk8/tl/jdk: 7117487: Warnings Cleanup: some i18n classes in java.util and sun.util

Changeset: f2a5d0001f15 Author:okutsu Date: 2011-12-03 10:58 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2a5d0001f15 7117487: Warnings Cleanup: some i18n classes in java.util and sun.util Reviewed-by: lancea, naoto ! src/share/classes/java/util/Date.java ! src/share/clas