Hi all,
I updated 2 files(src/share/classes/sun/font/StrikeCache.java,
src/share/classes/sun/java2d/Disposer.java) to use generic type, but I'm
not sure if I modified too much. Especially I changed the return type of
Disposer.getQueue from ReferenceQueue to ReferenceQueue .
The webrev is: ht
On 02/05/2012 09:01, Sean Chou wrote:
Hi all,
I updated 2 files(src/share/classes/sun/font/StrikeCache.java,
src/share/classes/sun/java2d/Disposer.java) to use generic type, but I'm
not sure if I modified too much. Especially I changed the return type of
Disposer.getQueue from ReferenceQueu
On 01/05/2012 19:06, Xueming Shen wrote:
Hi,
Just noticed that webrev url was pointing to the blenderrev. The
webrev is at
http://cr.openjdk.java.net/~sherman/7014640/webrev
I went through the webrev and don't see any issues. The slight behavior
change with the previously undocumented \v se
On 2/05/2012 6:30 PM, Alan Bateman wrote:
On 02/05/2012 09:01, Sean Chou wrote:
Hi all,
I updated 2 files(src/share/classes/sun/font/StrikeCache.java,
src/share/classes/sun/java2d/Disposer.java) to use generic type, but I'm
not sure if I modified too much. Especially I changed the return type o
On 02/05/2012 04:54, David Holmes wrote:
Hi Kurchi,
You should also add:
@throws NullPointerException {@inheritDoc}
Right, it would be best to clarify this in the AbstractPreferences
specification, similar to the other putXXX, getXXX methods.
to the method spec so that the docs re-instate
On 2/05/2012 7:53 PM, Chris Hegarty wrote:
On 02/05/2012 04:54, David Holmes wrote:
Hi Kurchi,
You should also add:
@throws NullPointerException {@inheritDoc}
Right, it would be best to clarify this in the AbstractPreferences
specification, similar to the other putXXX, getXXX methods.
to t
On 02/05/2012 04:54, David Holmes wrote:
Hi Kurchi,
You should also add:
@throws NullPointerException {@inheritDoc}
to the method spec so that the docs re-instate the fact that it is
supposed to throw NPE. As it stands I could argue that
AbstractPreferences.remove has chosen not to throw NPE
On 02/05/2012 10:55, David Holmes wrote:
On 2/05/2012 7:53 PM, Chris Hegarty wrote:
On 02/05/2012 04:54, David Holmes wrote:
Hi Kurchi,
You should also add:
@throws NullPointerException {@inheritDoc}
Right, it would be best to clarify this in the AbstractPreferences
specification, similar
On 05/02/2012 11:41 AM, David Holmes wrote:
On 2/05/2012 6:30 PM, Alan Bateman wrote:
On 02/05/2012 09:01, Sean Chou wrote:
Hi all,
I updated 2 files(src/share/classes/sun/font/StrikeCache.java,
src/share/classes/sun/java2d/Disposer.java) to use generic type, but
I'm
not sure if I modified to
Changeset: d78c6095dc98
Author:vinnie
Date: 2012-05-02 14:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d78c6095dc98
7087021: TEST: com/sun/crypto/provider/Mac/MacClone.java failed on Solaris
sparc 5.10
Reviewed-by: mullan
! test/com/sun/crypto/provider/Mac/MacClone.jav
Thanks all for the review. A webrev with the doc change:
http://cr.openjdk.java.net/~khazra/7165118/webrev.01/
I will go ahead and file a CCC for this.
Thanks,
Kurchi
On 5/2/2012 2:57 AM, Chris Hegarty wrote:
On 02/05/2012 10:55, David Holmes wrote:
On 2/05/2012 7:53 PM, Chris Hegarty wrot
On 5/2/2012 11:09 AM, Artem Ananiev wrote:
Hi, Mandy,
the client part of the fix looks fine.
Thanks for the review. I have pushed the changeset and hope you don't
mind I couldn't fix the changeset comment to add you as a reviewer.
Let me ask a naive question, though.
From your explanatio
Requesting approval to commit fix for CR 7118100.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7118100
Webrev: http://cr.openjdk.java.net/~khazra/7118100/webrev.01/
This had been reviewed by Alan Bateman. [1]
This fix has been pushed into jdk8 [2]
Thanks,
Kurchi
[1]
http://mail.op
Changeset: bb2cefc89bc0
Author:forax
Date: 2012-05-02 20:01 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2cefc89bc0
7165102: Only run assertion on Integer autoboxing cache size once
Reviewed-by: darcy, alanb
! src/share/classes/java/lang/Integer.java
Changeset: 531ebfd8eb65
Author:jgish
Date: 2012-05-02 21:46 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/531ebfd8eb65
7160714: Strange or obsolete @see tags in some exception java.util javadoc
Reviewed-by: mduigou, dholmes, alanb
! src/share/classes/java/util/NoSuchElement
Hi Rémi,
> your far from Swing :)
> (I remember you from the glorious appframework time)
I still do some Swing stuff. :)
> And the mailer deamon (or mailer imp ?) remove attachment, so you have to
> repost it inlined.
Some one should mention this fact on this site:
http://openjdk.java.net/cont
On 5/1/12 11:23 AM, Stefan Reich wrote:
Hi Stuart,
thank you for your reply. I sent a patch to the adopt-openjdk group that uses
multi-catch for catch clauses with duplicate code blocks in the same try
statement (message and patch attached). That patch covers all code in
src/shared/classes.
17 matches
Mail list logo
