hg: jdk8/tl/jdk: 8000476: Memory Leaks and uninitialized memory access in PKCS11 and other native code

2012-11-20 Thread chris . hegarty
Changeset: 2d08b404cd91 Author:jzavgren Date: 2012-11-20 09:26 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d08b404cd91 8000476: Memory Leaks and uninitialized memory access in PKCS11 and other native code Reviewed-by: dsamersoff, valeriep, chegar ! src/share/bin/wildcar

Re: Review Request: 8001533: Java launcher must launch JavaFX applications

2012-11-20 Thread Alan Bateman
On 20/11/2012 02:43, David DeHaven wrote: : After discussion and debate, we've decided the best course of action right now is to drop the JavaFX-Application-Class support for this round and revisit (hopefully quickly) in M6. This should alleviate any concerns for Profile support. There are oth

Re: code review request: Test case for JDK-7198904 TreeMap.clone issue

2012-11-20 Thread David Buck
Hi! > The one possible addition is to check that m1 hasn't been modified > after the mutation of m2. Sounds good. I have added the second test and retested against both OpenJDK and OracleJDK builds: [ Code Review for jdk ] http://cr.openjdk.java.net/~dbuck/7198904/webrev.01/ Would someone pl

Re: (CR#6553074) Unnecessary array copy in AbstractStringBuilder.indexOf(String)?

2012-11-20 Thread Alan Bateman
On 19/11/2012 17:49, Mike Duigou wrote: By amazing coincidence a review for fixing this was issued last week: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012266.html Additional review would be welcome. :-) The patch will probably be ready for push before the end of the m

Re: RFR: 8003322: Add instrumentation points for tracing of I/O calls

2012-11-20 Thread Staffan Larsen
On 19 nov 2012, at 13:35, Alan Bateman wrote: > On 19/11/2012 11:15, Staffan Larsen wrote: >> : >> I think you are right that bytecode instrumentation would also work. The >> only problem I see (apart from the path field) is the time it would take to >> develop such a solution. I'm not sure if

Re: RFR: 8003322: Add instrumentation points for tracing of I/O calls

2012-11-20 Thread Alan Bateman
On 20/11/2012 14:10, Staffan Larsen wrote: : The original plan was for the code in this review to go into both 8 and 7u12. Since 7u12 has a tighter deadline, a possible path would be to include it only in 7u12, but not in 8. For 8 we would then implement a fully dynamic solution. The only thin

Re: Review Request: 8001533: Java launcher must launch JavaFX applications

2012-11-20 Thread Kumar Srinivasan
On 11/20/2012 2:14 AM, Alan Bateman wrote: On 20/11/2012 02:43, David DeHaven wrote: : After discussion and debate, we've decided the best course of action right now is to drop the JavaFX-Application-Class support for this round and revisit (hopefully quickly) in M6. This should alleviate any

hg: jdk8/tl/jdk: 2 new changesets

2012-11-20 Thread kumar . x . srinivasan
Changeset: 914cd9b482c8 Author:ksrini Date: 2012-11-19 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914cd9b482c8 8001533: java launcher must launch javafx applications Reviewed-by: ksrini, mchung, kcr, alanb Contributed-by: david.deha...@oracle.com ! src/share/bin/ja

hg: jdk8/tl/langtools: 8003649: regression/langtools: tools/javac/doctree

2012-11-20 Thread jonathan . gibbons
Changeset: a25c53e12bd0 Author:jjg Date: 2012-11-20 07:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a25c53e12bd0 8003649: regression/langtools: tools/javac/doctree Reviewed-by: ksrini ! test/tools/javac/doctree/DocCommentTester.java

hg: jdk8/tl/langtools: 8003650: java.lang.Exception: expected string not found: pkg/package-frame.html

2012-11-20 Thread jonathan . gibbons
Changeset: fb97eaf93d61 Author:jjg Date: 2012-11-20 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb97eaf93d61 8003650: java.lang.Exception: expected string not found: pkg/package-frame.html Reviewed-by: ksrini ! test/tools/javadoc/api/basic/GetTask_WriterTest.j

hg: jdk8/tl/langtools: 8003663: lambda test fails on Windows

2012-11-20 Thread maurizio . cimadamore
Changeset: 7538e419a588 Author:mcimadamore Date: 2012-11-20 15:43 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7538e419a588 8003663: lambda test fails on Windows Summary: fix path separator issue in test Reviewed-by: jjg ! test/tools/javac/lambda/abort/Abort.java

Re: code review request: Test case for JDK-7198904 TreeMap.clone issue

2012-11-20 Thread Mike Duigou
Looks good. Thank you for making the change. Mike On Nov 20 2012, at 04:55 , David Buck wrote: > Hi! > > > The one possible addition is to check that m1 hasn't been modified > > after the mutation of m2. > > Sounds good. I have added the second test and retested against both OpenJDK > and Ora

Re: RFR: 8003322: Add instrumentation points for tracing of I/O calls

2012-11-20 Thread Mandy Chung
On 11/20/12 6:20 AM, Alan Bateman wrote: On 20/11/2012 14:10, Staffan Larsen wrote: : The original plan was for the code in this review to go into both 8 and 7u12. Since 7u12 has a tighter deadline, a possible path would be to include it only in 7u12, but not in 8. For 8 we would then impleme

hg: jdk8/tl/langtools: 8003639: convert lambda testng tests to jtreg and add them

2012-11-20 Thread robert . field
Changeset: d898d9ee352f Author:rfield Date: 2012-11-20 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d898d9ee352f 8003639: convert lambda testng tests to jtreg and add them Reviewed-by: mcimadamore + test/tools/javac/defaultMethodExecution/DefaultMethodRegressio