On 12.12.2012 20:52, Daniel D. Daugherty wrote:
On 12/12/12 9:47 AM, Alan Bateman wrote:
On 12/12/2012 16:36, Daniel D. Daugherty wrote:
For this item:
> test/java/util/logging/LoggingDeadlock4.java
> Test case was simplified to avoid AWT class loading.
Negative test
> re
Changeset: 775b0050144a
Author:chegar
Date: 2012-12-13 09:55 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/775b0050144a
8004925: java/net/Socks/SocksV4Test.java failing on all platforms
Reviewed-by: alanb, dsamersoff
! test/java/net/Socks/SocksV4Test.java
Hi Mandy, David and others,
Here's the updated version of the patch for ReflectionData:
http://dl.dropbox.com/u/101777488/jdk8-tl/JEP-149.c/webrev.02/index.html
I split long lines as proposed by Mandy. I also split reflectionData()
method in two methods, so the fast-path method is smaller and
Hi Peter,
I dropped Joel from the direct cc as this isn't annotation related.
On 13/12/2012 8:13 PM, Peter Levart wrote:
Hi Mandy, David and others,
Here's the updated version of the patch for ReflectionData:
http://dl.dropbox.com/u/101777488/jdk8-tl/JEP-149.c/webrev.02/index.html
I split lo
Just FYI the Profiles forest has been updated to the jdk8-b67 level.
This version includes the initial set of java.util.function APIs from
lambda.
It also restricts profiles builds to linux.
David
Here is new version fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8004928/webrev.02
On 12.12.2012 22:59, Mandy Chung wrote:
On 12/12/12 7:41 AM, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8004928
Summary:
*test/java/io/Serializable/resolve
On 13/12/2012 11:48, Alexey Utkin wrote:
Here is new version fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8004928/webrev.02
This looks good to me and thanks for the confirmation that
LoggingDeadlock4 continues to test what it was meant to test.
Minor comment on ClassRestriction
On 13.12.2012 15:56, Alan Bateman wrote:
On 13/12/2012 11:48, Alexey Utkin wrote:
Here is new version fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8004928/webrev.02
This looks good to me and thanks for the confirmation that
LoggingDeadlock4 continues to test what it was meant t
On 12/13/2012 11:46 AM, David Holmes wrote:
Hi Peter,
I dropped Joel from the direct cc as this isn't annotation related.
On 13/12/2012 8:13 PM, Peter Levart wrote:
Hi Mandy, David and others,
Here's the updated version of the patch for ReflectionData:
http://dl.dropbox.com/u/101777488/jdk8-
Changeset: 682d2d3ccff5
Author:chegar
Date: 2012-12-13 14:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/682d2d3ccff5
8004675: Inet6Address.getHostAddress should use string scope identifier where
available
Summary: ...and some minor stylistic cleanup
Reviewed-by: khazra,
Changeset: c97618a3c8c2
Author:juh
Date: 2012-12-13 09:35 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c97618a3c8c2
7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently
Reviewed-by: vinnie, wetmore
! test/ProblemList.txt
! test/sun/security/pkcs11/ec/TestE
Changeset: ae5d04dbacd6
Author:chegar
Date: 2012-12-13 14:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae5d04dbacd6
8003890: corelibs test scripts should pass TESTVMOPTS
Reviewed-by: chegar, alanb
Contributed-by: Mark Sheppard
! test/com/oracle/net/sanity.sh
! test/com
On 12/13/12 2:35 AM, Alexey Utkin wrote:
On 12.12.2012 20:52, Daniel D. Daugherty wrote:
On 12/12/12 9:47 AM, Alan Bateman wrote:
On 12/12/2012 16:36, Daniel D. Daugherty wrote:
For this item:
> test/java/util/logging/LoggingDeadlock4.java
> Test case was simplified to avoid AWT c
On 12/13/2012 3:48 AM, Alexey Utkin wrote:
Here is new version fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8004928/webrev.02
Looks good. Thanks for the update.
Mandy
I would like to re-start [1] review discussion of the changes to
ForkJoinXXX ( add a default common pool, task tags, and implementation
updates ), and the addition of CountedCompleter, as part of part of JEP
155 [2].
These changes are of course coming form Doug and the JSR 166 EG members.
I
Some notes:
- The Object padding (pad10 - pad1d) in WorkQueue and ForkJoinPool is sensitive
to reference size and compressed OOPS. I was surprised to see Object used
rather than long or int.
- how is getCommonPoolParallelism() different from
commonPool().getParallelism() ? Seems redundant.
-
Hi Daniel,
This looks good. We had some discussion over if there's a difference in
classloading between the original sequence and that of ServiceLoader. I
understand you have the full regression testsuite from SQE. Just would
like to make sure they pass just fine.
Thanks,
Joe
On 12/12/2012
Awesome job!
Thanks David!
Gary
On Dec 4, 2012, at 9:25 PM, David Holmes wrote:
> Just FYI the Profiles forest has been updated to the jdk8-b66 level.
>
> Aside from that, recent changes include:
>
> - javac support for -profile flag
> - keytool is now part of profile compact1
> - Fix for FDS
Hello Lance,
My understanding would be that the signature test
should check that interface method is marked as default method
but do not track the code in its default body
(assuming that the body is not a part of a spec - API javadoc).
(I've confirmed that with the signature test developer)
Tha
Hello,
As with concrete methods on abstract classes, I would expect the
specifications of the default methods to often contain text akin to
"This default implementation does x, y, and z" since if the method is to
be called by subtypes, the self-use patterns in the default method need
to be kn
Hi Joe,
I would agree but if the default implementation is not considered part of the
spec, should it be defined in the javadoc and if so, IMHO a javadoc tag would
be very useful so that we are consistent in at least presentation.
Leonid, thank you for the confirmation.
Best
Lance
On Dec 13,
On 12/12/2012 2:35 AM, Alan Bateman wrote:
On 12/12/2012 09:31, Paul Sandoz wrote:
http://cr.openjdk.java.net/~alanb/8004371/webrev.02/src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.html
Why are the element qualified names compared ignoring case?
I'll leave this to
Good point, Joe.
Those extra assertions for default methods can be checked
by regular API tests separately from signature tests.
Thanks,
-leonid
On 12/13/2012 1:05 PM, Joe Darcy wrote:
Hello,
As with concrete methods on abstract classes, I would expect the
specifications of the default method
Trivial update of max classfile version to 52.
http://cr.openjdk.java.net/~dholmes/8003632/webrev/
Pushing through tl/jdk
Thanks,
David
On Dec 13, 2012, at 6:16 PM, Leonid Arbuzov wrote:
> Good point, Joe.
> Those extra assertions for default methods can be checked
> by regular API tests separately from signature tests.
I am not clear on this. See the message attached from David which ask a
similar question (from the attached
Hi,
I'm working at Google now, but I'd like to revive this patch as a
contribution from Google. At the moment, what's mainly needed is review
for http://bugs.sun.com/view_bug.do?bug_id=7192954, the fix to
Float.parseFloat's rounding behavior, before we can go anywhere with the
patch to optimize B
If those extra statements are normative they can be checked by
conformance tests,
if not normative, those can be checked by implementation-specific unit
tests.
Specification should be clear what is normative and what is not.
Tagging normative requirements in API specs (and in other specs too!)
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
On Dec 13, 2012, at 6:30 PM, David Holmes wrote:
> Trivial update of max classfile version to 52.
>
> http:/
Mandy,
Mostly good -- and nice to see Dependencies getting the full tool treatment.
-- Jon
Archive.java:128
non-localized text: "not found"
ClassFileReader.java:74, ditto similar code in JarFileReader
Will not work for inner classes.
ClassFileReader.java:various
Langtools is (for a while lon
As part of the library lambdafication, this patch adds a forEach default
method to Iterator, and converts remove() into a default method so that
implementations of Iterator no longer have to override remove if they
desire the default behavior, which is to throw an
UnsupportedOperationException.
Changeset: 376d6c1b49e5
Author:jfranck
Date: 2012-12-03 11:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/376d6c1b49e5
8001114: Container annotation is not checked for semantic correctness
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/code/Annotations.jav
Looks good to me.
I didn't know about this file and so I was interested in finding out
more. This file classfile_constants.h doesn't look like a header file
exported from the hotspot repo (I couldn't find it). It's used by hprof
and the old verifier (jdk/src/share/native/common/check_code.h
On 12/13/2012 4:06 PM, Jonathan Gibbons wrote:
Mandy,
Mostly good -- and nice to see Dependencies getting the full tool
treatment.
Thanks for the review, Jon.
-- Jon
Archive.java:128
non-localized text: "not found"
Oh I missed that - will fix it.
ClassFileReader.java:74, ditto simi
Changeset: 8d7323a9d8ed
Author:dholmes
Date: 2012-12-13 21:18 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d7323a9d8ed
8003632: HPROF class file version java.lang.RuntimeException errors
Reviewed-by: mchung, lancea
! src/share/javavm/export/classfile_constants.h
On 14/12/2012 12:03 PM, Mandy Chung wrote:
Looks good to me.
Thanks Mandy.
FYI tested with nsk/hprof suite
I didn't know about this file and so I was interested in finding out
more. This file classfile_constants.h doesn't look like a header file
exported from the hotspot repo (I couldn't fin
This file was added by me, to the jdk repo, mostly for reading class files.
But as I recall (it was a while ago) the idea was that this file would describe
the classfile format for the jdk being released.
As I recall, the hotspot sources never exported anything like this, certainly
not something
Hi Peter,
On 13/12/2012 10:27 PM, Peter Levart wrote:
On 12/13/2012 11:46 AM, David Holmes wrote:
I also found code-paths that evaluated reflectionData() method more than
once for each external call. It's the methods:
private Field[] privateGetDeclaredFields(boolean publicOnly)
and
priva
Hello all;
I have updated the webrev again for hopefully the last time:
http://cr.openjdk.java.net/~mduigou/8004015/3/webrev/
http://cr.openjdk.java.net/~mduigou/8004015/3/specdiff/overview-summary.html
The implementation now uses Primitive.primitiveValue() ie.
Integer.integerValue() rather tha
As a case in point Akhil just asked for this to be reviewed:
http://cr.openjdk.java.net/~akhil/8005051.0/webrev/src/share/classes/java/util/Iterator.java.frames.html
and there is no mention that the remove() implementation actually throws
the exception, nor how forEach does its work.
David
O
Paul,
On 14/12/2012 9:46 AM, Paul Benedict wrote:
Lance,
Good questions. Someone with authority will surely answer, but here's
my armchair opinion...
If the Javadoc is to specify how the default method executes, than
that would naturally infer all default implementations must have a
stated con
HI Mike,
On 14/12/2012 3:24 PM, Mike Duigou wrote:
Hello all;
I have updated the webrev again for hopefully the last time:
http://cr.openjdk.java.net/~mduigou/8004015/3/webrev/
http://cr.openjdk.java.net/~mduigou/8004015/3/specdiff/overview-summary.html
The implementation now uses Primitive.p
Updated webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/webrev.04/
The binary name of an inner class has a '$' and so
ClassFileReader.java:74 should do it. Once the jdeps change is pulled
down to the profiles forest, I may make the change there to use the API
as javac uses.
42 matches
Mail list logo
