Re: JDK-8010495: Update JAXP NetBeans project - add support for generating javadoc

2013-03-26 Thread Daniel Fuchs
Hi Joe, On 3/25/13 5:52 PM, huizhe wang wrote: On 3/25/2013 9:35 AM, Daniel Fuchs wrote: On 3/25/13 5:20 PM, huizhe wang wrote: Hi Daniel, Thanks for doing this. JAXP doesn't have these packages: java/, org/ietf/jgss/, and org/omg/. Since this is the jaxp repo, it would be fine if only

[OpenJDK 2D-Dev] sun.java2D.pisces big memory usage (waste ?)

2013-03-26 Thread Laurent Bourgès
Dear all, First I joined recently the openJDK contributors, and I plan to fix java2D pisces code in my spare time. I have a full time job on Aspro2: http://www.jmmc.fr/aspro; it is an application to prepare astronomical observations at VLTI / CHARA and is very used in our community (200 users):

arrayLength argument of MethodHandle.asCollector() and failing JCK test 'asCollectorIAE01'

2013-03-26 Thread Volker Simonis
Hi, while running JCK test for our PPC port I realized that the test 'asCollectorIAE01' which checks valid and invalid 'arrayLength' arguments to MethodHandle.asCollector() fails for the current 7u/jdk and jdk8/jdk sources. Further investigations revealed that the failure is due to the change

hg: jdk8/tl/nashorn: 4 new changesets

2013-03-26 Thread sundararajan . athijegannathan
Changeset: ae4ef3102d9c Author:lagergren Date: 2013-03-25 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae4ef3102d9c 8017010: index evaluation to a temporary location for index operator much change temporaries to slots, but never scoped vars Reviewed-by: hannesw,

Re: JDK-8010495: Update JAXP NetBeans project - add support for generating javadoc

2013-03-26 Thread huizhe wang
On 3/26/2013 2:04 AM, Daniel Fuchs wrote: Hi Joe, On 3/25/13 5:52 PM, huizhe wang wrote: On 3/25/2013 9:35 AM, Daniel Fuchs wrote: On 3/25/13 5:20 PM, huizhe wang wrote: Hi Daniel, Thanks for doing this. JAXP doesn't have these packages: java/, org/ietf/jgss/, and org/omg/. Since this

Review JDK-8010837 - TEST_BUG: java/io/FileInputStream/LargeFileAvailable.java fails intermittently

2013-03-26 Thread Dan Xu
Hi All, In the old JVM function, os::available, it could return negative values because lseek() allows the file offset to be set beyond the end of a file. In the previous change of removing jvm functions, I wasn't aware of that and regardnegative values as invalid and return 0, which causes

hg: jdk8/tl/jdk: 2 new changesets

2013-03-26 Thread martinrb
Changeset: 3b56ef8e1ce1 Author:martin Date: 2013-03-26 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b56ef8e1ce1 8007905: To add a system property to create zip file without using ZIP64 end table when entry count 64k Summary: Provide a system property to inhibit

Re: zip64 compatibility problems

2013-03-26 Thread Martin Buchholz
Submitted. On Thu, Mar 21, 2013 at 8:05 AM, Xueming Shen xueming.s...@oracle.comwrote: Martin, 8007905 has been approved. On 2/10/13 10:30 PM, Xueming Shen wrote: 8007905. But you will have to hold the push. I will send it through the CCC. -Sherman On 2/10/2013 7:59 PM, Martin

Re: Please review: surrogate fiddle

2013-03-26 Thread Martin Buchholz
On Wed, Mar 20, 2013 at 9:46 PM, Masayoshi Okutsu masayoshi.oku...@oracle.com wrote: This fix is fine with me. Submitted.

Re: 8010309 : PlatformLogger: isLoggable performance / waste due to HashMapInteger, Level leads to Integer allocations (boxing)

2013-03-26 Thread Mandy Chung
Hi Peter, http://dl.dropbox.com/u/101777488/jdk8-tl/PlatformLogger/webrev.08/index.html I'm glad that you observe similar performance improvement without the need of method handles. I reviewed this version and realize that the map from j.u.l.Level object to LevelEnum can be removed entirely.

JDK 8 RFR for JDK-7185456 : (ann) Optimize Annotation handling in java/sun.reflect.* code for small number of annotationsC

2013-03-26 Thread Joe Darcy
Hello, Please review this refactoring of how annotations objects are created: JDK-7185456 : (ann) Optimize Annotation handling in java/sun.reflect.* code for small number of annotationsC http://cr.openjdk.java.net/~darcy/7185456.0/ In brief, an annotation object is backed by a hash

Re: JDK 8 RFR for JDK-7185456 : (ann) Optimize Annotation handling in java/sun.reflect.* code for small number of annotationsC

2013-03-26 Thread Mike Duigou
This looks fine to me. Nice little optimization (which is no doubt repeated thousands of times for significant wins). Mike On Mar 26 2013, at 15:43 , Joe Darcy wrote: Hello, Please review this refactoring of how annotations objects are created: JDK-7185456 : (ann) Optimize Annotation

RFR JDK-7143928 : (coll) Optimize for Empty ArrayList and HashMap

2013-03-26 Thread Mike Duigou
Hello all; This is a review for optimization work that came out of internal analysis of Oracle's Java applications. It's based upon analysis that shows that in large applications as much as 10% of maps and lists are initialized but never receive any entries. A smaller number spend a large

hg: jdk8/tl/langtools: 7041251: Use j.u.Objects utility methods in langtools

2013-03-26 Thread joe . darcy
Changeset: 330b35b27e68 Author:darcy Date: 2013-03-26 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/330b35b27e68 7041251: Use j.u.Objects utility methods in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/Pair.java !

Re: RFR-8008118

2013-03-26 Thread Martin Buchholz
8008118 does not appear to be public - could we fix that? Here is my alternative set of perfectionist changes: # Cleanup declaration of environ http://cr.openjdk.java.net/~martin/webrevs/openjdk8/environ # Fix PATH handling http://cr.openjdk.java.net/~martin/webrevs/openjdk8/pathv/ that could

hg: jdk8/tl/langtools: 7059170: Assume availablility of URLClassLoader.close

2013-03-26 Thread joe . darcy
Changeset: 33b6a52f0037 Author:darcy Date: 2013-03-26 18:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33b6a52f0037 7059170: Assume availablility of URLClassLoader.close Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java -

Re: Review JDK-8010837 - TEST_BUG: java/io/FileInputStream/LargeFileAvailable.java fails intermittently

2013-03-26 Thread Mandy Chung
Hi Dan, On 3/26/2013 12:29 PM, Dan Xu wrote: Hi All, In the old JVM function, os::available, it could return negative values because lseek() allows the file offset to be set beyond the end of a file. In the previous change of removing jvm functions, I wasn't aware of that and regard

RFR: Optimize StringBuilder.append(null)

2013-03-26 Thread Martin Buchholz
Oops: I forgot to include core-libs-dev Forwarded conversation Subject: RFR: Optimize StringBuilder.append(null) From: *Martin Buchholz* marti...@google.com Date: Tue, Mar 26, 2013 at 1:54 PM To: Xueming Shen xueming.s...@oracle.com, Masayoshi Okutsu

Re: RFR-8008118

2013-03-26 Thread Christos Zoulas
On Mar 26, 6:13pm, marti...@google.com (Martin Buchholz) wrote: -- Subject: Re: RFR-8008118 | Here is my alternative set of perfectionist changes: :-) | # Fix PATH handling | http://cr.openjdk.java.net/~martin/webrevs/openjdk8/pathv/ LGTM, only question is why error from one allocation throws

Re: RFR-8008118

2013-03-26 Thread Martin Buchholz
Of course, I made a (harmless) mistake in xstrdup. There is no need to throw since NEW does that already. +static char* +xstrdup(JNIEnv *env, const char *s) +{ +size_t size = strlen(s) + 1; +char *p = NEW(char, size); +if (p != NULL) +memcpy(p, s, size); +return p; +} +

Re: RFR-8008118

2013-03-26 Thread Martin Buchholz
While on the perfectionist path, I couldn't take the fact that initIDs hasn't initted any IDs in years, so I've renamed it to plain init.

Re: RFR JDK-7143928 : (coll) Optimize for Empty ArrayList and HashMap

2013-03-26 Thread Brian Goetz
What percentage of the empty lists are default-sized? I suspect it is large, in which case we could apply this trick only for the default-sized lists, and eliminate the extra field. On Mar 26, 2013, at 5:25 PM, Mike Duigou wrote: Hello all; This is a review for optimization work that