Changeset: 6cffcd15a17e
Author:jfranck
Date: 2013-09-09 09:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6cffcd15a17e
8022260: Rename javac.code.Annotations to javac.code.SymbolMetadata
Reviewed-by: jfranck, jjg
Contributed-by: Andreas Lundblad
- src/share/classes
On 09/09/2013 04:28, David Holmes wrote:
:
Also:
test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so
I know this already exist but I thought binaries were disallowed in
the open repo?
Right, we don't want binary files checked in. The test needs to
On 2013-09-06 18:47, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/00315
Changeset: 4afdf10de648
Author:dfuchs
Date: 2013-09-09 13:59 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4afdf10de648
8023168: Cleanup LogManager class initialization and LogManager/LoggerContext
relationship
8021003: java/util/logging/Logger/getGlobal/TestGetGlobalConcur
Changeset: 02064634bc88
Author:msheppar
Date: 2013-09-06 15:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02064634bc88
8023326: [TESTBUG] java/net/CookieHandler/LocalHostCookie.java misplaced
try/finally
Summary: amended test to be more robust to set of potential excepti
Hi David,
I found even on my VirturalBox machine it frequently came close to the
.1ms target
and failed in one case. Raising the time was to reduce/prevent
intermittent failures.
Are other timing tests also sensitive to the Xcomp, how should tests be
written
to be insensitive to that JVM o
Hi Peter,
The possible wrap-around caused by crossing midnight is handled by Math.max
so a retry is not needed.
Math.abs(test.toNanoOfDay() - expected.toNanoOfDay())
Thanks, Roger
On 9/9/2013 2:14 AM, Peter Levart wrote:
On 09/06/2013 07:58 PM, roger riggs wrote:
Please review for two cor
On Sep 6, 2013, at 4:56 PM, Alan Bateman wrote:
> On 06/09/2013 12:08, Paul Sandoz wrote:
>> On Sep 2, 2013, at 3:24 PM, Paul Sandoz wrote:
>>
>> :
>>
>>> Here is the fix in the lambda repo which can be applied to tl:
>>>
>>> http://hg.openjdk.java.net/lambda/lambda/jdk/rev/b73937e96ae0
>>>
On 2013-09-08, at 10:39 PM, David Holmes wrote:
> On 7/09/2013 1:28 AM, Alan Bateman wrote:
>> On 06/09/2013 15:18, David Chase wrote:
>>> webrev: http://cr.openjdk.java.net/~drchase/8022701/webrev.00/
>>>
>>> Question #2, what's the best way to write a jtreg test suite that
>>> requires incomp
Hi Peter,
Thanks for this, please add a "@bug 8011940" tag to your test. IMO you don't
need a re-review for that. Otherwise looks good.
We still need a Reviewer, Chris, you reviewed a previous version, can you look
at this one too?
cheers
/Joel
On 27 aug 2013, at 15:00, Peter Levart wrote:
Stuart,
Thanks for clarifying. I agree with minimization effort and your
statements below.
So the this looks all fine !
Olivier
Stuart Marks said on date 9/7/2013 2:31 AM:
Hi Olivier,
Thanks for looking at this. Part of the minimization effort (see my
reply to Alan) showed that Activatio
On 09/09/2013 03:12 PM, roger riggs wrote:
Hi Peter,
The possible wrap-around caused by crossing midnight is handled by
Math.max
so a retry is not needed.
Math.abs(test.toNanoOfDay() - expected.toNanoOfDay())
Hi Roger,
In case there is a wrap-around, the 'diff' is much more than 500,000,0
Hi David,
Hi Kumar,
This is still dead code in
src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
String os_arch = System.getProperty("os.arch");
Ah, I will take care of it. Thanks for spotting this.
Also:
test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/sol
On 09/09/2013 16:12, Kumar Srinivasan wrote:
Alan, are the nio changes acceptable? Let me know if you need more
time to go over all
the changes.
It looks fine (sorry I should have made that clearer). I skimmed over
the other tests too (the launcher tests in particular) and don't see any
oth
On Sep 9, 2013, at 3:35 PM, Paul Sandoz wrote:
>
> On Sep 6, 2013, at 4:56 PM, Alan Bateman wrote:
>
>> On 06/09/2013 12:08, Paul Sandoz wrote:
>>> On Sep 2, 2013, at 3:24 PM, Paul Sandoz wrote:
>>>
>>> :
>>>
Here is the fix in the lambda repo which can be applied to tl:
ht
On 09/09/2013 05:14 PM, Peter Levart wrote:
On 09/09/2013 03:12 PM, roger riggs wrote:
Hi Peter,
The possible wrap-around caused by crossing midnight is handled by
Math.max
so a retry is not needed.
Math.abs(test.toNanoOfDay() - expected.toNanoOfDay())
Hi Roger,
In case there is a wrap-
Nick,
Do you have any information to some of the questions I asked below that
can help the API discussion?
We need to decide on the permission check and also the hotspot change
has to be integrated and the jdk change will need to wait until it shows
in a promoted build. Schedule-wise, to ma
Changeset: a4b9a8859e58
Author:vromero
Date: 2013-09-09 16:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4b9a8859e58
8024154: Fix for 8016177: structural most specific and stuckness breaks 6
langtools tests
Reviewed-by: jjg, jfranck
! test/tools/javac/lambda/Meth
Hi Joel,
The fix is ok for getMethods(), but I think the getMethod(String name,
Class... parameterTypes) should also be fixed. Currently the
following code:
public class StaticInterfaceMethodTest {
public interface A {
static void m() {}
}
public interface B extends A {
On 09/08/2013 09:34 PM, Mandy Chung wrote:
On 9/4/2013 6:02 PM, David M. Lloyd wrote:
This seems reasonable on the surface but falls over once you capture
the caller for more than one purpose. For example, say a logging
framework captures the caller for the purpose of supplementing log
inform
Hi
Pleaser review fix for 8009411 : getMethods should not inherit static methods
from interfaces
The issue is that since we added static methods to interfaces those have
erroneously been reflected in getMethods of implementing classes. This fix
filters out static interface methods from superi
Hi Peter,
You are correct, thanks for noticing this. Also after reading your mail I
looked through the test in test/java/lang/refledt/DefaultStaticTest/ and just
realized the tests doesn't cover getMethod() at all. So this change needs more
tests as well.
I'll post a new webrev later this week
Hi Joel,
Thanks for reviewing.
On 09/09/2013 04:25 PM, Joel Borggrén-Franck wrote:
Hi Peter,
Thanks for this, please add a "@bug 8011940" tag to your test. IMO you don't
need a re-review for that. Otherwise looks good.
I'll do that. I just didn't know whether tagging with bug-ID is meant
Take this lightly informed suggestion with a grain of salt, but why not, for
purposes of performance and security,
change the logging-specific getCallerClass methods so that their "class"
references are instead wrapped in some sort of proxy object that only forwards
certain operations quickly wi
Changeset: 7ae169639485
Author:sundar
Date: 2013-09-05 21:17 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7ae169639485
8024255: When a keyword is used as object property name, the property can not
be deleted
Reviewed-by: jlaskey, lagergren
! src/jdk/nashorn/internal/p
After some thought the below idea seems not good. Currently j.l.Class
objects can be used to "transfer" privilige from code that can obtain
them to code that can't (like MHs for example). So doing what I proposed
would disable this ability.
Regards, Peter
Hi,
This is a good idea. It got me
On 09/09/2013 07:02 PM, David Chase wrote:
Take this lightly informed suggestion with a grain of salt, but why not, for
purposes of performance and security,
change the logging-specific getCallerClass methods so that their "class"
references are instead wrapped in some sort of proxy object tha
On 9 sep 2013, at 19:00, Joel Borggrén-Franck wrote:
> The issue is that since we added static methods to interfaces those have
> erroneously been reflected in getMethods of implementing classes. This fix
> filters out static interface methods from superinterfaces when adding
> methods. I hav
Changeset: be0bcd6a904e
Author:juh
Date: 2013-09-09 10:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be0bcd6a904e
8024432: Fix doclint issues in java.security
Reviewed-by: darcy, mullan
! src/share/classes/java/security/AccessController.java
! src/share/classes/java/secu
Hi Peter,
Right, max doesn't solve the issue but I'm not keen on a test that retries
until it gets a better answer.
Adding nanosPerDay if the difference comes out negative would adjust
for the crossing of midnight and not require looping on a more complex
test condition.
The longish delay in th
Changeset: 67c5110c60fe
Author:emc
Date: 2013-09-09 17:11 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67c5110c60fe
8015322: Javac template test framework
Summary: Putback of the javac template test framework from the Lambda repository
Reviewed-by: jjg
Contributed-by:
Looks like good changes all around. I didn't see any "breaking" changes.
Some of the javadoc examples ( blocks) are wrapped at 80 columns. I have
been allowing them to go wider (110 columns roughly) so that they don't end up
being very narrow in the HTML output.
Mike
On Sep 6 2013, at 23:18
On 09/09/2013 07:27 PM, Joel Borggrén-Franck wrote:
On 9 sep 2013, at 19:00, Joel Borggrén-Franck wrote:
The issue is that since we added static methods to interfaces those have
erroneously been reflected in getMethods of implementing classes. This fix
filters out static interface methods fr
Changeset: f4efd6ef6e80
Author:emc
Date: 2013-09-09 16:26 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f4efd6ef6e80
8022322: Reject default and static methods in annotation
Summary: Causes javac to reject static and default method declarations inside
an annotation
Re
Hello,
Please review this patch which updates the javadoc comments for
java.lang.reflect.Executable.getParameterAnnotations(). The patch
corrects the javadocs to describe the actual behavior of this method.
It also refers users to the new java.lang.reflect.Parameter API.
See comments on the bug
On 9/9/13 10:02 AM, David Chase wrote:
Take this lightly informed suggestion with a grain of salt, but why not, for
purposes of performance and security,
change the logging-specific getCallerClass methods so that their "class"
references are instead wrapped in some sort of proxy object that onl
On 9/9/13 10:01 AM, David M. Lloyd wrote:
I'm not sure if we can be very certain about the depth in a runtime
environment (non-debugging) unless it requires all VM implementation to
support a reliable way to return a frame at a given depth.
The stack trace is not guaranteed to contain all stack
Changeset: 6731ea9123f2
Author:smarks
Date: 2013-09-09 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6731ea9123f2
8023447: change specification to allow RMI activation to be optional
Reviewed-by: darcy, alanb, olagneau
! src/share/classes/java/rmi/activation/Activatab
Responding to both of your messages at once.
On Sep 5 2013, at 21:49 , David Holmes wrote:
> Hi Mike,
>
> On 6/09/2013 2:58 AM, Mike Duigou wrote:
>> Hello all;
>>
>> A very small spec clarification for review. The spec clarification ensures
>> that the behaviour of the default method can
On 09/09/2013 04:56 PM, Mandy Chung wrote:
On 9/9/13 10:01 AM, David M. Lloyd wrote:
I'm not sure if we can be very certain about the depth in a runtime
environment (non-debugging) unless it requires all VM implementation to
support a reliable way to return a frame at a given depth.
The stack t
Changeset: 77d395862700
Author:jlahoda
Date: 2013-09-09 23:13 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/77d395862700
8019521: Enhanced rethrow disabled in lambdas
Summary: Fixing effectively final detection inside lambdas, small cleanup
related to thrown types det
Hi Roger,
On 9/09/2013 10:48 PM, roger riggs wrote:
Hi David,
I found even on my VirturalBox machine it frequently came close to the
.1ms target
and failed in one case. Raising the time was to reduce/prevent
intermittent failures.
Are other timing tests also sensitive to the Xcomp, how should
Changeset: 7439356a7dc5
Author:jjg
Date: 2013-09-09 17:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7439356a7dc5
8006972: jtreg test fails:
test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java
Reviewed-by: darcy
!
test/tools/javac
Changeset: f80b8af9c218
Author:xuelei
Date: 2013-09-09 19:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f80b8af9c218
802: Change to use othervm mode of tests in SSLEngineImpl
Reviewed-by: mullan
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/Clos
Typo:
+ assertTrue(diff < 1); // less than 0.5 secs
David
On 10/09/2013 5:42 AM, roger riggs wrote:
Hi Peter,
Right, max doesn't solve the issue but I'm not keen on a test that retries
until it gets a better answer.
Adding nanosPerDay if the difference comes out negative wou
On 09/09/2013 09:42 PM, roger riggs wrote:
Hi Peter,
Right, max doesn't solve the issue but I'm not keen on a test that
retries
until it gets a better answer.
Hi Roger,
If java.time logic is correct, it should only ever retry once when
roll-over or DST jump-back happens, so the test could
46 matches
Mail list logo
