Another idea to solve the long-standing issue with checked IOExceptions in
close() calls is to
add a method to java.io.Closeable, now possible thanks to default methods:
/**
* Invokes #close() and wraps IOExceptions with UncheckedIOExceptions.
*/
default void closeUnchecked() {
try { close();
Hi,
Please find below a webrev for:
8028185: XMLFormatter.format emits incorrect year
https://bugs.openjdk.java.net/browse/JDK-8028185
The fix is trivial:
http://cr.openjdk.java.net/~dfuchs/webrev_8028185/webrev.00/
best regards,
-- daniel
Changeset: d6195774dd1f
Author:egahlin
Date: 2013-11-19 11:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6195774dd1f
8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on
ProblemList.txt
Reviewed-by: alanb
! test/ProblemList.txt
Is this just changed? jdk8b118 shows 1 and now it's 0.
Thanks
Max
On 11/19/13, 19:48, Weijun Wang wrote:
Is this just changed? jdk8b118 shows 1 and now it's 0.
Typo. b114.
Thanks
Max
On 19/11/2013 11:48, Weijun Wang wrote:
Is this just changed? jdk8b118 shows 1 and now it's 0.
b118 or your own build? I wonder if you have 6559590 but not the un-do.
-Alan.
b114: 1
my (previous) own build: 0
I fetched changes for JDK-8028321 (the un-do) and now it's back to 1. So
we are keeping this compatibility even if it does not look correct?
Thanks
Max
On 11/19/13, 20:03, Alan Bateman wrote:
On 19/11/2013 11:48, Weijun Wang wrote:
Is this just changed?
On 19/11/2013 10:23, Daniel Fuchs wrote:
Hi,
Please find below a webrev for:
8028185: XMLFormatter.format emits incorrect year
https://bugs.openjdk.java.net/browse/JDK-8028185
The fix is trivial:
http://cr.openjdk.java.net/~dfuchs/webrev_8028185/webrev.00/
This one is a good reminder as to
On 19/11/2013 12:09, Weijun Wang wrote:
b114: 1
my (previous) own build: 0
I fetched changes for JDK-8028321 (the un-do) and now it's back to 1.
So we are keeping this compatibility even if it does not look correct?
I think it will require careful analysis to see what is possible (as
there
Looking to add two helper methods to the OpenJDK test libraries. I'm
looking to clean up a closed src test case but these methods should be
of use for future testcase development.
webrev : http://cr.openjdk.java.net/~coffeys/webrev.8028583/webrev/
bug report :
Hi,
Here is one possible solution for the issue JDK-8028094.
http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev/
I am not sure pkill is available in all Unix flavor at /usr/bin directory,
but it is present in Solaris and OEL 6. I have tested on Solaris
and OEL and sleep is no longer
Changeset: 2e574350a2b6
Author:alanb
Date: 2013-11-19 14:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e574350a2b6
8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests
Reviewed-by: dholmes, sla, tbell
! test/Makefile
Changeset: 9937f406e27e
Author:alanb
Date: 2013-11-19 14:11 +
URL: http://hg.openjdk.java.net/jdk8/tl/rev/9937f406e27e
8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests
Reviewed-by: dholmes, sla, tbell
! make/jprt.properties
! test/Makefile
Looks good to me Sean, thanks for adding deleteFileIfExistsWithRetry.
Trivially, you can replace oneLoopRun with a do {} while loop.
-Chris.
On 11/19/2013 01:31 PM, Seán Coffey wrote:
Looking to add two helper methods to the OpenJDK test libraries. I'm
looking to clean up a closed src test
Look ok to me Balchandra. I can sponsor this for you.
-Chris.
On 11/19/2013 02:07 PM, Balchandra Vaidya wrote:
Hi,
Here is one possible solution for the issue JDK-8028094.
http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev/
I am not sure pkill is available in all Unix flavor at /usr/bin
Hi folks,
Looking for a quick review for a test failure we're encountering.
Seemingly no bar is too high for our test infrastructure. Hopefully this
will put this particular failure to rest.
http://cr.openjdk.java.net/~robm/8022206/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8022206
Thanks for review Chris. Will take your do while loop suggestion on
board and push changes.
regards,
Sean.
On 19/11/13 14:19, Chris Hegarty wrote:
Looks good to me Sean, thanks for adding deleteFileIfExistsWithRetry.
Trivially, you can replace oneLoopRun with a do {} while loop.
-Chris.
On
The test tools/jar/JarEntryTime.java has been failing intermittently
(but very rarely) for some time. The failure seems to be that the
extracted time it out by more than 10 seconds compared to the original
file time but it isn't always so (esp. when the test runs in a fraction
of a second).
Looks good to me Alan. It will be nice to see why this test is actually
failing.
-Chris.
On 11/19/2013 02:43 PM, Alan Bateman wrote:
The test tools/jar/JarEntryTime.java has been failing intermittently
(but very rarely) for some time. The failure seems to be that the
extracted time it out by
Changeset: d1bb85f0a45a
Author:coffeys
Date: 2013-11-19 14:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1bb85f0a45a
8028583: Add helper methods to test libraries
Reviewed-by: chegar
! test/java/rmi/testlibrary/TestLibrary.java
!
The change looks ok to me. If for no reason other than to eliminate the
timeout if this tests fails again in the future.
-Chris.
On 11/19/2013 02:28 PM, Rob McKenna wrote:
Hi folks,
Looking for a quick review for a test failure we're encountering.
Seemingly no bar is too high for our test
Thanks Chris.
Regards
Balchandra
On 19/11/2013 14:23, Chris Hegarty wrote:
Look ok to me Balchandra. I can sponsor this for you.
-Chris.
On 11/19/2013 02:07 PM, Balchandra Vaidya wrote:
Hi,
Here is one possible solution for the issue JDK-8028094.
On 19/11/2013 14:28, Rob McKenna wrote:
Hi folks,
Looking for a quick review for a test failure we're encountering.
Seemingly no bar is too high for our test infrastructure. Hopefully
this will put this particular failure to rest.
http://cr.openjdk.java.net/~robm/8022206/webrev.01/
Hi Rob,
May I suggest changing System.out.println in Basic.fail into
System.err.println? Or possibly printing the message on both
out and err?
This would ensure that the error message appears on System err before
the stack trace - which might be better for diagnosis.
-- daniel
On 11/19/13
Changeset: 40462a41b41b
Author:ksrini
Date: 2013-11-19 07:10 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40462a41b41b
8023978: [TEST_BUG] launcher tests must exclude platforms without server vm
Reviewed-by: dholmes, mchung
! test/tools/launcher/ExecutionEnvironment.java
Changeset: cfbee8ee71bf
Author:bvaidya
Date: 2013-11-19 15:31 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfbee8ee71bf
8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves sleep
processes behind
Reviewed-by: chegar
!
Changeset: e8daf5a83e42
Author:vinnie
Date: 2013-11-19 15:39 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8daf5a83e42
8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to
${test.src}
Reviewed-by: alanb, weijun
!
Hope this is a simple one. This issue is a rare intermittent one :
- port 48250 is free
- exported registry: RegistryImpl[UnicastServerRef [liveRef:
[endpoint:[10.169.79.100:48250](local),objID:[0:0:0, 0
- port 48250 is in use
- unexported registry
java.net.BindException: Address already
Yes, I have to pull it back due to the compatibility concern. It appears
the jdk source code itself has
couple places depending on this incorrect behavior. The typical usage
is .split(...)[0], in which the
code tries to access the 0th element without even checking the return
length. I may
Changeset: 63b696dafc8a
Author:robm
Date: 2013-11-19 15:36 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63b696dafc8a
8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java
Reviewed-by: chegar, alanb
! test/java/lang/ProcessBuilder/Basic.java
Looks ok to me.
-Chris.
On 11/19/2013 03:58 PM, Seán Coffey wrote:
Hope this is a simple one. This issue is a rare intermittent one :
- port 48250 is free
- exported registry: RegistryImpl[UnicastServerRef [liveRef:
[endpoint:[10.169.79.100:48250](local),objID:[0:0:0, 0
- port 48250 is in
Changeset: f2ccd3530476
Author:coffeys
Date: 2013-11-19 16:22 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ccd3530476
8016728: TEST_BUG:
test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing
intermittently
Reviewed-by: chegar
!
On Nov 19, 2013, at 4:50 PM, Louis Wasserman lowas...@google.com wrote:
Is there a convenient way of building a Spliterator SORTED by a given
Comparator, from, say, an array?
Unfortunately not. There are no factory methods in j.u.Splitrerators that
accept Comparator as a parameter, and as
Hi folks,
Running this test with fastdebug binaries results in a few warning
messages getting lumped into the commandOutput. I've decided to filter
these test wide.
https://bugs.openjdk.java.net/browse/JDK-6703075
http://cr.openjdk.java.net/~robm/6703075/webrev.01/
-Rob
On 11/19/13 2:23 AM, Daniel Fuchs wrote:
Hi,
Please find below a webrev for:
8028185: XMLFormatter.format emits incorrect year
https://bugs.openjdk.java.net/browse/JDK-8028185
The fix is trivial:
http://cr.openjdk.java.net/~dfuchs/webrev_8028185/webrev.00/
Looks good. Nit: the test can
Changeset: 79e975dfeb8a
Author:michaelm
Date: 2013-11-19 17:49 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79e975dfeb8a
8028581: [TESTBUG] java/net/Socket/LingerTest.java failing
Reviewed-by: alanb
! test/java/net/Socket/LingerTest.java
Hello all!
Would you please help review a fix for the bug?
https://bugs.openjdk.java.net/browse/JDK-6968459
It was reported that creating new InitialLdapContext() can fail with
javax.naming.NamingException: LDAP response read timed out, timeout
used:3ms, even though the specified timeout
Hello all!
Would you please help review a fix for the bug?
https://bugs.openjdk.java.net/browse/JDK-6968459
It was reported that creating new InitialLdapContext() can fail with
javax.naming.NamingException: LDAP response read timed out, timeout
used:3ms, even though the specified
Changeset: 5aa853ca08a8
Author:kizune
Date: 2013-11-19 22:05 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aa853ca08a8
8027900: pack200 option is broken due to the incorrect makefile definition for
its driver
Reviewed-by: ksrini, ihse
! make/CompileLaunchers.gmk
On 11/19/13 6:40 PM, Mandy Chung wrote:
On 11/19/13 2:23 AM, Daniel Fuchs wrote:
Hi,
Please find below a webrev for:
8028185: XMLFormatter.format emits incorrect year
https://bugs.openjdk.java.net/browse/JDK-8028185
The fix is trivial:
Changeset: f8b24e1a609e
Author:vinnie
Date: 2013-11-19 17:55 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b24e1a609e
8015571: OCSP validation fails if ocsp.responderCertSubjectName is set
Reviewed-by: mullan, xuelei
!
Changeset: 48c61808374f
Author:mchung
Date: 2013-11-19 10:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48c61808374f
8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from
ProblemList.txt
Reviewed-by: sla
! test/ProblemList.txt
Changeset: 3f47e393e1dd
Author:rriggs
Date: 2013-11-19 13:20 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f47e393e1dd
8028141:
test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java
failing again
Summary: Correct to use the test.class.path
Changeset: f42a22e2b2cd
Author:kizune
Date: 2013-11-19 22:14 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f42a22e2b2cd
6726154: javadoc generated with incorrect version in comment
Reviewed-by: jjg, bpatel, erikj, tbell
! make/BuildLangtools.gmk
!
Hi,
Attachments are stripped. Please post on cr.openjdk.java.net (get a
colleague to host this if you don't have an account yet.)
Thanks,
David
On 19/11/2013 4:12 PM, srikalyan chandrashekar wrote:
Hi all, I am working on bug JDK-6772009
https://bugs.openjdk.java.net/browse/JDK-6772009 .
Hi All,
We have java/io/pathNames/GeneralWin32.java testcase to do the general
exhaustive test of pathname handling on windows. I am adding a new test
GeneralSolaris.java to test the pathname handling in unix-like
platforms. In the changes, I also make sure the test can run
successfully in
Changeset: 67d742c75971
Author:dfuchs
Date: 2013-11-19 20:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67d742c75971
8028185: XMLFormatter.format emits incorrect year
Summary: Fixes a regression where the year in the date was increased by 1900.
Reviewed-by: alanb, mchung
The changes seem OK. I did not run the tests though
On Nov 19, 2013, at 2:08 PM, Dan Xu wrote:
Hi All,
We have java/io/pathNames/GeneralWin32.java testcase to do the general
exhaustive test of pathname handling on windows. I am adding a new test
GeneralSolaris.java to test the pathname
Changeset: 19ff80da8283
Author:yan
Date: 2013-11-18 17:00 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19ff80da8283
8028049: Tidy warnings cleanup for packages java.nio/java.io
Reviewed-by: alanb, darcy
Contributed-by: Sergey Lugovoy sergey.lugo...@oracle.com
!
Thanks.
I will look back in hotspot.
Yumin
On 11/12/2013 6:25 AM, Joel Borggren-Franck wrote:
Hi Yumin,
Basically this is due to a difference in declaring class for a Method
representing a default method vs a normal Method.
On 2013-11-11, Yumin Qi wrote:
Hi, Joel
This bug is a SQE
Hi,
Here is one possible solution for the issue JDK-8028094.
http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev/
I am not sure pkill is available in all Unix flavor at /usr/bin directory,
but it is present in Solaris and OEL 6. I have tested on Solaris
and OEL and sleep is no longer
Hi, Joel
This bug is a SQE testing bug, see
https://bugs.openjdk.java.net/browse/JDK-8027734
https://bugs.openjdk.java.net/browse/JDK-8027734
I have commented with the exception stacktrace.
It only fails when defmeth set call through reflection and passed
with other two modes: -mode
On 19/11/2013 16:46, Rob McKenna wrote:
Hi folks,
Running this test with fastdebug binaries results in a few warning
messages getting lumped into the commandOutput. I've decided to filter
these test wide.
https://bugs.openjdk.java.net/browse/JDK-6703075
Hi,
Please find below a fix for:
8005202 - java/util/logging/CheckLockLocationTest.java fail on solars_10
This bug complains that java/util/logging/CheckLockLocationTest.java
has been seen failing on a solaris 10 machine, with message:
java.lang.RuntimeException: Test failed: should not have
On 19/11/2013 19:08, Dan Xu wrote:
Hi All,
We have java/io/pathNames/GeneralWin32.java testcase to do the general
exhaustive test of pathname handling on windows. I am adding a new
test GeneralSolaris.java to test the pathname handling in unix-like
platforms. In the changes, I also make sure
On 11/19/2013 11:35 AM, Daniel Fuchs wrote:
I am therefore proposing to add an additional check in the test's
setUp() method, in order to verify that the directory is indeed
not writable.
It may be useful to print the owner of the directory in case if it's
running with root permission.
On 11/19/13 9:04 PM, Mandy Chung wrote:
On 11/19/2013 11:35 AM, Daniel Fuchs wrote:
I am therefore proposing to add an additional check in the test's
setUp() method, in order to verify that the directory is indeed
not writable.
It may be useful to print the owner of the directory in case
On 11/19/2013 12:12 PM, Daniel Fuchs wrote:
On 11/19/13 9:04 PM, Mandy Chung wrote:
On 11/19/2013 11:35 AM, Daniel Fuchs wrote:
I am therefore proposing to add an additional check in the test's
setUp() method, in order to verify that the directory is indeed
not writable.
It may be useful
Hello all!
May I have a review for the improvement contributed by Martin Buchholz?
https://bugs.openjdk.java.net/browse/JDK-8027348
First, it the change performs the code cleanup, and second it makes the
test much faster.
This should also help to resolve the issue with the current version of
Hi Joel,
The change looks good; approved to go back.
Thanks,
-Joe
On 11/15/2013 04:26 AM, Joel Borggren-Franck wrote:
Hi
Please review this javadoc clarification for j.l.annnotation.Target and
j.l.annotation.ElementType as part of the type annotations work.
Webrev:
Hi,
I have modified the test to print the user name as well:
http://cr.openjdk.java.net/~dfuchs/webrev_8005202/webrev.01/
-- daniel
On 11/19/13 9:26 PM, Mandy Chung wrote:
On 11/19/2013 12:12 PM, Daniel Fuchs wrote:
On 11/19/13 9:04 PM, Mandy Chung wrote:
On 11/19/2013 11:35 AM, Daniel
On 11/19/2013 12:58 PM, Daniel Fuchs wrote:
Hi,
I have modified the test to print the user name as well:
http://cr.openjdk.java.net/~dfuchs/webrev_8005202/webrev.01/
Looks good to me. As we discussed offline, Files.isWritable may return
true on a non-writable directory if running with
Changeset: 059530c5ae9a
Author:dfuchs
Date: 2013-11-19 22:28 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/059530c5ae9a
8005202: java/util/logging/CheckLockLocationTest.java fail on solars_10
Summary: this test has been seen failing on Solaris 10, presumably because it
was
Great, thanks Martin. I totally overlooked that flag while hunting
around globals.hpp. I've added your contribution here:
http://cr.openjdk.java.net/~robm/6703075/webrev.02/
-Rob
On 19/11/13 19:58, Martin Buchholz wrote:
I propose a fix like the diff below, that asks the VM to separate
On 19/11/2013 20:14, Martin Buchholz wrote:
In jsr166 tests we have mostly switched to 10 second timeouts to mean
forever.
But in ProcessBuilder tests we are starting up new java processes with
their well-known startup problems, so using a much larger value of
forever seems reasonable. I vote
On 19/11/2013 19:58, Martin Buchholz wrote:
I propose a fix like the diff below, that asks the VM to separate
regular output and JVM output into stdout and stderr, so that we can
do matching on each independently, and so that we can rely on stdout
not being corrupted by JVM output.
Good, it's
Changeset: f496565c4eec
Author:dxu
Date: 2013-11-19 13:22 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f496565c4eec
8028631: Improve the test coverage to the pathname handling on unix-like
platforms
Summary: Add GeneralSolaris.java testcase and fix the concurrency issue
Hi all,
Please review this small fix for an intermittent timeout. Nothing seems to be
going wrong except that if the machine running the test is exceptionally slow,
spurious timeouts will occur. The solution is to raise the timeout in the RMI
test infrastructure.
Bug:
looks fine
On Nov 19, 2013, at 5:24 PM, Stuart Marks wrote:
Hi all,
Please review this small fix for an intermittent timeout. Nothing seems to be
going wrong except that if the machine running the test is exceptionally
slow, spurious timeouts will occur. The solution is to raise the
Changeset: 19d2e9649138
Author:smarks
Date: 2013-11-19 15:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19d2e9649138
8028638:
java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails
Reviewed-by: lancea
! test/java/rmi/testlibrary/RMID.java
Hi All,
Please review the simple fix towards Size.java testcase. It failed once
on windows platform in the recent same binary run, which is mostly due
to some interferences and the special delete handling on windows.
In the fix, I remove the delete operation in initTestFile() method
because
Changeset: 66bcd5d4b3d1
Author:vromero
Date: 2013-11-19 23:35 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/66bcd5d4b3d1
8028504: javac generates LocalVariableTable even with -g:none
Reviewed-by: jjg, jlahoda
!
Hi Stuart
Did you get chance to review it again.
Let me know if you have any new comments or suggestions.
Thanks
Tristan
-邮件原件-
发件人: Tristan Yan
发送时间: Thursday, November 14, 2013 11:09 PM
收件人: Stuart Marks
抄送: core-libs-dev@openjdk.java.net
主题: 答复: RFR for JDK-7190106 RMI benchmark
Hi Martin, i incorporated the recent changes from the pointer as well. I
have reproduced the failure, the logs of which are attached to the bug
JDK-6772009 https://bugs.openjdk.java.net/browse/JDK-6772009 . The
failed log is especially interesting .
--
Thanks
kalyan
On 11/18/13 10:15 PM,
Looks ok
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Nov 19, 2013, at 6:57 PM, Dan Xu dan...@oracle.com wrote:
Hi All,
Please review the simple fix towards
On 11/19/2013 3:57 PM, Dan Xu wrote:
Hi All,
Please review the simple fix towards Size.java testcase. It failed
once on windows platform in the recent same binary run, which is
mostly due to some interferences and the special delete handling on
windows.
In the fix, I remove the delete
Hi Mandy,
I think that writing to the current directory and writing to the temp
directory will get the same interference in this testcase. Because the
interference is mostly coming from the anti-virus software or some
windows system services. Any file changes in the file system may trigger
Hi Everyone
We have a test java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java
that was put into ProblemList because of bug JDK-6933803, this test has been
fixed in
Thanks for the details Dan [1]. It is useful. The reason why I was
wondering the difference with temp dir is that the test workdir might be
excluded from the anti-virus scanner on that test machine. Now you have
explained it.
thanks
Mandy
[1]
I just rebuild jdk8/tl on Windows and calling jar uvf shows a lot of
bit length overflow
code ?? bits ?-?
A little grep shows
jdk/src/share/native/java/util/zip/zlib-1.2.5/trees.c could print this.
Something goes wrong or is it just me?
Said that, it looks like the jar file is fine.
80 matches
Mail list logo
