Looks ok to me Kumar.
-Chris.
> On 11 Jan 2014, at 00:55, Kumar Srinivasan
> wrote:
>
> Hi,
>
> Please review fixes for launcher correctness wrt. JNI calls.
>
> http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/
>
> Thanks
> Kumar
>
> On 10 Jan 2014, at 19:40, Dan Xu wrote:
>
> Thank you for all the feedback. I have updated my changes to use
> "CHECK_EXCEPTION_RETURN" and "CHECK_EXCEPTION" macro recently added into
> jni_util.h. I also removed else block in function setStaticIntField() in
> Version.c since (*env)->GetSta
On 01/10/2014 10:51 PM, srikalyan chandrashekar wrote:
Hi Peter the version you provided ran indefinitely(i put a 10 minute
timeout) and the program got interrupted(no error),
Did you run it with or without fastedbug & -XX:+TraceExceptions ? If
with, it might be that fastdebug and/or -XX:+Tra
On 11/01/2014 00:55, Kumar Srinivasan wrote:
Hi,
Please review fixes for launcher correctness wrt. JNI calls.
http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/
Looks okay, the only thing that isn't clear is whether the calls to the
static methods defined by the launcher helper class can com
On 10/01/2014 16:28, Iaroslav Savytskyi wrote:
:
There are 3 possibilities:
1) Because it was my own initiative to fix this potential synchronization bug
and nobody didn’t report it, we can approve my fix and leave this 2 classes
without synchronized getters. And fix it in MR.
2) Fix it as you
