On 11/09/2014 01:21, Martin Buchholz wrote:
For the comment in ZipInputStream then it might be better to move
that to readEnd. My preference would be to not include the part
starting "As of 2014-08, phyton ..." as that might not interesting
in years to come.
I moved the commen
On 10/09/2014 23:11, huizhe wang wrote:
Thanks Martin!
Looks like the initial version of the jaxp port (from Xerces 2.7.1)
missed the patch for reasons I don't know. I created a bug based on
the very original bug report:
https://bugs.openjdk.java.net/browse/JDK-8058175
Joe - what's the test c
On 10 Sep 2014, at 16:04, Claes Redestad wrote:
> On 09/10/2014 04:38 PM, mark.reinh...@oracle.com wrote:
>>> New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/
>> Looks fine, but when an exception declaration is on its own line then
>> the opening brace of the method should be o
Konstantin,
Looks good!
Thank you for working on the tests.
Best regards,
Vladimir Ivanov
On 9/5/14, 9:52 PM, Konstantin Shefov wrote:
Hello,
Please review the new tests for the feature "Lambda Form Reduction and
Caching" https://bugs.openjdk.java.net/browse/JDK-8046703
JBS task: https://bug
On 11/09/2014 09:43, Chris Hegarty wrote:
On 10 Sep 2014, at 16:04, Claes Redestad wrote:
On 09/10/2014 04:38 PM, mark.reinh...@oracle.com wrote:
New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/
Looks fine, but when an exception declaration is on its own line then
the openi
On 11/09/2014 10:16, Alan Bateman wrote:
I agree and much more readable since the API adjustment.
Ignoring that comment for this thread, my comment was on the parseInt
changes in your other java.net patch which are looking much better now.
-Alan
Hi Huizhe.
Done.
creates new remote head d053915e3689!
On Wed, Sep 10, 2014 at 7:13 PM, huizhe wang wrote:
> Hi Otavio,
>
> Please let me know once you've submitted it.
>
> Best,
> Joe
>
>
> On 9/10/2014 10:40 AM, Otávio Gonçalves de Santana wrote:
>
> Hi Wang.
> Thank you for this information
Hi,
I pushed this two days ago. Thank you Andrej for the contribution!
cheers
/Joel
On 9 sep 2014, at 11:21, Joel Borggrén-Franck wrote:
> Hi Andrej,
>
> Can you resend the latest patch attached to a mail to this list?
>
> cheers
> /Joel
>
> On 2014-08-29, Andrej Golovnin wrote:
>> Hi Joel,
Hello,
please review following change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8054548
webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/
It is basically replacing obsolete code using core reflection by
javax.tools API plus removing old unused code.
I ran the unit tests against b
Looks good to me, especially the added nanotime test coverage
/Claes
On 09/08/2014 07:31 PM, Lance Andersen wrote:
Hi,
Looking for a reviewer for this minor clean-up to the java.sql
Date/Time/Timestamp tests which adds support for DataProvider
Webrev can be found here: http://cr.openjdk.java
Hi all,
Few days ago I report an issue about os.name value when using jvm.dll on
Windows 8.1 ( JDK-8057122).
Today I reproduce the same issue on Windows Server 2012 r2. Running the
Java class using java.exe will report correct (meaning including r2) os.name
version, using the dll, "r2" will not be
Thanks Antoine!
I've added your update to the bug report.
https://bugs.openjdk.java.net/browse/JDK-8057122
Sincerely yours,
Ivan
On 11.09.2014 16:05, Antoine Mottier wrote:
Hi all,
Few days ago I report an issue about os.name value when using jvm.dll on
Windows 8.1 ( JDK-8057122).
Today I rep
On 11/09/2014 12:20, Miroslav Kos wrote:
Hello,
please review following change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8054548
webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/
It is basically replacing obsolete code using core reflection by
javax.tools API plus removing old unu
Hi,
I've reworked this patch after recent parseInt API updates (8055251) and
removed the test additions which are being covered by 8057826.
I also discovered a missed opportunity to apply the same optimization to
java.sql.Date which I missed earlier:
http://cr.openjdk.java.net/~redestad/805
On Sep 5, 2014, at 7:52 PM, Konstantin Shefov
wrote:
> Hello,
>
> Please review the new tests for the feature "Lambda Form Reduction and
> Caching" https://bugs.openjdk.java.net/browse/JDK-8046703
>
> JBS task: https://bugs.openjdk.java.net/browse/JDK-8057719
>
> Webrev: http://cr.openjdk.j
Thanks Ivan!
As suggest by Alan Bateman I did a test with a manifest include in the
launcher and it works!
Adding manifest like the one provided here:
http://msdn.microsoft.com/en-us/library/windows/desktop/dn302074%28v=vs.85%29.aspx
fix the issue and os.name is correctly reported as Windows 8.1 (
Hi,
requesting reviews for this patch which optimizes
java.sql.Date/Time/Timestamp::toString
by avoiding some unnecessary object allocations. java.sql.Date had
similar optimizations
applied which this patch improves upon.
bug: https://bugs.openjdk.java.net/browse/JDK-8058230
webrev: http://cr
Hi Claes,
I think this is OK, however, would like to see if others feel if
formatDecimalInt should be located elsewhere so that we just make this change
once.
Best,
Lance
On Sep 11, 2014, at 10:44 AM, Claes Redestad wrote:
> Hi,
>
> requesting reviews for this patch which optimizes
> java
Maybe consider https://bugs.openjdk.java.net/browse/JDK-6914113
Especially note the last comment there.
-Ulf
Am 11.09.2014 um 16:44 schrieb Claes Redestad:
Hi,
requesting reviews for this patch which optimizes
java.sql.Date/Time/Timestamp::toString
by avoiding some unnecessary object allocati
Could someone please review this code change ?
Thanks in advance,
Olivier Lagneau
On 09/09/2014 22:44, olivier.lagn...@oracle.com wrote:
Please review this fix in for wrong rounding-mode mode behavior of
NumberFormat.format(double) in HALF_UP case.
https://bugs.openjdk.java.net/browse/JDK-803
On 9/10/14 1:25 PM, Alan Bateman wrote:
On 10/09/2014 10:49, Daniel Fuchs wrote:
Hi,
Please find below a proposed patch for
8043306 - Provide a replacement for the API that allowed to listen
for LogManager configuration changes
https://bugs.openjdk.java.net/browse/JDK-8043306
Propos
Hi everyone,
We are thinking of removing the extcheck tool. For those who doesn't remember
what it is, here is an extract from its man page:
extcheck(1)
NAME
extcheck - jar conflict detection utility
SYNOPSIS
extcheck [ -verbose ] [ -Joption ] targetfile.jar
DESCRIPTION
The
On 9/11/2014 12:43 AM, Alan Bateman wrote:
On 10/09/2014 23:11, huizhe wang wrote:
Thanks Martin!
Looks like the initial version of the jaxp port (from Xerces 2.7.1)
missed the patch for reasons I don't know. I created a bug based on
the very original bug report:
https://bugs.openjdk.java.n
Looks ok.
I don't like the idea of having 2 copies of WB API for hotspot and jdk.
But that's tolerable unless we have shared location for test libraries
in top repository. Having reliable tests is more important IMO.
Best regards,
Vladimir Ivanov
On 9/5/14, 9:57 PM, Konstantin Shefov wrote:
On Thu, Sep 11, 2014 at 12:34 AM, Alan Bateman
wrote:
> On 11/09/2014 01:21, Martin Buchholz wrote:
>
>
>> For the comment in ZipInputStream then it might be better to move that to
>> readEnd. My preference would be to not include the part starting "As of
>> 2014-08, phyton ..." as that might no
Looks good, Lance.
Best,
Joe
On 9/11/2014 4:46 AM, Claes Redestad wrote:
Looks good to me, especially the added nanotime test coverage
/Claes
On 09/08/2014 07:31 PM, Lance Andersen wrote:
Hi,
Looking for a reviewer for this minor clean-up to the java.sql
Date/Time/Timestamp tests which add
Hello,
Hmmm. I haven't dived into the details of the code, but setScale calls
out to divide functionality so it is plausible a bug in divide could
cause a problem in setScale.
Thanks for the bug report,
-Joe
On 9/9/2014 1:30 AM, Robert Gibson wrote:
Hi there,
I came across a case in Big
Hi Ivan,
Sorry for not having gotten back to you earlier about this.
I'm uncomfortable with pushing in such a fix in the absence of a reproducer
and/or a test case. Although the change itself seems sensible, the fact that we
lack a reproducer means that we might not actually understand the pro
I see. So you're looking for a sponsor. Unfortunately, I personally
don't have circles. It would be great if you could find a sponsor.
JAXP sources came from Apache that still supports JDK 1.4. A very large
amount of code therefore are obsolete with regards to the source level.
But it's not c
On 9/11/2014 9:17 AM, Daniel Fuchs wrote:
On 9/10/14 1:25 PM, Alan Bateman wrote:
On 10/09/2014 10:49, Daniel Fuchs wrote:
Hi,
Please find below a proposed patch for
8043306 - Provide a replacement for the API that allowed to listen
for LogManager configuration changes
https://bugs
On 09/10/2014 04:41 PM, Daniel Fuchs wrote:
On 9/10/14 4:28 PM, Jason Mehrens wrote:
Daniel
I think you should be able to remove the 'other instanceof
ConfigurationListener' branch in the ConfigurationListener.equals
method. Should work the same with or without that branch.
Oh yes. I put
31 matches
Mail list logo
