Re: RFR 8068938: javax.script package description should specify use of ServiceLoader

On 11/01/2016 14:56, Sundararajan Athijegannathan wrote: Incorporated the changes suggested. Updated webrev is @ http://cr.openjdk.java.net/~sundar/8068938/webrev.01/ This looks okay to me. -Alan

JDK 9 RFR of JDK-8146762: Move back java/util/concurrent/Phaser/Basic.java to tier1

java/util/concurrent/Phaser/Basic.java This test has been moved from tier1 to tier2 (JDK-8142370) due to JDK-8141031. JDK-8141031 has been resolved in b96, and after that, not see this test fail. This patch is to move it back to tier1 bug: https://bugs.openjdk.java.net/browse/JDK-8146762 webr

JDK9 RFR of JDK-8140633: [PATCH] Method.getAnnotatedReturnType() returns empty annotations if return type is an array

Hello, I've recently was working on the bugfix for https://bugs.openjdk.java.net/browse/JDK-8140633 and as a result i got that small fix. Also I've adopted presented in bugtracker test and done jtreg test. Here is patch. This is my first contribution try, so im probably missing something. # HG c

[PATCH] 8140633: Method.getAnnotatedReturnType() returns empty annotations if return type is an array

Hello, I've recently was working on the bugfix for https://bugs.openjdk.java.net/browse/JDK-8140633 and as a result i got that small fix. Also I've adopted presented in bugtracker test and done jtreg test. Here is patch. This is my first contribution try, so im probably missing something. # HG c

Re: JDK 9 RFR of JDK-8146762: Move back java/util/concurrent/Phaser/Basic.java to tier1

Thanks for doing this Amy. Reviewed. -Chris. > On 12 Jan 2016, at 10:09, Amy Lu wrote: > > java/util/concurrent/Phaser/Basic.java > > This test has been moved from tier1 to tier2 (JDK-8142370) due to > JDK-8141031. JDK-8141031 has been resolved in b96, and after that, not see > this test fai

Re: RFR: 8072379: Implement jdk.Version and jdk.OracleVersion

On 11/01/2016 21:44, Iris Clark wrote: Hi, Joe, Roger, Alan, Magnus, and Mandy. At the end of December (shortly before the Christmas/Winter break and my vacation), I provided responses to your messages and an updated webrev: http://cr.openjdk.java.net/~iris/verona/8072379/webrev.2/ I didn't

Re: Review request 8145409: Better detect JRE that JLI will be using

Hi Dmitry, src/java.base/windows/native/libjli/java_md.c 1) use NULL -GetModuleFileName(0, buf, bufsize); +GetModuleFileName(NULL, buf, bufsize); 2) extra LF ? + * Removes the trailing file name and one sub-folder from a path. + * + * If buf is "c:\foo\bin\javac", then put "c:\foo"

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

Webrev updated in-place, moved to sun.awt.utli ( desktop module ) http://cr.openjdk.java.net/~chegar/8146735/ -Chris. On 11 Jan 2016, at 22:44, Chris Hegarty wrote: > >> On 11 Jan 2016, at 21:27, Mandy Chung wrote: >> >> On Jan 10, 2016, at 1:19 AM, Chris Hegarty wrote: >>> >>> In prepa

Re: use of Unsafe for ASCII detection

On 01/07/2016 02:21 AM, Martin Buchholz wrote: > A stupid benchmark (sorry Aleksey - maybe you already have a jmh > version of this?) http://cr.openjdk.java.net/~martin/Utf8Bench.java Okay, I'll bite: http://cr.openjdk.java.net/~shade/scratch/UTF8Scan.java As Andrew already pointed out, the tri

RFR 9: 8146671 [TEST BUG] : java/lang/ref/CleanerTest.java required more memory for -UseCompressedOops runs

Please review an update to a CleanerTest; the 4m limit is not needed and causes a problem when run with CompressedOops Webrev: http://cr.openjdk.java.net/~rriggs/webrev-cleanertest-8146671/ Issue: https://bugs.openjdk.java.net/browse/JDK-8146671 Thanks, Roger

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

> On Jan 12, 2016, at 10:30 AM, Chris Hegarty wrote: > > Webrev updated in-place, moved to sun.awt.utli ( desktop module ) > > http://cr.openjdk.java.net/~chegar/8146735/ This looks fine. Good to see it moved to java.desktop. Mandy

Re: RFR: 8072379: Implement jdk.Version and jdk.OracleVersion

> On Jan 11, 2016, at 1:44 PM, Iris Clark wrote: > > Hi, Joe, Roger, Alan, Magnus, and Mandy. > > At the end of December (shortly before the Christmas/Winter > break and my vacation), I provided responses to your messages > and an updated webrev: > > http://cr.openjdk.java.net/~iris/verona/

Re: RFR 8124977 cmdline encoding challenges on Windows

Hi Martin, Vladimir, It was suggested that this patch be tested on localized Windows machines and/or trying with the various Windows native encodings, appreciate if you can verify this as well. Thanks Kumar On 1/11/2016 1:10 PM, Kumar Srinivasan wrote: Hi, Was on vacation, I started to pre

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

I note that JavaFX optionally uses sun.misc.PerformanceLogger this in one place (via reflection). We'll need to file a new issue to clean this up. -- Kevin Mandy Chung wrote: On Jan 12, 2016, at 10:30 AM, Chris Hegarty wrote: Webrev updated in-place, moved to sun.awt.utli ( desktop module )

Re: RFR 9: 8146671 [TEST BUG] : java/lang/ref/CleanerTest.java required more memory for -UseCompressedOops runs

Looks good, Roger. -Joe On 1/12/2016 1:31 PM, Roger Riggs wrote: Please review an update to a CleanerTest; the 4m limit is not needed and causes a problem when run with CompressedOops Webrev: http://cr.openjdk.java.net/~rriggs/webrev-cleanertest-8146671/ Issue: https://bugs.openjdk.java.

Re: RFR: 8072379: Implement jdk.Version and jdk.OracleVersion

Hi Iris, Catching up on old reviews, the regular expression for versions is given as ^[1-9][0-9]*(((\.0)*\.[1-9][0-9]*)*)*$ Is this equivalent to ^[1-9][0-9]*(\.[0-9])* Trying to put this in words, "The version number starts with a sequence of digits where the leading digit is not "0

RFR (JAXP): 8146606: Catalog.matchSystem() appends an extra '/' to the matched result

Please review a fix to the match method of RewriteSystem and RewriteUri that resulted in an extra slash in the URI. Webrev: http://cr.openjdk.java.net/~joehw/jdk9/8146606/webrev/ Issue: https://bugs.openjdk.java.net/browse/JDK-8146606 Thanks, Joe