Volker,
Have the jdk8u hotspot edits been reviewed ? Looks like they should be.
Can you add a suitable noreg label to the master bug report also.
Regards,
Sean.
On 29/07/2016 19:58, Volker Simonis wrote:
Ping!
Can I please have an approval for backporting this change to 8u-dev?
Thanks,
Volk
Hi Joe,
I wonder why you compare the type obtained from an value.getClass() with
class literals for primitive types (lines 174, 176, 178):
165 Class type = value.getClass();
166 if (!type.isArray()) {
167 // primitive value, string, class, enum const, or
annotat
Hi Joe and Daniel
I have finished the rework as your comments, please check
http://cr.openjdk.java.net/~fyuan/8067170/webrev.02/
JAXP tests use Policy classes, as well as 3 other patterns provided by
JAXPTestUtilities:
1. runWithAllPerm methods, are only used for user setup code, never run jaxp
Please review http://cr.openjdk.java.net/~sundar/8159487/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8159487
OS_NAME, OS_ARCH, OS_VERSION properties are already added due to another
fix. Just adding "JAVA_VERSION" and a test change to check these
properties exist in release file.
Than
+1 for the jlink test being removed from the problem test.
-Sundar
On 8/2/2016 11:27 AM, Amy Lu wrote:
> tools/jlink/JLinkOptimTest.java
> This test has been removed in JDK-8160829
>
> sun/tools/jinfo/JInfoSanityTest.java
> sun/tools/jinfo/JInfoRunningProcessFlagTest.java
> sun/tools/jmap/hea
+1
-Sundar
On 8/2/2016 2:15 AM, Naoto Sato wrote:
> Hello,
>
> Please review this small change for the bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8162797
>
> The fix is located at:
>
> http://cr.openjdk.java.net/~naoto/8162797/webrev.00/
>
> Naoto
+1
> On Aug 2, 2016, at 8:39 AM, Sundararajan Athijegannathan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8159487/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8159487
>
> OS_NAME, OS_ARCH, OS_VERSION properties are already added due to another
> fix. Just adding
Amy,
Looks good for me!
-Dmitry
On 2016-08-02 08:57, Amy Lu wrote:
> tools/jlink/JLinkOptimTest.java
> This test has been removed in JDK-8160829
>
> sun/tools/jinfo/JInfoSanityTest.java
> sun/tools/jinfo/JInfoRunningProcessFlagTest.java
> sun/tools/jmap/heapconfig/JMapHeapConfigTest.java
>
Hi Frank,
I am intrigued by these change which do not seem
to have anything to do with the rest. I mean, I'm not opposed
as long as they are intended and that Joe validates them:
http://cr.openjdk.java.net/~fyuan/8067170/webrev.02/test/jav
Hi Kim,
This looks very good. I like the way you dealt with race between the
ReferenceHandler thread and threads waiting for it to do some cleanup
progress. I think the VM API is suitable for possible further
development on JDK-8149925. It's also nice that the whole pending list
is obtained i
Please review a test fix for an intermittently failing ProcessBuilder test.
The test should be run in a separate vm so it only sees Zombies from
processes it creates.
When run in-process with jtreg, it may see Zombies from other processes
created by jtreg.
Additional diagnostic information is a
Hi Roger,
Running in othervm looks good to me.
The only thing I wonder about is these lines which are
removed:
79 // Log remaining processes
80 ProcessBuilder pb = new ProcessBuilder("/bin/ps", "-ef");
81 pb.inheritIO();
82 Process p2 = pb.
Hi Daniel,
Those were added in a previous diagnostic iteration.
They do a separate ps which might be too late to provide any using
information.
The first perl script retains and prints the suspect processes and
should be enough debugging info.
(There is no harm in retaining this extra info but
On 02/08/16 15:03, Roger Riggs wrote:
Hi Daniel,
Those were added in a previous diagnostic iteration.
They do a separate ps which might be too late to provide any using
information.
The first perl script retains and prints the suspect processes and
should be enough debugging info.
(There is no
On 8/1/16 9:30 PM, Chris Plummer wrote:
On 8/1/16 7:25 PM, David Holmes wrote:
On 2/08/2016 12:11 PM, Chris Plummer wrote:
On 8/1/16 5:58 PM, David Holmes wrote:
Hi Chris,
On 2/08/2016 8:46 AM, Chris Plummer wrote:
Hello,
Please review this simple change:
https://bugs.openjdk.java.net/brow
Hi Peter,
On 8/2/2016 1:59 AM, Peter Levart wrote:
Hi Joe,
I wonder why you compare the type obtained from an value.getClass()
with class literals for primitive types (lines 174, 176, 178):
165 Class type = value.getClass();
166 if (!type.isArray()) {
167 // p
> On Aug 2, 2016, at 8:55 AM, Peter Levart wrote:
>
> Hi Kim,
>
> This looks very good. I like the way you dealt with race between the
> ReferenceHandler thread and threads waiting for it to do some cleanup
> progress. I think the VM API is suitable for possible further development on
> JDK-8
Hi Sean,
thanks a lot for your reply.
You're right - I'm still waiting for a review of the hotspot part. Any
volunteers :)
Regarding the noreg label: I used 'noreg-other' because there already
exist AES tests (they have never been part of this original change).
Is that the right label? There are
On 8/2/16, 5:30 AM, Daniel Fuchs wrote:
Hi Frank,
I am intrigued by these change which do not seem
to have anything to do with the rest. I mean, I'm not opposed
as long as they are intended and that Joe validates them:
http://cr.openjdk
> On Aug 1, 2016, at 2:47 PM, Kim Barrett wrote:
>
> This updated webrev addresses concerns about the performance of the VM
> API used by the reference processor thread in the original webrev.
>
> New webrevs:
> full: http://cr.openjdk.java.net/~kbarrett/8156500/jdk.03/
> http://cr.openjdk.
other than that previously discussed,
in
test/javax/xml/jaxp/functional/javax/xml/parsers/ptests/DocumentBuilderFactoryTest.java
the comments related to the removed code can be removed as well
test/javax/xml/jaxp/functional/javax/xml/parsers/ptests/SAXParserTest.java
@Test(expectedExceptions =
Looks good.
Thanks,
David
On 3/08/2016 12:50 AM, Chris Plummer wrote:
On 8/1/16 9:30 PM, Chris Plummer wrote:
On 8/1/16 7:25 PM, David Holmes wrote:
On 2/08/2016 12:11 PM, Chris Plummer wrote:
On 8/1/16 5:58 PM, David Holmes wrote:
Hi Chris,
On 2/08/2016 8:46 AM, Chris Plummer wrote:
Hell
Hi Daniel
> -Original Message-
> From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
> Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit
> tests
>
> Hi Frank,
>
> I am intrigued by these change which do not seem
> to have anything to do with the rest. I mean, I'
23 matches
Mail list logo
