RE: RFR: 8189102: All tools should support -?, -h and --help

2017-11-20 Thread Lindenmaier, Goetz
Hi Jon, thanks for your feedback. Sorry for getting the javac/Javadoc wrong, I missed that. The point is that the option implementation there does not have the possibility to accept an option but not document it. javac: I'd like to propose to add -help again. javac else prints: javac: inval

RE: RFR: 8189102: All tools should support -?, -h and --help

2017-11-20 Thread Lindenmaier, Goetz
Hi Robert, thanks for looking at my change. I'm fine with listing the flags in a different order, but it's ambiguous. Java itslef lists "-? -h --help" therefore I chose this for most of the tools, too. But just tell me how to put it. Below, I list all the option help messages for the tools on

Re: [10] RFR 8176841: Additional Unicode Language-Tag Extensions

2017-11-20 Thread Stephen Colebourne
I've had a longer think about how to integrate this. Its very tricky, as the unicode extensions create complex conflicts. In general, my view is that Locale is too complex and overloaded with different levels of meaning. Perhaps a different class should have been added for more complex localizatio

RE: RFR: 8189102: All tools should support -?, -h and --help

2017-11-20 Thread Lindenmaier, Goetz
Hi Alan, thanks for looking at my change. Thanks for pointing to JEP 293. I see my change mostly follows its ideas. As Jon, I don't think asking for support of -help makes sense as it's not according to the gnu style, and it's not that hard to get it right anyways. I'll remove the edits to the

RE: RFR: 8189102: All tools should support -?, -h and --help

2017-11-20 Thread Lindenmaier, Goetz
Hi Max, I think there are so many tools mixing both kinds of options, that it's rather a gain if all at least document the same, up to date help message, than if the documentation is skipped for some. After my change, all the help messages are quite similar. I updated them to use the same wordi

Re: RFR: 8189102: All tools should support -?, -h and --help

2017-11-20 Thread Alan Bateman
On 20/11/2017 13:41, Lindenmaier, Goetz wrote: : The deprecated tools are orbd, wsgen wsimport schemagen Is that correct? Yes, plus xjc, idlj, servertool and tnameserv (the full list is in the draft JEP that I linked to). -Alan

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

2017-11-20 Thread Alan Bateman
On 17/11/2017 16:53, Xueming Shen wrote: On 11/17/17, 3:35 AM, Alan Bateman wrote: : 1. getRealName is very welcome but I think it should be a no-arg method on JarEntry, not JarFile. That would make it easier to use and also avoids the temptation to call JarFile.getRealName with an entry i

Re: RFR: 8189102: All tools should support -?, -h and --help

2017-11-20 Thread Weijun Wang
Hi Goetz I understand your intention. If the reason is that one day every tool will switch to this new style, please at least do not include kinit, klist and ktab. These Windows-only commands are meant to emulate MIT krb5 tools with the same names and we need to keep the option (and maybe the

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

2017-11-20 Thread Alan Bateman
On 17/11/2017 16:53, Xueming Shen wrote: : 3. Is ZipFile.entryNameStream really needed? Just asking because zf.stream().map(ZipEntry::getName) is possible today. It's not a "must" for sure. The motivation behind this is that my observation of most normal use scenario inside JDK is that only

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

2017-11-20 Thread Xueming Shen
Hi Alan, Here is the updated webrev with (1) to move JarFile.getRealName into JarEntry (2) to hide ZipFile.entryNameStream() from the public (3) to reword the JarFile.versionedStream() to scope the "latest versined" http://cr.openjdk.java.net/~sherman/8189611/webrev thanks, Sherman On 11/20/1

Re: 8181175 Stream.concat behaves like terminal operation

2017-11-20 Thread Paul Sandoz
> On 17 Nov 2017, at 17:18, Stuart Marks wrote: > > Hi Paul, > > The normative text about binding to the source and subsequent modifications > to the source possibly not being reflected in the stream makes sense. > > I'm having trouble understanding the API note though. What does "optimal"

Moving dynamic constants to 11 Re: [10] RFR 8186046 Minimal ConstantDynamic support

2017-11-20 Thread Paul Sandoz
Hi, The schedule of dynamic constants has been adjusted, the JEP is currently proposed to target for 11. There is risk to integrating a change such as constant dynamic this late in the 10 release schedule. Instead it's better, and more aligned with the new release process, to integrate early o

Re: Moving dynamic constants to 11 Re: [10] RFR 8186046 Minimal ConstantDynamic support

2017-11-20 Thread mark . reinhold
2017/11/20 11:56:42 -0800, paul.san...@oracle.com: > The schedule of dynamic constants has been adjusted, the JEP is > currently proposed to target for 11. > > There is risk to integrating a change such as constant dynamic this > late in the 10 release schedule. Instead it's better, and more align

RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-20 Thread Brian Burkhalter
https://bugs.openjdk.java.net/browse/JDK-8191516 http://cr.openjdk.java.net/~bpb/8191516/webrev.00/ Change OutputStream.write(byte[],int,int) to use the same three parameter bounds checks used by InputStream.read(byte[],int,int) instead of the five checks currently used. This change is covered b

Re: [10] RFR 8176841: Additional Unicode Language-Tag Extensions

2017-11-20 Thread Naoto Sato
Hi Stephen, please see my comments below. On 11/20/17 5:27 AM, Stephen Colebourne wrote: I've had a longer think about how to integrate this. Its very tricky, as the unicode extensions create complex conflicts. In general, my view is that Locale is too complex and overloaded with different leve

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

2017-11-20 Thread Paul Sandoz
> On 20 Nov 2017, at 10:27, Xueming Shen wrote: > > Hi Alan, > > Here is the updated webrev with > > (1) to move JarFile.getRealName into JarEntry > (2) to hide ZipFile.entryNameStream() from the public > (3) to reword the JarFile.versionedStream() to scope the "latest versined" > > http://c

Re: RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-20 Thread Paul Sandoz
> On 20 Nov 2017, at 16:53, Brian Burkhalter > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8191516 > http://cr.openjdk.java.net/~bpb/8191516/webrev.00/ > > Change OutputStream.write(byte[],int,int) to use the same three parameter > bounds checks used by InputStream.read(byte[],int,in

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

2017-11-20 Thread Xueming Shen
Thanks Paul! Webrev has been updated as suggested. http://cr.openjdk.java.net/~sherman/8189611/webrev jdeps' VersionHelper.java still accesses the "getRealName()" via the SharedSecrets. Since jdeps is being compiled/built with the bootjdk, I'm leaving it untouched for now. -

Re: JDK-6372077: JarFile.getManifest() should handle manifest attribute names up to 70 bytes

2017-11-20 Thread Philipp Kunz
Hi everyone, I haven't got any reply now for around three weeks and now i start to wonder if I just missed it or if I should refine my approach to find a sponsor or if it helped if I presented a ready patch or if noone considers this important enough or anything else whatever. This is only my